ipv6: use ND_REACHABLE_TIME and ND_RETRANS_TIMER instead of magic number
Subsystems (3)
PATCH v2 3/4 ipv6: use ND_REACHABLE_TIME and ND_RETRANS_TIMER instead of magic number
ND_REACHABLE_TIME and ND_RETRANS_TIMER have defined since v2.6.12-rc2, but never been used.
So use them instead of magic number.
This patch also changes original code style to read comfortably .
Thank YOSHIFUJI Hideaki for pointing it out.
Signed-off-by Shan Wei <[email protected]>
--- net/ipv6/ndisc.c | 24 ++++++++++++------------ 1 files changed, 12 insertions(+), 12 deletions(-)
net/ipv6/ndisc.c +12 -12
@@ -141,18 +141,18 @@ struct neigh_table nd_tbl = { .proxy_redo = pndisc_redo, .id = "ndisc_cache", .parms = { - .tbl = &nd_tbl, - .base_reachable_time = 30 * HZ, - .retrans_time = 1 * HZ, - .gc_staletime = 60 * HZ, - .reachable_time = 30 * HZ, - .delay_probe_time = 5 * HZ, - .queue_len = 3, - .ucast_probes = 3, - .mcast_probes = 3, - .anycast_delay = 1 * HZ, - .proxy_delay = (8 * HZ) / 10, - .proxy_qlen = 64, + .tbl = &nd_tbl, + .base_reachable_time = ND_REACHABLE_TIME, + .retrans_time = ND_RETRANS_TIMER, + .gc_staletime = 60 * HZ, + .reachable_time = ND_REACHABLE_TIME, + .delay_probe_time = 5 * HZ, + .queue_len = 3, + .ucast_probes = 3, + .mcast_probes = 3, + .anycast_delay = 1 * HZ, + .proxy_delay = (8 * HZ) / 10, + .proxy_qlen = 64, }, .gc_interval = 30 * HZ, .gc_thresh1 = 128,
Signature · 1 line
1.6.3.3
From: Shan Wei <[email protected]>
Date: Thu, 02 Dec 2010 12:05:12 +0800
Quoted 10 lines
ND_REACHABLE_TIMEandND_RETRANS_TIMERhave defined since v2.6.12-rc2, but never been used.
So use them instead of magic number.This patch also changes original code style to read comfortably .
Thank YOSHIFUJI Hideaki for pointing it out.
Signed-off-by Shan Wei <[email protected]>
Applied.