Skip to contentSkip to conversation

ARM: make timer variables in gt_t available for all ARM platforms

PATCH New Prafulla Wadaskar 3 participants 5 messages Dec 1, 2010 – Dec 8, 2010 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: make timer variables in gt_t available for all ARM platforms

After ARM relocation,
any code executed directly or indirectly by board_init_f() have global (BSS) variables need to be fixed. mostly timer.c needs to fix on most of the ARM platforms.

This patch makes timer related variables in gd_t available for all ARM implementation

---
 arch/arm/include/asm/global_data.h |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
arch/arm/include/asm/global_data.h +3 -1
index ada3fbb..efb502e 100644
@@ -55,7 +55,9 @@ typedef	struct	global_data {
 	unsigned long	plla_rate_hz;
 	unsigned long	pllb_rate_hz;
 	unsigned long	at91_pllb_usb_init;
-	/* "static data" needed by at91's timer.c */
+#endif
+#ifdef CONFIG_ARM
+	/* "static data" needed by most of timer.c on ARM platforms */
 	unsigned long	timer_rate_hz;
 	unsigned long	tbl;
 	unsigned long	tbu;
Signature · 1 line
1.6.0.3
#1 lore raw

PATCH 1/1 ARM: make timer variables in gt_t available for all ARM platforms

Quoted 18 lines · Prafulla Wadaskar

After ARM relocation,
any code executed directly or indirectly by board_init_f() have global (BSS) variables need to be fixed. mostly timer.c needs to fix on most of the ARM platforms.

This patch makes timer related variables in gd_t available for all ARM implementation

---
 arch/arm/include/asm/global_data.h |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
arch/arm/include/asm/global_data.h +0 -0
index ada3fbb..efb502e 100644

arch/arm/include/asm/global_data.h typedef struct global_data { · line 63

Quoted 10 lines
arch/arm/include/asm/global_data.h +3 -1
@@ -55,7 +55,9 @@ typedef	struct	global_data {
 	unsigned long	plla_rate_hz;
 	unsigned long	pllb_rate_hz;
 	unsigned long	at91_pllb_usb_init;
-	/* "static data" needed by at91's timer.c */
+#endif
+#ifdef CONFIG_ARM
+	/* "static data" needed by most of timer.c on ARM platforms */
 	unsigned long	timer_rate_hz;
 	unsigned long	tbl;
 	unsigned long	tbu;

This file is ARM specific. Doesn't this mean CONFIG_ARM is always defined here?

Regards,
Nick.

#2 lore raw

PATCH 1/1 ARM: make timer variables in gt_t available for all ARM platforms

In reply to Prafulla Wadaskar
Quoted 30 lines

-----Original Message-----
From: Prafulla Wadaskar [mailto:prafulla at marvell.com]
Sent: Wednesday, December 01, 2010 5:47 PM
To: u-boot at lists.denx.de
Cc: Manas Saksena; Prabhanjan Sarnaik; Ashish Karkare; Prafulla Wadaskar
Subject: [PATCH] ARM: make timer variables in gt_t available for all ARM platforms

After ARM relocation,
any code executed directly or indirectly by board_init_f() have global (BSS) variables need to be fixed. mostly timer.c needs to fix on most of the ARM platforms.

This patch makes timer related variables in gd_t available for all ARM implementation

---
 arch/arm/include/asm/global_data.h |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
arch/arm/include/asm/global_data.h +0 -0
index ada3fbb..efb502e 100644
@@ -55,7 +55,9 @@ typedef	struct	global_data {
 	unsigned long	plla_rate_hz;

arch/arm/include/asm/global_data.h typedef struct global_data {

Quoted 10 lines
arch/arm/include/asm/global_data.h +3 -2
 	unsigned long	pllb_rate_hz;
 	unsigned long	at91_pllb_usb_init;
-	/* "static data" needed by at91's timer.c */
+#endif
+#ifdef CONFIG_ARM
+	/* "static data" needed by most of timer.c on ARM platforms */
 	unsigned long	timer_rate_hz;
 	unsigned long	tbl;
 	unsigned long	tbu;
--

Applied to u-boot-marvell.git master branch

Regards..
Prafulla ..

#3 lore raw

PATCH 1/1 ARM: make timer variables in gt_t available for all ARM platforms

Dear Prafulla Wadaskar,

Quoted 3 lines · In message <[email protected]>…
Quoted 3 lines

This patch makes timer related variables in gd_t available for all ARM implementation

---^^^^^^^^^

Quoted 1 line

Applied to u-boot-marvell.git master branch

Thisis NOT a Marvell specific commit. It is not supposed to go through the Marvell repository. It is a common ARM patch and should go through the ARM repo.

Thanks.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Anything free is worth what you pay for it.
#4 lore raw

PATCH 1/1 ARM: make timer variables in gt_t available for all ARM platforms

In reply to Prafulla Wadaskar

Dear Prafulla Wadaskar,

Quoted 5 lines · In message <[email protected]> you wrote:

After ARM relocation,
any code executed directly or indirectly by board_init_f() have global (BSS) variables need to be fixed. mostly timer.c needs to fix on most of the ARM platforms.

Quoted 7 lines

This patch makes timer related variables in gd_t available for all ARM implementation

---
 arch/arm/include/asm/global_data.h |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 7 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Do you know about being with somebody? Wanting to be? If  I  had  the
whole  universe,  I'd  give it to you, Janice. When I see you, I feel
like I'm hungry all over. Do you know how that feels?
	-- Charlie Evans, "Charlie X", stardate 1535.8