b43: N-PHY: update init tables
PATCH 1/4 b43: N-PHY: update init tables
Hi, ALL,
-----Original Message-----
Quoted 94 lines
From: Larry Finger <[email protected]>
Sent: Dec 7, 2010 11:19 AM
To: Hauke Mehrtens <[email protected]>
Cc: linux-wireless at vger.kernel.org, b43-dev at lists.infradead.org
Subject: Re: [PATCH 1/4] b43: N-PHY: update init tablesQuoted 78 lines · Hauke Mehrtens
Quoted 36 lines · Rafa? Mi?ecki
Signed-off-by Rafa? Mi?ecki <[email protected]>--- drivers/net/wireless/b43/tables_nphy.c | 212 ++++++++++++++++---------------- 1 files changed, 106 insertions(+), 106 deletions(-)drivers/net/wireless/b43/tables_nphy.c +7
-16@@ -28,41 +28,41 @@#include "phy_n.h" static const u8 b43_ntab_adjustpower0[] = { -0x00 ,0x00 ,0x00 ,0x00 ,0x01 ,0x01 ,0x01 ,0x01 , -0x02 ,0x02 ,0x02 ,0x02 ,0x03 ,0x03 ,0x03 ,0x03 , -0x04 ,0x04 ,0x04 ,0x04 ,0x05 ,0x05 ,0x05 ,0x05 , -0x06 ,0x06 ,0x06 ,0x06 ,0x07 ,0x07 ,0x07 ,0x07 , -0x08 ,0x08 ,0x08 ,0x08 ,0x09 ,0x09 ,0x09 ,0x09 , -0x0A ,0x0A ,0x0A ,0x0A ,0x0B ,0x0B ,0x0B ,0x0B , -0x0C ,0x0C ,0x0C ,0x0C ,0x0D ,0x0D ,0x0D ,0x0D , -0x0E ,0x0E ,0x0E ,0x0E ,0x0F ,0x0F ,0x0F ,0x0F , -0x10 ,0x10 ,0x10 ,0x10 ,0x11 ,0x11 ,0x11 ,0x11 , -0x12 ,0x12 ,0x12 ,0x12 ,0x13 ,0x13 ,0x13 ,0x13 , -0x14 ,0x14 ,0x14 ,0x14 ,0x15 ,0x15 ,0x15 ,0x15 , -0x16 ,0x16 ,0x16 ,0x16 ,0x17 ,0x17 ,0x17 ,0x17 , -0x18 ,0x18 ,0x18 ,0x18 ,0x19 ,0x19 ,0x19 ,0x19 , -0x1A ,0x1A ,0x1A ,0x1A ,0x1B ,0x1B ,0x1B ,0x1B , -0x1C ,0x1C ,0x1C ,0x1C ,0x1D ,0x1D ,0x1D ,0x1D , -0x1E ,0x1E ,0x1E ,0x1E ,0x1F ,0x1F ,0x1F ,0x1F , +0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 , +0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 , +0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 , +0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 , +0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 , +0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 , +0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,drivers/net/wireless/b43/tables_nphy.c line 47
Quoted 10 lines
drivers/net/wireless/b43/tables_nphy.c +9
-0+0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 , +0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 , +0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 , +0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 , +0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 , +0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 , +0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 , +0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 , + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, };Why do you have this table when it only contains
0x00? If it is correct there will be a better way to define such a table.Quoted 28 lines
drivers/net/wireless/b43/tables_nphy.c +10
-16static const u8 b43_ntab_adjustpower1[] = { -0x00 ,0x00 ,0x00 ,0x00 ,0x01 ,0x01 ,0x01 ,0x01 , -0x02 ,0x02 ,0x02 ,0x02 ,0x03 ,0x03 ,0x03 ,0x03 , -0x04 ,0x04 ,0x04 ,0x04 ,0x05 ,0x05 ,0x05 ,0x05 , -0x06 ,0x06 ,0x06 ,0x06 ,0x07 ,0x07 ,0x07 ,0x07 , -0x08 ,0x08 ,0x08 ,0x08 ,0x09 ,0x09 ,0x09 ,0x09 , -0x0A ,0x0A ,0x0A ,0x0A ,0x0B ,0x0B ,0x0B ,0x0B , -0x0C ,0x0C ,0x0C ,0x0C ,0x0D ,0x0D ,0x0D ,0x0D , -0x0E ,0x0E ,0x0E ,0x0E ,0x0F ,0x0F ,0x0F ,0x0F , -0x10 ,0x10 ,0x10 ,0x10 ,0x11 ,0x11 ,0x11 ,0x11 , -0x12 ,0x12 ,0x12 ,0x12 ,0x13 ,0x13 ,0x13 ,0x13 , -0x14 ,0x14 ,0x14 ,0x14 ,0x15 ,0x15 ,0x15 ,0x15 , -0x16 ,0x16 ,0x16 ,0x16 ,0x17 ,0x17 ,0x17 ,0x17 , -0x18 ,0x18 ,0x18 ,0x18 ,0x19 ,0x19 ,0x19 ,0x19 , -0x1A ,0x1A ,0x1A ,0x1A ,0x1B ,0x1B ,0x1B ,0x1B , -0x1C ,0x1C ,0x1C ,0x1C ,0x1D ,0x1D ,0x1D ,0x1D , -0x1E ,0x1E ,0x1E ,0x1E ,0x1F ,0x1F ,0x1F ,0x1F , +0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 , +0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 , +0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 , +0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 , +0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 , +0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 , +0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 , +0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 , +0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 , +0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,Quoted 8 lines
drivers/net/wireless/b43/tables_nphy.c line 65
Quoted 7 lines
drivers/net/wireless/b43/tables_nphy.c +6
-0+0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 , +0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 , +0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 , +0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 , +0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 , + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, };Same here.
Quoted 3 lines
One reason is that these tables changed from non-zero to zero values between Broadcom driver 4.174.64.19 and 5.10.56.46. As they might change again, I think we should retain the full version.
Is there a way to check for version of the driver? This way whoever uses old one won't be screwed...
Thank you.
Quoted 9 lines
Larry
_______________________________________________
b43-dev mailing list
b43-dev at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
PATCH 1/4 b43: N-PHY: update init tables
Quoted 6 lines · On 12/07/2010 01:49 PM, [email protected] wrote:
Quoted 3 lines
One reason is that these tables changed from non-zero to zero values between Broadcom driver 4.174.64.19 and 5.10.56.46. As they might change again, I think we should retain the full version.
Is there a way to check for version of the driver? This way whoever uses old one won't be screwed...
That will not be a problem as no older version of b43 works at all with b43. To help you understand this change, when the 4.174.64.19 Broadcom driver was reverse-engineered, the tables had non-zero values. Rafel later compared the trace dumps of b43 with the latest version of wl and found that the values are now zero. When I rechecked driver 5.10.56.46, I found them to be zero there as well and changed the specs.
Larry