Skip to contentSkip to conversation

OMAP3: add CM-T35 board

PATCH Superseded Mike Rapoport 2 participants 2 messages Dec 8, 2010

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 OMAP3: add CM-T35 board

This patch adds support for CM-T35 board

---

v2 changes:
* address Nishanth's comments

 MAINTAINERS              |    4 +
 MAKEALL                  |    1 +
 board/cm_t35/Makefile    |   47 ++++++
 board/cm_t35/cm_t35.c    |  222 ++++++++++++++++++++++++++++
 board/cm_t35/cm_t35.h    |  184 +++++++++++++++++++++++
 board/cm_t35/config.mk   |   30 ++++
 boards.cfg               |    1 +
 doc/README.omap3         |   16 ++-
 include/configs/cm_t35.h |  369 ++++++++++++++++++++++++++++++++++++++++++++++
 9 files changed, 872 insertions(+), 2 deletions(-)
 create mode 100644 board/cm_t35/Makefile
 create mode 100644 board/cm_t35/cm_t35.c
 create mode 100644 board/cm_t35/cm_t35.h
 create mode 100644 board/cm_t35/config.mk
 create mode 100644 include/configs/cm_t35.h
MAINTAINERS +4 -0
index 9258cb1..b44b843 100644
@@ -750,6 +750,10 @@ Stelian Pop <[email protected]>
 	at91sam9263ek	ARM926EJS (AT91SAM9263 SoC)
 	at91sam9rlek	ARM926EJS (AT91SAM9RL SoC)
 
+Mike Rapoport <[email protected]>
+
+	cm_t35		ARM ARMV7 (OMAP3xx SoC)
+
 Tom Rix <[email protected]>
 
 	omap3_zoom2	ARM ARMV7 (OMAP3xx SoC)
MAKEALL +1 -0
index c54c6e8..e0fe12f 100755
@@ -412,6 +412,7 @@ LIST_ARM11="			\
 LIST_ARMV7="		\
 	am3517_evm		\
 	ca9x4_ct_vxp		\
+	cm_t35			\
 	devkit8000		\
 	igep0020		\
 	igep0030		\
board/cm_t35/Makefile new file +47 -0

47 lines not on this page · raw message

board/cm_t35/cm_t35.c new file +222 -0

222 lines not on this page · raw message

board/cm_t35/cm_t35.h new file +184 -0

184 lines not on this page · raw message

board/cm_t35/config.mk new file +30 -0
new file mode 100644
index 0000000..e81e283
@@ -0,0 +1,30 @@
+#
+# (C) Copyright 2009
+# CompuLab, Ltd., <www.compulab.co.il>
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+# Physical Address:
+# 8000'0000 (bank0)
+#
+# Linux-Kernel is expected to be at 8000'8000, entry 8000'8000
+# (mem base + reserved)
+
+# For use with external or internal boots.
+CONFIG_SYS_TEXT_BASE = 0x80008000
boards.cfg +1 -0
index 6c2a667..e79b2d7 100644
@@ -392,6 +392,7 @@ igep0020	arm	armv7		igep0020	isee		omap3
 igep0030	arm	armv7		igep0030	isee		omap3
 am3517_evm	arm	armv7		am3517evm	logicpd		omap3
 devkit8000	arm	armv7		devkit8000	timll		omap3
+cm_t35		arm	armv7		cm_t35		-		omap3
 omap4_panda	arm	armv7		panda		ti		omap4
 omap4_sdp4430	arm	armv7		sdp4430		ti		omap4
 s5p_goni	arm	armv7		goni		samsung		s5pc1xx
doc/README.omap3 +8 -1
index 6227151..460950d 100644
@@ -21,6 +21,8 @@ Currently the following boards are supported:
 
 * TI/Logic PD Zoom 2 [7]
 
+* CompuLab Ltd. CM-T35 [8]
+
 Toolchain
 =========
 
@@ -61,6 +63,11 @@ make
 make omap3_zoom2_config
 make
 
+* CM-T35:
+
+make cm_t35_config
+make
+
 Custom commands
 ===============
 
@@ -119,7 +126,7 @@ To read a bit :
 Acknowledgements
 ================
 
-OMAP3 U-Boot is based on U-Boot tar ball [8] for BeagleBoard and EVM done by
+OMAP3 U-Boot is based on U-Boot tar ball [9] for BeagleBoard and EVM done by
 several TI employees.
 
 Links
@@ -153,6 +160,11 @@

http://www.logicpd.com/products/devkit/ti/zoom_mobile_development_kit
[7] TI/Logic PD Zoom 2

http://www.logicpd.com/sites/default/files/1012659A_Zoom_OMAP34x-II_MDP_Brief.pdf
-[8] TI OMAP3 U-Boot:
+
+[8] CompuLab Ltd. CM-T35:
+ +http://www.compulab.co.il/t3530/html/t3530-cm-datasheet.htm +
+[9] TI OMAP3 U-Boot:

http://beagleboard.googlecode.com/files/u-boot_beagle_revb.tar.gz

include/configs/cm_t35.h new file +369 -0

369 lines not on this page · raw message

Signature · 6 lines
1.7.3.1


-- 
Sincerely yours,
Mike.
#1 lore raw

PATCH v2 1/1 OMAP3: add CM-T35 board

Dear Mike Rapoport,

Quoted 5 lines · In message <[email protected]> you wrote:

This patch adds support for CM-T35 board

---

...

MAKEALL LIST_ARM11=" \ · line 418

Quoted 12 lines
MAKEALL +1 -0
index c54c6e8..e0fe12f 100755
@@ -412,6 +412,7 @@ LIST_ARM11="			\
 LIST_ARMV7="		\
 	am3517_evm		\
 	ca9x4_ct_vxp		\
+	cm_t35			\
 	devkit8000		\
 	igep0020		\
 	igep0030		\

Boards don't get added to MAKEALL any more. Please verify that your board automatically gets picked up from boards.cfg

Quoted 4 lines
MAKEALL +4 -0
+/*
+ * Routine: misc_init_r
+ * Description: Init ethernet (done here so udelay works)
+ */

MAKEALL

Quoted 10 lines
MAKEALL +10 -0
+int misc_init_r(void)
+{
+#ifdef CONFIG_DRIVER_OMAP34XX_I2C
+	i2c_init(CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SLAVE);
+#endif
+
+	dieid_num_r();
+
+	return 0;
+}

Comment and code don't appear to match.

MAKEALL

Quoted 10 lines
MAKEALL +10 -0
+/*
+ * Routine: set_muxconf_regs
+ * Description: Setting up the configuration Mux registers specific to the
+ *		hardware. Many pins need to be moved from protect to primary
+ *		mode.
+ */
+void set_muxconf_regs(void)
+{
+	MUX_CM_T35();
+}

Why don't you write this code here directly? Adding another macro level here just obfuscates the code. Or what is your rationale for moving this into a header file ?

MAKEALL

Quoted 5 lines
MAKEALL +5 -0
+#ifdef CONFIG_GENERIC_MMC
+int board_mmc_init(bd_t *bis)
+{
+	omap_mmc_init(0);
+	return 0;

Error handling?

MAKEALL

Quoted 7 lines
MAKEALL +7 -0
+static int handle_mac_address(void)
+{
+	unsigned char enetaddr[6];
+	int rc;
+
+	memset(enetaddr, 0, 6);
+	rc = eth_getenv_enetaddr("ethaddr", enetaddr);

What exactly is the memset() good for?

Quoted 5 lines
board/cm_t35/config.mk new file +0 -0
new file mode 100644
index 0000000..e81e283

...

Quoted 1 line

+CONFIG_SYS_TEXT_BASE = 0x80008000

Please move to board config file and get rid of config.mk

Quoted 2 lines
include/configs/cm_t35.h new file +0 -0

...

include/configs/cm_t35.h line 104

Quoted 6 lines
include/configs/cm_t35.h new file +6 -0
+/*
+ * select serial console configuration
+ */
+#define CONFIG_CONS_INDEX		3
+#define CONFIG_SYS_NS16550_COM3		OMAP34XX_UART3
+#define CONFIG_SERIAL3			3	/* UART3 on Beagle Rev 2 */

Beagle Rev 2?

Quoted 1 line

+#undef CONFIG_CMD_IMI /* iminfo */

What is the exact reson for disabling iminfo ?

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You see but you do not observe.
Sir Arthur Conan Doyle, in "The Memoirs of Sherlock Holmes"