Skip to contentSkip to conversation

silence compiler warnings

PATCH In review Jim Rees 2 participants 2 messages Dec 3, 2010 – Dec 9, 2010

Subsystems (2)
lore
Share & tools
lore

Jim Rees

author
#0 lore raw

PATCH 2/2 silence compiler warnings

---
 utils/blkmapd/device-process.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)
utils/blkmapd/device-process.c +2 -3
index 0d8705f..91b0afc 100644
@@ -53,14 +53,13 @@ static char *pretty_sig(char *sig, uint32_t siglen)
 {
 	static char rs[100];
 	uint64_t sigval;
+	unsigned int i;
 
 	if (siglen <= sizeof(sigval)) {
-		int i;
-
 		sigval = 0;
 		for (i = 0; i < siglen; i++)
 			sigval |= ((unsigned char *)sig)[i] << (i * 8);
-		sprintf(rs, "0x%0llx", sigval);
+		sprintf(rs, "0x%0llx", (unsigned long long) sigval);
 	} else {
 		if (siglen > sizeof rs - 4) {
 			siglen = sizeof rs - 4;
Signature · 1 line
1.7.1
#1 lore raw

Merged both at pnfs-nfs-utils-1-2-4-rc3-2010-12-03

Thanks!

Benny

Quoted 26 lines · Jim Rees
---
 utils/blkmapd/device-process.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)
utils/blkmapd/device-process.c +2 -3
index 0d8705f..91b0afc 100644
@@ -53,14 +53,13 @@ static char *pretty_sig(char *sig, uint32_t siglen)
 {
 	static char rs[100];
 	uint64_t sigval;
+	unsigned int i;
 
 	if (siglen <= sizeof(sigval)) {
-		int i;
-
 		sigval = 0;
 		for (i = 0; i < siglen; i++)
 			sigval |= ((unsigned char *)sig)[i] << (i * 8);
-		sprintf(rs, "0x%0llx", sigval);
+		sprintf(rs, "0x%0llx", (unsigned long long) sigval);
 	} else {
 		if (siglen > sizeof rs - 4) {
 			siglen = sizeof rs - 4;