Skip to contentSkip to conversation

t9143: do not fail when unhandled.log.gz is not created

PATCH In review Torsten Bögershausen 3 participants 3 messages Jun 15, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 t9143: do not fail when unhandled.log.gz is not created

Do not depend on internal implementation details of svn, which right now uses perl to create a .gz file. So this test case will even work in the future, when svn changes its implementation.

---
 t/t9143-git-svn-gc.sh |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
t/t9143-git-svn-gc.sh +0 -0
index 337ea59..4594e1a 100755
@@ -37,13 +37,11 @@ test_expect_success 'git svn gc runs' 'git svn gc'
  test_expect_success 'git svn index removed' '! test -f 

.git/svn/refs/remotes/git-svn/index'
-if perl -MCompress::Zlib -e 0 2>/dev/null
+if test -r .git/svn/refs/remotes/git-svn/unhandled.log.gz
then
test_expect_success 'git svn gc produces a valid gzip file' '
gunzip .git/svn/refs/remotes/git-svn/unhandled.log.gz
'
-else
- say "# Perl Compress::Zlib unavailable, skipping gunzip test"
fi
test_expect_success 'git svn gc does not change unhandled.log files' '

Signature · 1 line
1.6.6
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Torsten Bögershausen

Do not depend on internal implementation details of svn, which right now uses perl to create a .gz file. So this test case will even work in the future, when svn changes its implementation.

Thanks Torsten, I needed to fix whitespace mangling from your mailer to get it to apply cleanly.

It's pushed out to git://git.bogomips.org/git-svn along with an older patch from Steven:

Steven Walter (1):
git-svn: allow the mergeinfo property to be set

Torsten Bögershausen (1):
t9143: do not fail when unhandled.log.gz is not created

Signature · 1 line
Eric Wong
#2 lore raw
Quoted 8 lines · Eric Wong

It's pushed out to git://git.bogomips.org/git-svn along with an older patch from Steven:

Steven Walter (1):
git-svn: allow the mergeinfo property to be set

Torsten Bögershausen (1):
t9143: do not fail when unhandled.log.gz is not created

Thanks; will pull.