vg_validate support for pvmove LVs (BZ 662669)
PATCH 1/1 vg_validate support for pvmove LVs (BZ 662669)
Hi,
I am attaching patch that revs up vg_validate somewhat, to catch some malformed (internal) pvmoveN LVs. Currently, it checks that the segments in there are either linear or mirrored with 2 legs. Unfortunately, I haven't been able to come up with any further restrictions that wouldn't break the existing tests on some count. It seems that vg_validate is called on VGs where linear segments exist (although I have been unable to capture them at vg_commit time), and they are interspersed with mirrored segments in the same LV. I have already spent a lot of time on this, so if someone wants to come up with a stricter check, please feel free to do so.
Anyway, the attached patch does catch the bug triggered by kabi's test attached to BZ 654447. For the other bug (dangling reference) I will submit a separate BZ and a separate patch, hopefully tomorrow.
Yours,
Petr
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vg_validate-pvmove.diff
Type: text/x-diff
Size: 1254 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20101213/096bfb2b/attachment.bin>
PATCH 1/1 vg_validate support for pvmove LVs (BZ 662669)
Dne 13.12.2010 22:24, Petr Rockai napsal(a):
Quoted 20 lines
Hi,
I am attaching patch that revs up
vg_validatesomewhat, to catch some malformed (internal) pvmoveN LVs. Currently, it checks that the segments in there are either linear or mirrored with 2 legs. Unfortunately, I haven't been able to come up with any further restrictions that wouldn't break the existing tests on some count. It seems thatvg_validateis called on VGs where linear segments exist (although I have been unable to capture them atvg_committime), and they are interspersed with mirrored segments in the same LV. I have already spent a lot of time on this, so if someone wants to come up with a stricter check, please feel free to do so.Anyway, the attached patch does catch the bug triggered by kabi's test attached to BZ 654447. For the other bug (dangling reference) I will submit a separate BZ and a separate patch, hopefully tomorrow.
Yours,
Review
Quoted 3 lines
(quoted diff) +3
-0+ dm_list_iterate_items(lvl, &vg->lvs) { + if (!(lvl->lv->status & PVMOVE)) + continue;
Optionally - it could be put as call of local function into the same dm_list_iterate_items() few lines above ?
i.e.
if ((lvl->lv->status & PVMOVE) && !_validate_pvmove(lvl->lv))
r = 0;
Quoted 5 lines
(quoted diff) +5
-0+ dm_list_iterate_items(seg, &lvl->lv->segments) { + if (seg_is_mirrored(seg)) { + if (seg->area_count != 2) { + log_error(INTERNAL_ERROR + "Segment %d in %s is not 2-way.",
Review
Quoted 10 lines
(quoted diff) +10
-0+ loop_counter1, lvl->lv->name); + r = 0; + } + } else if (seg->area_count != 1) { + log_error(INTERNAL_ERROR + "Segment %d in %s has wrong number of areas: %d.", + loop_counter1, lvl->lv->name, seg->area_count); + r = 0; + } + }
and move this into static _validate_pvmove().
Zdenek
PATCH 1/1 vg_validate support for pvmove LVs (BZ 662669)
In reply to Petr RockaiReview
Quoted 7 lines · Peter Rockai
(quoted diff) +6
-0+ log_error(INTERNAL_ERROR + "Segment %d in %s is not 2-way.", + loop_counter1, lvl->lv->name); + log_error(INTERNAL_ERROR + "Segment %d in %s has wrong number of areas: %d.", + loop_counter1, lvl->lv->name, seg->area_count);
I was going to say 'add pvmove' to the messages, but the LV name is already going to tell you that.
Ack.
Alasdair