Skip to contentSkip to conversation

sctp: fix the return value of getting the sctp partial delivery point

PATCH Applied Wei Yongjun 3 participants 3 messages Dec 15, 2010 – Dec 16, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sctp: fix the return value of getting the sctp partial delivery point

Get the sctp partial delivery point using SCTP_PARTIAL_DELIVERY_POINT socket option should return 0 if success, not -ENOTSUPP.

---
 net/sctp/socket.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
net/sctp/socket.c +1 -1
index 1bc5203..8628e8e 100644
@@ -5050,7 +5050,7 @@ static int sctp_getsockopt_partial_delivery_point(struct sock *sk, int len,
 	if (copy_to_user(optval, &val, len))
 		return -EFAULT;
 
-	return -ENOTSUPP;
+	return 0;
 }
 
 /*
Signature · 1 line
1.6.5.2
#1 lore raw
Quoted 3 lines · Wei Yongjun

Get the sctp partial delivery point using SCTP_PARTIAL_DELIVERY_POINT socket option should return 0 if success, not -ENOTSUPP.

Ack.

-vlad

Quoted 18 lines
---
 net/sctp/socket.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
net/sctp/socket.c +1 -1
index 1bc5203..8628e8e 100644
@@ -5050,7 +5050,7 @@ static int sctp_getsockopt_partial_delivery_point(struct sock *sk, int len,
 	if (copy_to_user(optval, &val, len))
 		return -EFAULT;
 
-	return -ENOTSUPP;
+	return 0;
 }
 
 /*
maintainer Applied
#2 lore raw

From: Vladislav Yasevich <[email protected]>
Date: Wed, 15 Dec 2010 10:53:14 -0500

Quoted 10 lines · Wei Yongjun
Quoted 3 lines

Get the sctp partial delivery point using SCTP_PARTIAL_DELIVERY_POINT socket option should return 0 if success, not -ENOTSUPP.

Ack.

-vlad

Quoted 1 line

Applied, thanks everyone.

Vlad, please use properly formed full "Acked-by: ..." in the future otherwise automated tools don't pick it up and it's therefore more likely your ACK gets lost.

Thanks :-)