Skip to contentSkip to conversation

test/list-modems : print Strength as an integer

PATCH Superseded Benoît Monin 2 participants 5 messages Dec 15, 2010 – Dec 17, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 test/list-modems : print Strength as an integer

org.ofono.NetworkRegistration property Strength is an integer, so print it as such.
---
test/list-modems     3 ++-

 1 files changed, 2 insertions(+), 1 deletions(-)
test/list-modems +2 -1
index 557efd5..8c075ac 100755
@@ -51,7 +51,8 @@ for path, properties in modems:
 elif key in ["MobileNetworkCodeLength",
 "VoicemailMessageCount",
 "MicrophoneVolume",
- "SpeakerVolume"]:
+ "SpeakerVolume",
+ "Strength"]:
 val = int(properties[key])
 elif key in ["MainMenu"]:
 val = ", ".join([ text + " (" + str(int(icon)) +
Signature · 1 line
1.7.0.3
#1 lore raw

Hi Benoit,

Quoted 6 lines · Benoît Monin

org.ofono.NetworkRegistration property Strength is an integer, so print it as such.
---
test/list-modems 3 ++-

 1 files changed, 2 insertions(+), 1 deletions(-)

Patch looks fine, however it does not apply:

Applying: test/list-modems : print Strength as an integer
error: patch failed: test/list-modems:51
error: test/list-modems: patch does not apply
Patch failed at 0001 test/list-modems : print Strength as an integer

Can you make sure to configure your MTA agent correctly?

Regards,
-Denis

#2 lore raw

Hi Denis,

Le vendredi 17 décembre 2010 01:56:48 Denis Kenzior, vous avez écrit :
[snip]

Quoted 2 lines

Can you make sure to configure your MTA agent correctly?

Duh, my dog ate my patch, again.
Sorry about that, resending now.

--
Cheers,
Benoît.

#3 lore raw

PATCH RESEND 1/1 test/list-modems : print Strength as an integer

In reply to Denis Kenzior

org.ofono.NetworkRegistration property Strength is an integer, so print it as such.

---
 test/list-modems |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
test/list-modems +2 -1
index 557efd5..8c075ac 100755
@@ -51,7 +51,8 @@ for path, properties in modems:
 			elif key in ["MobileNetworkCodeLength",
 						"VoicemailMessageCount",
 						"MicrophoneVolume",
-						"SpeakerVolume"]:
+						"SpeakerVolume",
+						"Strength"]:
 				val = int(properties[key])
 			elif key in ["MainMenu"]:
 				val = ", ".join([ text + " (" + str(int(icon)) +
Signature · 1 line
1.7.1
#4 lore raw

Hi Benoît,

Quoted 6 lines · Benoît Monin

org.ofono.NetworkRegistration property Strength is an integer, so print it as such.

---
 test/list-modems |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Patch has been applied, thanks.

Regards,
-Denis