Kernel build ignores missing mkimage on building uImage

Hi,

on building an uImage, I get:

$ make uImage
  CHK     include/linux/version.h
  CHK     include/generated/utsrelease.h
make[1]: `include/generated/mach-types.h' is up to date.
  CALL    scripts/checksyscalls.sh
  CHK     include/generated/compile.h
  Kernel: arch/arm/boot/Image is ready
  SHIPPED arch/arm/boot/compressed/lib1funcs.S
  AS      arch/arm/boot/compressed/lib1funcs.o
  LD      arch/arm/boot/compressed/vmlinux
  OBJCOPY arch/arm/boot/zImage
  Kernel: arch/arm/boot/zImage is ready
  UIMAGE  arch/arm/boot/uImage
"mkimage" command not found - U-Boot images will not be built
  Image arch/arm/boot/uImage is ready
$

I.e. it says: "uImage is ready" even though the uImage file doesn't exist because mkimage is missing.

(I'm working with Linux' current mainline GIT and also see that the problem is also present in the mmarek repo on git.kernel.org.)

I propose the attached patch.

Thanks for considering.

bye,
Roland

scripts/mkuboot.sh +1 -1

index 2e3d3cd..446739c 100755
@@ -11,7 +11,7 @@ if [ -z "${MKIMAGE}" ]; then
 	if [ -z "${MKIMAGE}" ]; then
 		# Doesn't exist
 		echo '"mkimage" command not found - U-Boot images will not be built' >&2
-		exit 0;
+		exit 1;
 	fi
 fi
 

Quoted 6 lines

I.e. it says: "uImage is ready" even though the uImage file doesn't exist because mkimage is missing.

(I'm working with Linux' current mainline GIT and also see that the problem is also present in the mmarek repo on git.kernel.org.)

Quoted 3 lines

I propose the attached patch.

Thanks for considering.

The patch makes sense and afaics none of the architectures relies on this behaviour (either they can't work without mkimage, or a uimage-style target has to be requested by the user). Can I assume "Signed-off-by: Roland Stigge <[email protected]>" on this patch.