Skip to contentSkip to conversation

net/e1000e : Fix to use dev_kfree_skb_any() instead of dev_kfree_skb() in _jumbo_rx_irq

PATCH In review Prasanna Panchamukhi 2 participants 2 messages Dec 17, 2010 – Dec 18, 2010

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Prasanna Panchamukhi

author
#0 lore raw

PATCH 1/1 net/e1000e : Fix to use dev_kfree_skb_any() instead of dev_kfree_skb() in _jumbo_rx_irq

Several "Warning: kfree_skb on hard IRQ" messages have been observed from the net/e1000e driver, e1000_clean_jumbo_rx_irq() routine calling dev_kfree_skb(). This patch fixes the above warning messages by calling dev_kfree_skb_any() instead of dev_kfree_skb().

Signed-off-by Prasanna S. Panchamukhi<[email protected]>
---
  drivers/net/e1000e/netdev.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/e1000e/netdev.c +2 -2
index c4ca162..1068abc 100644
@@ -1320,7 +1320,7 @@ static bool e1000_clean_jumbo_rx_irq(struct e1000_adapter *adapter,
  				/* an error means any chain goes out the window
  				 * too */
  				if (rx_ring->rx_skb_top)
-					dev_kfree_skb(rx_ring->rx_skb_top);
+					dev_kfree_skb_any(rx_ring->rx_skb_top);
  				rx_ring->rx_skb_top = NULL;
  				goto next_desc;
  		}

@@ -1393,7 +1393,7 @@ static bool e1000_clean_jumbo_rx_irq(struct e1000_adapter *adapter,
  		/* eth type trans needs skb->data to point to something */
  		if (!pskb_may_pull(skb, ETH_HLEN)) {
  			e_err("pskb_may_pull failed.\n");
-			dev_kfree_skb(skb);
+			dev_kfree_skb_any(skb);
  			goto next_desc;
  		}
Signature · 15 lines
1.7.0.4



------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d
_______________________________________________
E1000-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel&#174; Ethernet, visit http://communities.intel.com/community/wired
#1 lore raw
Quoted 11 lines · Prasanna Panchamukhi

Several "Warning: kfree_skb on hard IRQ" messages have been observed from the net/e1000e driver, e1000_clean_jumbo_rx_irq() routine calling dev_kfree_skb(). This patch fixes the above warning messages by calling dev_kfree_skb_any() instead of dev_kfree_skb().

Signed-off-by Prasanna S. Panchamukhi<[email protected]>

---
 drivers/net/e1000e/netdev.c |    4 ++--

 1 files changed, 2 insertions(+), 2 deletions(-)

Thanks, I have added it to my tree for review and testing.

Signature · 14 lines
Cheers,
Jeff

------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d
_______________________________________________
E1000-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel&#174; Ethernet, visit http://communities.intel.com/community/wired