MX5: Add initial support for MX53 processor

This patch add I2C support for Freescale MX53 processor

Signed-off-by Jason Liu<[email protected]>

---
Changes for v2:
-address the comments of Heiko, add #if defined(CONFIG_MX31)
to avoid break MX31 build. Move CONFIG_HARD_I2C to the top of the file and fix the error message from:
#error "define CONFIG_SYS_I2C_PORT to use the I2C driver"
to #error "define CONFIG_SYS_I2C_MXxx_PORTx to use the I2C driver"

---
  drivers/i2c/mxc_i2c.c |   19 +++++++++++++++++--
  1 files changed, 17 insertions(+), 2 deletions(-)

drivers/i2c/mxc_i2c.c +0 -0

old mode 100644
new mode 100755
index 8e10fbb..95d27ae

drivers/i2c/mxc_i2c.c +10 -1

  #include<asm/arch/mx31.h>
  #include<asm/arch/mx31-regs.h>
+#endif
+
+#if defined(CONFIG_MX53)
+#include<asm/arch/clock.h>
+#endif
 
  #define IADR	0x00
  #define IFDR	0x04

@@ -56,8 +62,12 @@
  #elif defined (CONFIG_SYS_I2C_MX31_PORT3)
  #define I2C_BASE	0x43f84000
  #define I2C_CLK_OFFSET	30
+#elif defined(CONFIG_SYS_I2C_MX53_PORT1)
+#define I2C_BASE        I2C1_BASE_ADDR
+#elif defined(CONFIG_SYS_I2C_MX53_PORT2)
+#define I2C_BASE        I2C2_BASE_ADDR
  #else
-#error "define CONFIG_SYS_I2C_MX31_PORTx to use the mx31 I2C driver"
+#error "define CONFIG_SYS_I2C_MXxx_PORTx to use the I2C driver"
  #endif
 
  #ifdef DEBUG

Le 22/12/2010 14:23, Jason Liu a ?crit :

Quoted 23 lines

This patch add I2C support for Freescale MX53 processor

Signed-off-by Jason Liu<[email protected]>

---
Changes for v2:
-address the comments of Heiko, add #if defined(CONFIG_MX31) ? to avoid break MX31 build. Move CONFIG_HARD_I2C to the top ? of the file and fix the error message from:
? ? ? ?#error "define CONFIG_SYS_I2C_PORT to use the I2C driver" ? to ? ? ?#error "define CONFIG_SYS_I2C_MXxx_PORTx to use the I2C driver"
---
? drivers/i2c/mxc_i2c.c | ? 19 +++++++++++++++++--
? 1 files changed, 17 insertions(+), 2 deletions(-)

drivers/i2c/mxc_i2c.c +0 -0

old mode 100644
new mode 100755
index 8e10fbb..95d27ae
@@ -26,8 +26,14 @@
 

drivers/i2c/mxc_i2c.c line 29

Quoted 3 lines

drivers/i2c/mxc_i2c.c +1 -0

 ? #if defined(CONFIG_HARD_I2C)
 
+#ifdef CONFIG_MX31

Can you make this an #if defined() like all others you are adding here?

Quoted 26 lines

? #include<asm/arch/mx31.h>
? #include<asm/arch/mx31-regs.h>

drivers/i2c/mxc_i2c.c +5 -0

+#endif
+
+#if defined(CONFIG_MX53)
+#include<asm/arch/clock.h>
+#endif

? #define IADR ? ? ? ?0x00
? #define IFDR ? ? ? ?0x04

drivers/i2c/mxc_i2c.c +0 -0

@@ -56,8 +62,12 @@
 ? #elif defined (CONFIG_SYS_I2C_MX31_PORT3)

? #define I2C_BASE ? ?0x43f84000
? #define I2C_CLK_OFFSET ? ? ?30

drivers/i2c/mxc_i2c.c +4 -0

+#elif defined(CONFIG_SYS_I2C_MX53_PORT1)
+#define I2C_BASE ? ? ? ?I2C1_BASE_ADDR
+#elif defined(CONFIG_SYS_I2C_MX53_PORT2)
+#define I2C_BASE ? ? ? ?I2C2_BASE_ADDR

? #else

drivers/i2c/mxc_i2c.c +1 -1

-#error "define CONFIG_SYS_I2C_MX31_PORTx to use the mx31 I2C driver"
+#error "define CONFIG_SYS_I2C_MXxx_PORTx to use the I2C driver"

? #endif

? #ifdef DEBUG

drivers/i2c/mxc_i2c.c static u16 div[] = { 30, 32, 36, 42, 48, 52, 60, 72, 80, 88, 104, 128, 144, · line 88

Quoted 8 lines

drivers/i2c/mxc_i2c.c +2 -1

@@ -72,11 +82,16 @@ static u16 div[] = { 30, 32, 36, 42, 48, 52, 60, 72, 80, 88, 104, 128, 144,
 
 ? void i2c_init(int speed, int unused)
 ? {
- ? ? int freq = mx31_get_ipg_clk();
+ ? ? int freq;
 ? ? ? int i;
 
+#ifdef CONFIG_MX31

Ditto, for the sake of homogeneity.

Quoted 9 lines

drivers/i2c/mxc_i2c.c +1 -0

+ ? ? freq = mx31_get_ipg_clk();

? ? ? /* start the required I2C clock */
? ? ? __REG(CCM_CGR0) = __REG(CCM_CGR0) | (3<< ?I2C_CLK_OFFSET);

drivers/i2c/mxc_i2c.c +3 -0

+#else
+ ? ? freq = mxc_get_clock(MXC_IPG_PERCLK);
+#endif

? ? ? for (i = 0; i< ?0x1f; i++)
? ? ? ? ? ? ? if (freq / div[i]<= speed)

Amicalement,
--
Albert.
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Add initial support for MX53EVK board support.
FEC, SD/MMC, UART, I2C, have been support.

Signed-off-by Jason Liu <[email protected]>

---
Changes for v2:

(quoted diff) +0 -4

-Address the comments from Stefano, Albert and Wolfgang,
        -remove the ivt.S file and use imximage.cfg instead,
        -remove the ivt link to u-boot
-Address the comments from Stefano,
        -Correct the copyright issue,
        -Use mxc_get_gpio() and mxc_set_gpio() accessors.
        -Get rid of system_rev,
        -use i2c enumeration value (0,1,..N) instead of BASE address,
        -use fsl_pmic i2c interface,
        -Add comments for why manage the pmic in a different way for TO2
        -Remove the comments from configs/mx53evk.h,
         - /*
         -  * Disabled for now due to build problems under Debian and a significant
         -  * increase in the final file size: 144260 vs. 109536 Bytes.
         -  */
-Address the comments from Wolfgang,
        -Move CONFIG_SYS_TEXT_BASE  to board config file,
        -Remove the comments from configs/mx53evk.h
         - /* size in bytes reserved for initial data */
         #define BOARD_LATE_INIT
        -Change the comments,  * Hardware drivers to * UART drivers
---
 
 
 MAINTAINERS                       |    3 +
 board/freescale/mx53evk/Makefile  |   48 +++++
 board/freescale/mx53evk/mx53evk.c |  393 +++++++++++++++++++++++++++++++++++++
 boards.cfg                        |    1 +
 include/configs/mx53evk.h         |  216 ++++++++++++++++++++
 5 files changed, 661 insertions(+), 0 deletions(-)

MAINTAINERS +0 -0

index 0590ad9..c87ca56 100644

Quoted 44 lines

Add initial support for MX53EVK board support.
FEC, SD/MMC, UART, I2C, have been support.

Signed-off-by Jason Liu <[email protected]>

---
Changes for v2:
-Address the comments from Stefano, Albert and Wolfgang,
? ? ? ? -remove the ivt.S file and use imximage.cfg instead,
? ? ? ? -remove the ivt link to u-boot
-Address the comments from Stefano,
? ? ? ? -Correct the copyright issue,
? ? ? ? -Use mxc_get_gpio() and mxc_set_gpio() accessors.
? ? ? ? -Get rid of system_rev,
? ? ? ? -use i2c enumeration value (0,1,..N) instead of BASE address, ? ? ? ? -use fsl_pmic i2c interface,
? ? ? ? -Add comments for why manage the pmic in a different way for TO2 ? ? ? ? -Remove the comments from configs/mx53evk.h,
? ? ? ? ?- /*
? ? ? ? ?- ?* Disabled for now due to build problems under Debian and a significant ? ? ? ? ?- ?* increase in the final file size: 144260 vs. 109536 Bytes. ? ? ? ? ?- ?*/
-Address the comments from Wolfgang,
? ? ? ? -Move CONFIG_SYS_TEXT_BASE ?to board config file,
? ? ? ? -Remove the comments from configs/mx53evk.h
? ? ? ? ?- /* size in bytes reserved for initial data */
? ? ? ? ?#define BOARD_LATE_INIT
? ? ? ? -Change the comments, ?* Hardware drivers to * UART drivers
---

?MAINTAINERS ? ? ? ? ? ? ? ? ? ? ? | ? ?3 +
?board/freescale/mx53evk/Makefile ?| ? 48 +++++
?board/freescale/mx53evk/mx53evk.c | ?393 +++++++++++++++++++++++++++++++++++++
?boards.cfg ? ? ? ? ? ? ? ? ? ? ? ?| ? ?1 +
?include/configs/mx53evk.h ? ? ? ? | ?216 ++++++++++++++++++++

?5 files changed, 661 insertions(+), 0 deletions(-)

MAINTAINERS +0 -0

index 0590ad9..c87ca56 100644
@@ -1085,6 +1085,9 @@ Peter Meerwald <[email protected]>
 

MAINTAINERS Peter Meerwald <[email protected]>

Quoted 5 lines

? ? ? bct-brettl2 ? ? BF536

MAINTAINERS +3 -0

+Jason Liu <[email protected]>
+
+ ? ? MX53evk ? ? ? ? i.MX53

Why do you add your name at the end of the Blackfin list and not inside the ARM list ? Please maintain the list sorted.

MAINTAINERS

Quoted 8 lines

MAINTAINERS +7 -0

+void power_init(void)
+{
+ ? ? unsigned int val;
+
+ ? ? /* Set VDDA to 1.25V */
+ ? ? val = pmic_reg_read(REG_SW_2);
+ ? ? val = (val & (~0x1F)) | 0x1A;

I have already commented this. Please drop all fix constants and use already provided #define or add new ones if needed.

Quoted 5 lines

+ ? ? if (is_soc_rev(CHIP_REV_2_0) == 0) {
+ ? ? ? ? ? ? /* Set VCC to 1.3V for TO2 */
+ ? ? ? ? ? ? val = pmic_reg_read(REG_SW_1);
+ ? ? ? ? ? ? val = (val & (~0x1F)) | 0x1C;

Ditto.

MAINTAINERS

Quoted 10 lines

MAINTAINERS +7 -0

+int board_init(void)
+{
+ ? ? gd->bd->bi_arch_number = MACH_TYPE_MX53_EVK;
+ ? ? /* address of boot parameters */
+ ? ? gd->bd->bi_boot_params = PHYS_SDRAM_1 + 0x100;
+
+ ? ? setup_iomux_uart();

You sent a patch for mx51evk moving this call in board_early_init_f. Do we need the same for mx53evk ?

MAINTAINERS

Quoted 5 lines

MAINTAINERS +4 -0

+#ifdef BOARD_LATE_INIT
+int board_late_init(void)
+{
+#ifdef CONFIG_I2C_MXC

Is there a possibility to have a working board if CONFIG_I2C_MXC and BOARD_LATE_INIT are not set ? If not, it should be better to check if they are set on the beginning of this file and reporting a compile error if they are not set, and removing the #ifdef in this function.

Best regards,
Stefano Babic

--
=====================================================================
DENX Software Engineering GmbH, ? ? MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 ?Email: office at denx.de
=====================================================================
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Quoted 6 lines

board/freescale/mx53evk/mx53evk.c line 130

Quoted 3 lines

board/freescale/mx53evk/mx53evk.c new file +3 -0

+     /* Set VDDA to 1.25V */
+     val = pmic_reg_read(REG_SW_2);
+     val = (val & (~0x1F)) | 0x1A;

I have already commented this. Please drop all fix constants and use already provided #define or add new ones if needed.

Do you think that both 0x1F and 0x1A should be used with #define?

Do you think that both 0x1F and 0x1C should be used with #define?

Quoted 6 lines

Add initial support for Freescale MX53 processor,

- Add the iomux support and the pin definition,
- Add the regs definition, clean up some unused def from mx51,
- Add the low level init support, make use the freq input of setup_pll macro

Quoted 7 lines

---
Changes for v2:
-address some comments of Stefano Babic, remove the is_soc_type ?and use #ifdef,
-address the comments of stefano, remove CPU_TYPE def, remove something ?like /*0x760*/ comments in mx5x_pins.h.
-fix the build break for vision2 board

A general remark. You posted two different patchset now to support the MX53 processor. As the patches are related, please combine all patches in a single patchset to avoid that only a few of them go to be applied and to simplify review.

Best regards,
Stefano Babic

--
=====================================================================
DENX Software Engineering GmbH, ? ? MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 ?Email: office at denx.de
=====================================================================
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Quoted 4 lines

A general remark. You posted two different patchset now to support the MX53 processor. As the patches are related, please combine all patches in a single patchset to avoid that only a few of them go to be applied and to simplify review.

The patch for support mx53 processor is tracked by version. Sorry, I don't catch your mean. Thanks in advance for telling me clear on that if something wrong.

Quoted 8 lines

Quoted 5 lines

A general remark. You posted two different patchset now to support the MX53 processor. As the patches are related, please combine all patches in a single patchset to avoid that only a few of them go to be applied and to simplify review.

The patch for support mx53 processor is tracked by version. Sorry, I don't catch your mean. Thanks in advance for telling me clear on that if something wrong.

Patches for mx53evk are in one patchset, but they depends on patches you sent in another patchset (for pmic, gpio,). All patches that belong to the same patchset are merged together into the mainline, avoiding conflicts and board breakages. If for example your first patchset is merged, but the second one is waiting for changes, the board cannot be compiled clean and can potentially break other board, if for example it contains a partial modification that is fixed in the second patchset. Increase the version number and put all related patches in the same patchset.

Best regards,
Stefano Babic

--
=====================================================================
DENX Software Engineering GmbH, ? ? MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 ?Email: office at denx.de
=====================================================================

Add initial support for Freescale MX53 processor,

- Add the iomux support and the pin definition,
- Add the regs definition, clean up some unused def from mx51,
- Add the low level init support, make use the freq input of setup_pll macro

Dear Jason Liu,

Quoted 2 lines · In message <[email protected]> you wrote:

Add initial support for Freescale MX53 processor,

Quoted 3 lines

- Add the iomux support and the pin definition,
- Add the regs definition, clean up some unused def from mx51,
- Add the low level init support, make use the freq input of setup_pll macro

...

Quoted 1 line

+ ? ? ldr r0, =\pll

What does '\p' mean ?

Quoted 2 lines

+ ? ? ldr r1, W_DP_OP_\freq

What does '\f' mean?

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, ? ? MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Don't try to outweird me, three-eyes. I get stranger things than you free with my breakfast cereal."
? ? ? ? ? - Zaphod Beeblebrox in ?"Hitchhiker's Guide to the Galaxy"
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot