Skip to contentSkip to conversation

mxc_gpio: add support for MX53 processor

PATCH New Jason Liu 3 participants 13 messages Dec 22, 2010 – Dec 28, 2010

Subsystems (3)
lore
Share & tools
lore

Jason Liu

author
#0 lore raw

PATCH 1/3 mxc_gpio: add support for MX53 processor

This patch add mxc_gpio support for Freescale MX53 processor

---
 drivers/gpio/mxc_gpio.c |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)
drivers/gpio/mxc_gpio.c +7 -2
index 663141f..53a0673 100644
@@ -24,7 +24,7 @@
 #ifdef CONFIG_MX31
 #include <asm/arch/mx31-regs.h>
 #endif
-#ifdef CONFIG_MX51
+#if defined(CONFIG_MX51) || defined(CONFIG_MX53)
 #include <asm/arch/imx-regs.h>
 #endif
 #include <asm/io.h>
@@ -35,9 +35,14 @@ static unsigned long gpio_ports[] = {
 	[0] = GPIO1_BASE_ADDR,
 	[1] = GPIO2_BASE_ADDR,
 	[2] = GPIO3_BASE_ADDR,
-#ifdef CONFIG_MX51
+#if defined(CONFIG_MX51) || defined(CONFIG_MX53)
 	[3] = GPIO4_BASE_ADDR,
 #endif
+#if defined(CONFIG_MX53)
+	[4] = GPIO5_BASE_ADDR,
+	[5] = GPIO6_BASE_ADDR,
+	[6] = GPIO7_BASE_ADDR,
+#endif
 };
 
 int mxc_gpio_direction(unsigned int gpio, enum mxc_gpio_direction direction)
Signature · 1 line
1.7.0.4
author
#1 lore raw

PATCH 2/3 fsl_pmic: add I2C interface support

This patch add I2C interface for fsl_pmic driver support

---
 drivers/misc/fsl_pmic.c |   39 ++++++++++++++++++++++++++++++++++++++-
 1 files changed, 38 insertions(+), 1 deletions(-)
drivers/misc/fsl_pmic.c +38 -1
index 5ee1de1..a54f220 100644
@@ -22,11 +22,47 @@
 
 #include <config.h>
 #include <common.h>
-#include <spi.h>
 #include <asm/errno.h>
 #include <linux/types.h>
 #include <fsl_pmic.h>
 
+#ifdef CONFIG_FSL_PMIC_I2C
+#include <i2c.h>
+static int init_done;
+
+u32 pmic_reg(u32 reg, u32 val, u32 write)
+{
+	unsigned char buf[4] = { 0 };
+	u32 ret_val = 0;
+
+	if (reg > 63 || write > 1) {
+		printf("<reg num> = %d is invalid. Should be less then 63\n",
+			reg);
+		return -1;
+	}
+
+	if (init_done == 0) {
+		i2c_init(CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SLAVE);
+		init_done = 1;
+	}
+
+	if (write) {
+		buf[0] = (val >> 16) & 0xff;
+		buf[1] = (val >> 8) & 0xff;
+		buf[2] = (val) & 0xff;
+		if (i2c_write(CONFIG_SYS_FSL_PMIC_I2C_ADDR, reg, 1, buf, 3))
+			return -1;
+	} else {
+		if (i2c_read(CONFIG_SYS_FSL_PMIC_I2C_ADDR, reg, 1, buf, 3)) {
+			return -1;
+		ret_val = buf[0] << 16 | buf[1] << 8 | buf[2];
+		}
+	}
+
+	return ret_val;
+}
+#else /* SPI interface */
+#include <spi.h>
 static struct spi_slave *slave;
 
 struct spi_slave *pmic_spi_probe(void)
@@ -87,6 +123,7 @@ u32 pmic_reg(u32 reg, u32 val, u32 write)
 	spi_release_bus(slave);
 	return cpu_to_be32(pmic_rx);
 }
+#endif
 
 void pmic_reg_write(u32 reg, u32 value)
 {
Signature · 1 line
1.7.0.4
#2 lore raw

PATCH 2/3 fsl_pmic: add I2C interface support

Quoted 6 lines · Jason Liu

This patch add I2C interface for fsl_pmic driver support

drivers/misc/fsl_pmic.c +4 -0
+#ifdef CONFIG_FSL_PMIC_I2C
+#include <i2c.h>
+static int init_done;
+

drivers/misc/fsl_pmic.c line 42

Quoted 10 lines
drivers/misc/fsl_pmic.c +10 -0
+u32 pmic_reg(u32 reg, u32 val, u32 write)
+{
+	unsigned char buf[4] = { 0 };
+	u32 ret_val = 0;
+
+	if (reg > 63 || write > 1) {
+		printf("<reg num> = %d is invalid. Should be less then 63\n",
+			reg);
+		return -1;
+	}

Probably we can factorize better this function and do not duplicate the pmic_reg function for SPI and I2C.

drivers/misc/fsl_pmic.c line 52

Quoted 10 lines
drivers/misc/fsl_pmic.c +10 -0
+
+	if (init_done == 0) {
+		i2c_init(CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SLAVE);
+		init_done = 1;
+	}
+
+	if (write) {
+		buf[0] = (val >> 16) & 0xff;
+		buf[1] = (val >> 8) & 0xff;
+		buf[2] = (val) & 0xff;

It seems you are converting the endianess. No chance to use an already provided accessor ?

drivers/misc/fsl_pmic.c line 58

Quoted 6 lines
drivers/misc/fsl_pmic.c +6 -0
+		if (i2c_write(CONFIG_SYS_FSL_PMIC_I2C_ADDR, reg, 1, buf, 3))
+			return -1;
+	} else {
+		if (i2c_read(CONFIG_SYS_FSL_PMIC_I2C_ADDR, reg, 1, buf, 3)) {
+			return -1;
+		ret_val = buf[0] << 16 | buf[1] << 8 | buf[2];

Ditto.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: [email protected]
=====================================================================
#3 lore raw

PATCH 2/3 fsl_pmic: add I2C interface support

Hi, Stefano,

2010/12/27 Stefano Babic <[email protected]>:

Quoted 12 lines · Jason Liu
Quoted 11 lines

This patch add I2C interface for fsl_pmic driver support

drivers/misc/fsl_pmic.c +9 -0
+#ifdef CONFIG_FSL_PMIC_I2C
+#include <i2c.h>
+static int init_done;
+
+u32 pmic_reg(u32 reg, u32 val, u32 write)
+{
+ ? ? unsigned char buf[4] = { 0 };
+ ? ? u32 ret_val = 0;
+
Quoted 8 lines
Quoted 5 lines

+ ? ? if (reg > 63 || write > 1) {
+ ? ? ? ? ? ? printf("<reg num> = %d is invalid. Should be less then 63\n",
+ ? ? ? ? ? ? ? ? ? ? reg);
+ ? ? ? ? ? ? return -1;
+ ? ? }

Probably we can factorize better this function and do not duplicate the pmic_reg function for SPI and I2C.

OK, I will write one function to check it.

Quoted 14 lines

Review

Quoted 11 lines
(quoted diff) +10 -0
+
+ ? ? if (init_done == 0) {
+ ? ? ? ? ? ? i2c_init(CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SLAVE);
+ ? ? ? ? ? ? init_done = 1;
+ ? ? }
+
+ ? ? if (write) {
+ ? ? ? ? ? ? buf[0] = (val >> 16) & 0xff;
+ ? ? ? ? ? ? buf[1] = (val >> 8) & 0xff;
+ ? ? ? ? ? ? buf[2] = (val) & 0xff;

It seems you are converting the endianess. No chance to use an already provided accessor ?

Good point. I will do it.

Quoted 9 lines
Quoted 7 lines

+ ? ? ? ? ? ? if (i2c_write(CONFIG_SYS_FSL_PMIC_I2C_ADDR, reg, 1, buf, 3))
+ ? ? ? ? ? ? ? ? ? ? return -1;
+ ? ? } else {
+ ? ? ? ? ? ? if (i2c_read(CONFIG_SYS_FSL_PMIC_I2C_ADDR, reg, 1, buf, 3)) {
+ ? ? ? ? ? ? ? ? ? ? return -1;
+ ? ? ? ? ? ? ret_val = buf[0] << 16 | buf[1] << 8 | buf[2];

Ditto.

OK,

Quoted 15 lines

Best regards,
Stefano Babic

--
=====================================================================
DENX Software Engineering GmbH, ? ? MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 ?Email: office at denx.de
=====================================================================
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#4 lore raw

PATCH 2/3 fsl_pmic: add I2C interface support

In reply to Stefano Babic

Hi, Stefano,

2010/12/27 Stefano Babic <[email protected]>:

Quoted 12 lines · Jason Liu
Quoted 11 lines

This patch add I2C interface for fsl_pmic driver support

drivers/misc/fsl_pmic.c +9 -0
+#ifdef CONFIG_FSL_PMIC_I2C
+#include <i2c.h>
+static int init_done;
+
+u32 pmic_reg(u32 reg, u32 val, u32 write)
+{
+ ? ? unsigned char buf[4] = { 0 };
+ ? ? u32 ret_val = 0;
+
Quoted 8 lines
Quoted 5 lines

+ ? ? if (reg > 63 || write > 1) {
+ ? ? ? ? ? ? printf("<reg num> = %d is invalid. Should be less then 63\n",
+ ? ? ? ? ? ? ? ? ? ? reg);
+ ? ? ? ? ? ? return -1;
+ ? ? }

Probably we can factorize better this function and do not duplicate the pmic_reg function for SPI and I2C.

I want to make sure what I did is what you want. Do you mean that I need write one function like:

int check_param(u32 reg, u32 write)

{
      if (reg > 63 || write > 1) {
? ? ? ? ? ? printf("<reg num> = %d is invalid. Should be less then 63\n",
? ? ? ? ? ? ? ? ? ? reg);
 ? ? ? ? ? ? return -1;
      }

     return 0;
}

and put the function call check_param in pmic_reg function to avoid the code duplication.

If something different with what I though, please correct me. Thanks,

Quoted 38 lines

Review

Quoted 11 lines
(quoted diff) +10 -0
+
+ ? ? if (init_done == 0) {
+ ? ? ? ? ? ? i2c_init(CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SLAVE);
+ ? ? ? ? ? ? init_done = 1;
+ ? ? }
+
+ ? ? if (write) {
+ ? ? ? ? ? ? buf[0] = (val >> 16) & 0xff;
+ ? ? ? ? ? ? buf[1] = (val >> 8) & 0xff;
+ ? ? ? ? ? ? buf[2] = (val) & 0xff;

It seems you are converting the endianess. No chance to use an already provided accessor ?

Quoted 6 lines

+ ? ? ? ? ? ? if (i2c_write(CONFIG_SYS_FSL_PMIC_I2C_ADDR, reg, 1, buf, 3))
+ ? ? ? ? ? ? ? ? ? ? return -1;
+ ? ? } else {
+ ? ? ? ? ? ? if (i2c_read(CONFIG_SYS_FSL_PMIC_I2C_ADDR, reg, 1, buf, 3)) {
+ ? ? ? ? ? ? ? ? ? ? return -1;
+ ? ? ? ? ? ? ret_val = buf[0] << 16 | buf[1] << 8 | buf[2];

Ditto.

Best regards,
Stefano Babic

--
=====================================================================
DENX Software Engineering GmbH, ? ? MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 ?Email: office at denx.de
=====================================================================
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

author
#5 lore raw

PATCH 3/3 imximage: Add MX53 boot image support

In reply to Jason Liu

This patch add the MX53 boot image support

This patch has been tested on Freescale MX53EVK board.

---
 board/freescale/mx53evk/config.mk    |   25 ++++++++
 board/freescale/mx53evk/imximage.cfg |  108 ++++++++++++++++++++++++++++++++++
 tools/imximage.c                     |  101 +++++++++++++++++++++++++++++--
 tools/imximage.h                     |   75 ++++++++++++++++++++---
 4 files changed, 293 insertions(+), 16 deletions(-)
board/freescale/mx53evk/config.mk new file +25 -0
new file mode 100755
index 0000000..0153165
@@ -0,0 +1,25 @@
+#
+# Copyright 2010 Freescale Semiconductor, Inc. All Rights Reserved.
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+IMX_CONFIG = $(SRCTREE)/board/$(BOARDDIR)/imximage.cfg
+ALL += $(obj)u-boot.imx
+
board/freescale/mx53evk/imximage.cfg new file +108 -0

108 lines not on this page · raw message

tools/imximage.c +95 -6

171 lines not on this page · raw message

tools/imximage.h +65 -10

102 lines not on this page · raw message

Signature · 1 line
1.7.0.4
#6 lore raw

PATCH 3/3 imximage: Add MX53 boot image support

Quoted 10 lines · Jason Liu

This patch add the MX53 boot image support

This patch has been tested on Freescale MX53EVK board.

---
 board/freescale/mx53evk/config.mk    |   25 ++++++++
 board/freescale/mx53evk/imximage.cfg |  108 ++++++++++++++++++++++++++++++++++
 tools/imximage.c                     |  101 +++++++++++++++++++++++++++++--
 tools/imximage.h                     |   75 ++++++++++++++++++++---

You mixed two patches with different meaning. You add support for mx53evk board (and patches for config.mk and imximage.cfg must belong to this patch) and you modify imximage to support the MX53 processor, not related to the mx53evk board. Please split this patch into two separate patches.

tools/imximage.c static int imximage_check_image_types(uint8_t type) · line 85

Quoted 10 lines
tools/imximage.c +1 -1
index 39f89c2..884feff 100644
@@ -82,7 +82,7 @@ static int imximage_check_image_types(uint8_t type)
 static int imximage_verify_header(unsigned char *ptr, int image_size,
 			struct mkimage_params *params)
 {
-
+#ifdef CONFIG_MX51

NAK. This is wrong: mkimage is a tool running on host and must be possible to include it in a distro. It must be able (as it now does) to produce the correct image at runtime. For this reason there are no #ifdef in the actual code. If a different behavior is required, this must be added extending the syntax of the imximage.cfg file, for example adding a processor type (or a version number, or whatever is needed).

tools/imximage.c static int imximage_verify_header(unsigned char *ptr, int image_size, · line 107

Quoted 10 lines
tools/imximage.c +2 -1
+#if defined(CONFIG_MX51)
 static void imximage_print_header(const void *ptr)
 {
 	struct imx_header *imx_hdr = (struct imx_header *) ptr;
 	flash_header_t *hdr = &imx_hdr->fhdr;
 	uint32_t size;
 	uint32_t length;
-	dcd_t *dcd = &imx_hdr->dcd_table;
 
+	dcd_t *dcd = &imx_hdr->dcd_table;

I do not see any changes on these lines. Please add only changes where they are required.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================
#7 lore raw

PATCH 3/3 imximage: Add MX53 boot image support

Hi, Stefano,

2010/12/27 Stefano Babic <[email protected]>:

Quoted 12 lines · Jason Liu
Quoted 10 lines

This patch add the MX53 boot image support

This patch has been tested on Freescale MX53EVK board.

---

?board/freescale/mx53evk/config.mk ? ?| ? 25 ++++++++
?board/freescale/mx53evk/imximage.cfg | ?108 ++++++++++++++++++++++++++++++++++
?tools/imximage.c ? ? ? ? ? ? ? ? ? ? | ?101 +++++++++++++++++++++++++++++--
?tools/imximage.h ? ? ? ? ? ? ? ? ? ? | ? 75 ++++++++++++++++++++---
Quoted 5 lines

You mixed two patches with different meaning. You add support for mx53evk board (and patches for config.mk and imximage.cfg must belong to this patch) and you modify imximage to support the MX53 processor, not related to the mx53evk board. Please split this patch into two separate patches.

OK, I will put config.mk and imximage.cfg to mx53evk board support patch.

Quoted 10 lines
Quoted 10 lines
tools/imximage.c +0 -1
index 39f89c2..884feff 100644
@@ -82,7 +82,7 @@ static int imximage_check_image_types(uint8_t type)
 ?static int imximage_verify_header(unsigned char *ptr, int image_size,
 ? ? ? ? ? ? ? ? ? ? ? struct mkimage_params *params)
 ?{
-
Quoted 8 lines

tools/imximage.c static int imximage_check_image_types(uint8_t type) · line 85

Quoted 1 line
tools/imximage.c +1 -0
+#ifdef CONFIG_MX51

NAK. This is wrong: mkimage is a tool running on host and must be possible to include it in a distro. It must be able (as it now does) to produce the correct image at runtime. For this reason there are no #ifdef in the actual code. If a different behavior is required, this must be added extending the syntax of the imximage.cfg file, for example adding a processor type (or a version number, or whatever is needed).

Sorry, I don't notice that. If that, I have to add extending syntax to support mx53 since
mx53 is different with mx51 for ROM boot structure.

I would like to add one process type into the imximage.cfg file, what do you think of that?
Any suggestions? Thanks,

Quoted 10 lines
Quoted 10 lines
tools/imximage.c +1 -0
+#if defined(CONFIG_MX51)
 ?static void imximage_print_header(const void *ptr)
 ?{

? ? ? struct imx_header *imx_hdr = (struct imx_header *) ptr; ? ? ? flash_header_t *hdr = &imx_hdr->fhdr;
? ? ? uint32_t size;
? ? ? uint32_t length;
- ? ? dcd_t *dcd = &imx_hdr->dcd_table;

Quoted 4 lines
Quoted 1 line

+ ? ? dcd_t *dcd = &imx_hdr->dcd_table;

I do not see any changes on these lines. Please add only changes where they are required.

I don't know why this get into the patch. I will take care later.

Quoted 15 lines

Best regards,
Stefano Babic

--
=====================================================================
DENX Software Engineering GmbH, ? ? MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 ?Email: office at denx.de
=====================================================================
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#8 lore raw

PATCH 3/3 imximage: Add MX53 boot image support

Quoted 9 lines · Jason Liu
Quoted 8 lines
Quoted 1 line

+#ifdef CONFIG_MX51

NAK. This is wrong: mkimage is a tool running on host and must be possible to include it in a distro. It must be able (as it now does) to produce the correct image at runtime. For this reason there are no #ifdef in the actual code. If a different behavior is required, this must be added extending the syntax of the imximage.cfg file, for example adding a processor type (or a version number, or whatever is needed).

Quoted 7 lines

Sorry, I don't notice that. If that, I have to add extending syntax to support mx53 since
mx53 is different with mx51 for ROM boot structure.

I would like to add one process type into the imximage.cfg file, what do you think of that?
Any suggestions? Thanks,

You have sure in Freescale a better visibility how to group together this feature. Is the newer header typical for the MX53 or are there other processors using the same structure ? John has already pointed out that the MX28 is very similar, and, after reading the manual, it seems to me it has the same header as the MX53. Can we distinguish with a header version ?

As I can see, the actual header is used at least by the MX35, not only by the MX51. So I would prefer a way to group together processors with the same header structure else to define a processor type.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================
#9 lore raw

PATCH 3/3 imximage: Add MX53 boot image support

Hi, Stefano,

2010/12/28 Stefano Babic <[email protected]>:

Quoted 18 lines · Jason Liu
Quoted 9 lines
Quoted 8 lines
Quoted 1 line

+#ifdef CONFIG_MX51

NAK. This is wrong: mkimage is a tool running on host and must be possible to include it in a distro. It must be able (as it now does) to produce the correct image at runtime. For this reason there are no #ifdef in the actual code. If a different behavior is required, this must be added extending the syntax of the imximage.cfg file, for example adding a processor type (or a version number, or whatever is needed).

Quoted 7 lines

Sorry, I don't notice that. If that, I have to add extending syntax to support mx53 since
mx53 is different with mx51 for ROM boot structure.

I would like to add one process type into the imximage.cfg file, what do you think of that?
Any suggestions? Thanks,

Quoted 6 lines

You have sure in Freescale a better visibility how to group together this feature. Is the newer header typical for the MX53 or are there other processors using the same structure ? John has already pointed out that the MX28 is very similar, and, after reading the manual, it seems to me it has the same header as the MX53. Can we distinguish with a header version ?

In fact, the group should be the followings,

mx25/35/51
mx53
mx23/28,

Here the mx23/28 are much different with mx53 and mx25/35/51. mx23/28 is Sgmatel chips and buy-in by Freescale years before.

Quoted 4 lines

As I can see, the actual header is used at least by the MX35, not only by the MX51. So I would prefer a way to group together processors with the same header structure else to define a processor type.

OK, I get it. You want to use version number to group it. Can we do it:

mx25/mx35/mx51 --version 1 ?
mx53 --version 2?

Quoted 11 lines

Best regards,
Stefano Babic

--
=====================================================================
DENX Software Engineering GmbH, ? ? MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 ?Email: office at denx.de
=====================================================================

#10 lore raw

PATCH 3/3 imximage: Add MX53 boot image support

Quoted 7 lines · Jason Liu
Quoted 6 lines

You have sure in Freescale a better visibility how to group together this feature. Is the newer header typical for the MX53 or are there other processors using the same structure ? John has already pointed out that the MX28 is very similar, and, after reading the manual, it seems to me it has the same header as the MX53. Can we distinguish with a header version ?

Quoted 8 lines

In fact, the group should be the followings,

mx25/35/51
mx53
mx23/28,

Here the mx23/28 are much different with mx53 and mx25/35/51. mx23/28 is Sgmatel chips and buy-in by Freescale years before.

Ok, understood.

Quoted 8 lines
Quoted 3 lines

As I can see, the actual header is used at least by the MX35, not only by the MX51. So I would prefer a way to group together processors with the same header structure else to define a processor type.

OK, I get it. You want to use version number to group it. Can we do it:

mx25/mx35/mx51 --version 1 ?
mx53 --version 2?

Ok, fine. Version 1 should be the default value to be compatible with actual boards. Please document the changes in doc/README.imximage, too.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================
#11 lore raw

PATCH 1/3 mxc_gpio: add support for MX53 processor

In reply to Jason Liu
Quoted 7 lines · Jason Liu

This patch add mxc_gpio support for Freescale MX53 processor

---
 drivers/gpio/mxc_gpio.c |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

Hi Jason,

Please move this patch in the same patchset to add support for mx53evk.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================
#12 lore raw

PATCH 1/3 mxc_gpio: add support for MX53 processor

Hi, Stefano,

2010/12/27 Stefano Babic <[email protected]>:

Quoted 8 lines · Jason Liu
Quoted 7 lines

This patch add mxc_gpio support for Freescale MX53 processor

---
?drivers/gpio/mxc_gpio.c | ? ?9 +++++++--
?1 files changed, 7 insertions(+), 2 deletions(-)

Quoted 4 lines

Hi Jason,

Please move this patch in the same patchset to add support for mx53evk.

OK,

Quoted 15 lines

Best regards,
Stefano Babic

--
=====================================================================
DENX Software Engineering GmbH, ? ? MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 ?Email: office at denx.de
=====================================================================
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot