Skip to contentSkip to conversation

Philips SPC315NC is vertically flipped

PATCH In review Mauro Carvalho Chehab 2 participants 3 messages Jan 3, 2011 Media (V4L/DVB)

lore
Share & tools
lore

Mauro Carvalho Chehab

author
#0 lore raw

PATCH 1/1 Philips SPC315NC is vertically flipped

Signed-off-by Mauro Carvalho Chehab <[email protected]>
lib/libv4lconvert/control/libv4lcontrol.c +2 -0
index f32ef7b..a182efe 100644
@@ -46,6 +46,8 @@ static const struct v4lcontrol_flags_info v4lcontrol_flags[] = {
 	{ 0x0471, 0x0326, 0, NULL, NULL, V4LCONTROL_HFLIPPED | V4LCONTROL_VFLIPPED },
 	/* Philips SPC210NC */
 	{ 0x0471, 0x032d, 0, NULL, NULL, V4LCONTROL_HFLIPPED | V4LCONTROL_VFLIPPED },
+	/* Philips SPC315NC */
+	{ 0x0471, 0x032e, 0, NULL, NULL, V4LCONTROL_VFLIPPED },
 	/* Genius E-M 112 (also want whitebalance by default) */
 	{ 0x093a, 0x2476, 0, NULL, NULL,
 		V4LCONTROL_HFLIPPED|V4LCONTROL_VFLIPPED | V4LCONTROL_WANTS_WB, 1500 },
Signature · 1 line
1.7.3.4
#1 lore raw

Hi,

Quoted 7 lines · Mauro Carvalho Chehab
Signed-off-by Mauro Carvalho Chehab<[email protected]>
lib/libv4lconvert/control/libv4lcontrol.c +0 -0
index f32ef7b..a182efe 100644

lib/libv4lconvert/control/libv4lcontrol.c static const struct v4lcontrol_flags_info v4lcontrol_flags[] = { · line 53

Quoted 8 lines
lib/libv4lconvert/control/libv4lcontrol.c +2 -0
@@ -46,6 +46,8 @@ static const struct v4lcontrol_flags_info v4lcontrol_flags[] = {
  	{ 0x0471, 0x0326, 0, NULL, NULL, V4LCONTROL_HFLIPPED | V4LCONTROL_VFLIPPED },
  	/* Philips SPC210NC */
  	{ 0x0471, 0x032d, 0, NULL, NULL, V4LCONTROL_HFLIPPED | V4LCONTROL_VFLIPPED },
+	/* Philips SPC315NC */
+	{ 0x0471, 0x032e, 0, NULL, NULL, V4LCONTROL_VFLIPPED },
  	/* Genius E-M 112 (also want whitebalance by default) */
  	{ 0x093a, 0x2476, 0, NULL, NULL,
  		V4LCONTROL_HFLIPPED|V4LCONTROL_VFLIPPED | V4LCONTROL_WANTS_WB, 1500 },

Are you sure it is only vertically flipped ? I've have the Philips SPC 200NC (0471:0325) myself and it simply has the sensor upside down (so both h and v flipped).

Did you happen to use skype to test this? Skype is known to decide to mirror the image before showing it in some cases (I don't know when / why skype does this).

Regards,

Hans

author
#2 lore raw

Em 03-01-2011 11:03, Hans de Goede escreveu:

Quoted 5 lines

Hi,

Quoted 2 lines · Mauro Carvalho Chehab
Signed-off-by Mauro Carvalho Chehab<[email protected]>
Quoted 16 lines

lib/libv4lconvert/control/libv4lcontrol.c static const struct v4lcontrol_flags_info v4lcontrol_flags[] = { · line 53

Quoted 13 lines
lib/libv4lconvert/control/libv4lcontrol.c +2 -0
index f32ef7b..a182efe 100644
@@ -46,6 +46,8 @@ static const struct v4lcontrol_flags_info v4lcontrol_flags[] = {
      { 0x0471, 0x0326, 0, NULL, NULL, V4LCONTROL_HFLIPPED | V4LCONTROL_VFLIPPED },
      /* Philips SPC210NC */
      { 0x0471, 0x032d, 0, NULL, NULL, V4LCONTROL_HFLIPPED | V4LCONTROL_VFLIPPED },
+    /* Philips SPC315NC */
+    { 0x0471, 0x032e, 0, NULL, NULL, V4LCONTROL_VFLIPPED },
      /* Genius E-M 112 (also want whitebalance by default) */
      { 0x093a, 0x2476, 0, NULL, NULL,
          V4LCONTROL_HFLIPPED|V4LCONTROL_VFLIPPED | V4LCONTROL_WANTS_WB, 1500 },

Are you sure it is only vertically flipped ? I've have the Philips SPC 200NC (0471:0325) myself and it simply has the sensor upside down (so both h and v flipped).

Yes, I'm sure about that. Only vertical is flipped on this webcam.

Quoted 2 lines

Did you happen to use skype to test this? Skype is known to decide to mirror the image before showing it in some cases (I don't know when / why skype does this).

My previous test were with qv4l2. With skype, plus the above patch, the webcam is also working properly.

Quoted 4 lines

Regards,

Hans