OMAP PM: Expose vc registers in debugfs
Subsystems (3)
PATCH 1/1 OMAP PM: Expose vc registers in debugfs
From: Anand Sawant <[email protected]>
This patch will expose the following voltage controller registers as part of voltage layer debugfs.
1. PRM_VC_BYPASS_VAL
2. PRM_VC_CMD_VAL - for all VDDs
This patch will help in debugging voltage scaling issues.
Tested on Zoom3 & OMAP4430 SDP.
Patch rebased to latest Kevin's PM branch.
--- arch/arm/mach-omap2/voltage.c | 15 +++++++++++++++ 1 files changed, 15 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/voltage.c +15 -0
@@ -336,6 +336,11 @@ static void omap4_voltage_write_reg(u32 val, u16 mod, u8 offset) }/* Voltage debugfs support */ + +/** +* Gets the current vp output voltage (auto-compensated) for the +* voltage domain. +*/ static int vp_volt_debug_get (void *data,u64 *val) {struct omap_vdd_info *vdd = (struct omap_vdd_info *) data;
@@ -359,6 +364,10 @@ static int vp_volt_debug_get(void *data, u64 *val)return 0 ; } +/** +* Gets the current nominal OPP voltage (non auto-compensated) for the +* voltage domain. +*/ static int nom_volt_debug_get (void *data,u64 *val) {struct omap_vdd_info *vdd = (struct omap_vdd_info *) data;
@@ -456,6 +465,7 @@ static void __init vp_init(struct omap_vdd_info *vdd) vdd->write_reg (vp_val, mod, vdd->vp_offs.vlimitto); } +/* Creates debugfs entries for key vp & vc parameters */ static void __init vdd_debugfs_init (struct omap_vdd_info *vdd) {char *name;
@@ -501,6 +511,11 @@ static void __init vdd_debugfs_init(struct omap_vdd_info *vdd) (void )debugfs_create_file ("curr_nominal_volt" ,S_IRUGO , vdd->debug_dir, (void *) vdd, &nom_volt_debug_fops); + + (void )debugfs_create_x8 ("vc_bypass_val" ,S_IRUGO , vdd->debug_dir, + &(vdd->vc_reg.bypass_val_reg)); + (void )debugfs_create_x8 ("vc_cmdval" ,S_IRUGO , vdd->debug_dir, + &(vdd->vc_reg.cmdval_reg)); }/* Voltage scale and accessory APIs */
Signature · 1 line
1.7.0.4
[email protected] had written, on 12/30/2010 06:04 AM, the following:
Quoted 8 lines
From: Anand Sawant <[email protected]>
This patch will expose the following voltage controller registers as part of voltage layer debugfs.
1.PRM_VC_BYPASS_VAL
2.PRM_VC_CMD_VAL- for all VDDsThis patch will help in debugging voltage scaling issues.
How does this patch help in debugging voltage scaling issues?
Quoted 15 lines
Tested on Zoom3 & OMAP4430 SDP.
Patch rebased to latest Kevin's PM branch.
Signed-off-by Anand S Sawant <[email protected]>--- arch/arm/mach-omap2/voltage.c | 15 +++++++++++++++ 1 files changed, 15 insertions(+), 0 deletions(-)arch/arm/mach-omap2/voltage.c +0
-0
arch/arm/mach-omap2/voltage.c static void omap4_voltage_write_reg(u32 val, u16 mod, u8 offset) · line 343
Quoted 8 lines
arch/arm/mach-omap2/voltage.c +5
-0@@ -336,6 +336,11 @@ static void omap4_voltage_write_reg(u32 val, u16 mod, u8 offset) }/* Voltage debugfs support */ + +/** +* Gets the current vp output voltage (auto-compensated) for the +* voltage domain. +*/
please remove this from this patch - has nothing to do with $subject also, please read kernel documentation for function comment header style
arch/arm/mach-omap2/voltage.c static int vp_volt_debug_get(void *data, u64 *val) · line 370
Quoted 11 lines
arch/arm/mach-omap2/voltage.c +4
-0static int vp_volt_debug_get (void *data,u64 *val) {struct omap_vdd_info *vdd = (struct omap_vdd_info *) data;@@ -359,6 +364,10 @@ static int vp_volt_debug_get(void *data, u64 *val)return 0 ; } +/** +* Gets the current nominal OPP voltage (non auto-compensated) for the +* voltage domain. +*/
same here
arch/arm/mach-omap2/voltage.c static void __init vp_init(struct omap_vdd_info *vdd) · line 468
Quoted 8 lines
arch/arm/mach-omap2/voltage.c +1
-0static int nom_volt_debug_get (void *data,u64 *val) {struct omap_vdd_info *vdd = (struct omap_vdd_info *) data;@@ -456,6 +465,7 @@ static void __init vp_init(struct omap_vdd_info *vdd) vdd->write_reg (vp_val, mod, vdd->vp_offs.vlimitto); } +/* Creates debugfs entries for key vp & vc parameters */
and here
arch/arm/mach-omap2/voltage.c static void __init vdd_debugfs_init(struct omap_vdd_info *vdd) · line 518
Quoted 12 lines
arch/arm/mach-omap2/voltage.c +5
-0static void __init vdd_debugfs_init (struct omap_vdd_info *vdd) {char *name;@@ -501,6 +511,11 @@ static void __init vdd_debugfs_init(struct omap_vdd_info *vdd) (void )debugfs_create_file ("curr_nominal_volt" ,S_IRUGO , vdd->debug_dir, (void *) vdd, &nom_volt_debug_fops); + + (void )debugfs_create_x8 ("vc_bypass_val" ,S_IRUGO , vdd->debug_dir, + &(vdd->vc_reg.bypass_val_reg)); + (void )debugfs_create_x8 ("vc_cmdval" ,S_IRUGO , vdd->debug_dir, + &(vdd->vc_reg.cmdval_reg));
why the cast to void?
Quoted 3 lines
arch/arm/mach-omap2/voltage.c +0
-0}/* Voltage scale and accessory APIs */
Signature · 2 lines
Regards, Nishanth Menon