Skip to contentSkip to conversation

declare MODULE_FIRMWARE in libsas

PATCH DuanZhenzhong 4 participants 9 messages Jan 4, 2011 – Jan 5, 2011

Subsystems (2)
SCSI SCSI libsas
lore
Share & tools
lore

DuanZhenzhong

author
#0 lore raw
Signed-off-by Zhenzhong Duan <[email protected]>
---
 sas_scsi_host.c |    1 +
 1 file changed, 1 insertion(+)
drivers/scsi/libsas/sas_scsi_host.c renamed from drivers/scsi/libsas/sas_scsi_host.c.origfw +1 -0
diff -up linux-2.6/drivers/scsi/libsas/sas_scsi_host.c.origfw linux-2.6/drivers/scsi/libsas/sas_scsi_host.c
@@ -1110,6 +1110,7 @@ out:
 	release_firmware(fw);
 	return res;
 }
+MODULE_FIRMWARE("sas_addr");
 EXPORT_SYMBOL_GPL(sas_request_addr);
 
 EXPORT_SYMBOL_GPL(sas_queuecommand);
#2 lore raw
Quoted 7 lines · James Bottomley
Quoted 3 lines · DuanZhenzhong
Signed-off-by Zhenzhong Duan<[email protected]>

---

Description? Since libsas has no firmware, surely some explanation is required.

Indeed. Looks bogus at first glance?

author
#3 lore raw
Quoted 12 lines · Jeff Garzik
Quoted 7 lines · James Bottomley
Quoted 3 lines · DuanZhenzhong
Signed-off-by Zhenzhong Duan<[email protected]>

---

Description? Since libsas has no firmware, surely some explanation is required.

Indeed. Looks bogus at first glance?

I was finding all requested but not exported firmware in scsi driver for generating dump initrd use.
In sas_scsi_host.c, request_firmware is called with "sas_addr", sas_addr neither builtin nor exported. Don't sas_addr a firmware? Please correct me. thanks

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#4 lore raw
Quoted 10 lines · DuanZhenzhong
Quoted 9 lines · Jeff Garzik
Quoted 7 lines · James Bottomley
Quoted 3 lines · DuanZhenzhong
Signed-off-by Zhenzhong Duan<[email protected]>

---

Description? Since libsas has no firmware, surely some explanation is required.

Quoted 8 lines
Quoted 3 lines

Indeed. Looks bogus at first glance?

I was finding all requested but not exported firmware in scsi driver for generating dump initrd use.
In sas_scsi_host.c, request_firmware is called with "sas_addr", sas_addr neither builtin nor exported. Don't sas_addr a firmware? Please correct me. thanks

No, it's not requesting any firmware ... it's a slight misuse of the firmware mechanism that allows a libsas based driver to be given a SAS address if it doesn't have an internal nsvram to store one.

James

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#5 lore raw
Quoted 23 lines · James Bottomley
Quoted 13 lines · DuanZhenzhong
Quoted 11 lines · Jeff Garzik
Quoted 9 lines · James Bottomley
Quoted 4 lines · DuanZhenzhong
Signed-off-by Zhenzhong Duan<[email protected]>

---

Description? Since libsas has no firmware, surely some explanation is required.

Quoted 7 lines
Quoted 4 lines

Indeed. Looks bogus at first glance?

I was finding all requested but not exported firmware in scsi driver for generating dump initrd use.
In sas_scsi_host.c, request_firmware is called with "sas_addr", sas_addr neither builtin nor exported. Don't sas_addr a firmware? Please correct me. thanks

Quoted 8 lines

No, it's not requesting any firmware ... it's a slight misuse of the firmware mechanism that allows a libsas based driver to be given a SAS address if it doesn't have an internal nsvram to store one.

James

I see, thanks

Signature · 2 lines
Regards
zhenzhong
#6 lore raw
In reply to DuanZhenzhong
Quoted 10 lines · DuanZhenzhong
Quoted 9 lines · Jeff Garzik
Quoted 7 lines · James Bottomley
Quoted 3 lines · DuanZhenzhong
Signed-off-by Zhenzhong Duan<[email protected]>

---

Description? Since libsas has no firmware, surely some explanation is required.

Quoted 9 lines
Quoted 3 lines

Indeed. Looks bogus at first glance?

I was finding all requested but not exported firmware in scsi driver for generating dump initrd use.
In sas_scsi_host.c, request_firmware is called with "sas_addr", sas_addr neither builtin nor exported. Don't sas_addr a firmware? Please correct me. thanks

But once you export it, it needs to be found in fireware/ directory... --
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#7 lore raw
Quoted 27 lines · Américo Wang
Quoted 17 lines · DuanZhenzhong
Quoted 4 lines · Jeff Garzik
Quoted 2 lines · James Bottomley

On Tue, 2011-01-04 at 15:43 +0800, DuanZhenzhong wrote:

Quoted 11 lines
Quoted 7 lines
Quoted 4 lines
Signed-off-by Zhenzhong Duan<[email protected]>

---

Description? Since libsas has no firmware, surely some explanation is required.

Indeed. Looks bogus at first glance?

Quoted 7 lines

I was finding all requested but not exported firmware in scsi driver for generating dump initrd use.
In sas_scsi_host.c, request_firmware is called with "sas_addr", sas_addr neither builtin nor exported. Don't sas_addr a firmware? Please correct me. thanks

Quoted 2 lines

But once you export it, it needs to be found in fireware/ directory...

Not exactly, firmware/ dir only have a subset of all needed firmware. Also one can load firmware manually from anywhere

Signature · 2 lines
Regards
zhenzhong
#8 lore raw
Quoted 20 lines · DuanZhenzhong
Quoted 19 lines · Américo Wang
Quoted 17 lines · DuanZhenzhong
Quoted 10 lines · Jeff Garzik
Quoted 6 lines · James Bottomley
Quoted 3 lines · DuanZhenzhong
Signed-off-by Zhenzhong Duan<[email protected]>

---

Description? Since libsas has no firmware, surely some explanation is required.

Indeed. Looks bogus at first glance?

I was finding all requested but not exported firmware in scsi driver for generating dump initrd use.
In sas_scsi_host.c, request_firmware is called with "sas_addr", sas_addr neither builtin nor exported. Don't sas_addr a firmware? Please correct me. thanks

Quoted 4 lines
Quoted 1 line

But once you export it, it needs to be found in fireware/ directory...

Not exactly, firmware/ dir only have a subset of all needed firmware. Also one can load firmware manually from anywhere

Then it should not be exported, otherwise user-space will get confused. We have a script to parse modinfo output to get the firmwares of a module.