Added openvpnserv-specific files to clean target in win/msvc.mak.in
PATCH 5/6 Added openvpnserv-specific files to clean target in win/msvc.mak.in
This patch depends on patch 2/6. Patch 6/6 depends on this patch. Maybe integrating them into one would have made more sense? :)
Signature · 5 lines
Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock
From 3ce5ba5fb8d9a1627e25b01ad6f6d61a29b6084f Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Samuli=20Sepp=C3=A4nen?= <[email protected]>
Date: Mon, 3 Jan 2011 16:22:32 +0200
Subject: [PATCH 5/6] Added openvpnserv-specific files to clean target in win/msvc.mak.in
--- win/msvc.mak.in | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
win/msvc.mak.in +1 -1
@@ -63,7 +63,7 @@ openvpnserv : openvpn $(SERVOBJS) clean : - del /Q $(OBJS) $(EXE) *.idb *.pdb + del /Q $(OBJS) $(SERVOBJS) $(SERVEXE) $(EXE) *.idb *.pdb .c.obj:: $(CPP) @<<
Signature · 1 line
1.6.3.3
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 3 lines · Samuli Seppänen
This patch depends on patch 2/6. Patch 6/6 depends on this patch. Maybe integrating them into one would have made more sense? :)
Patch 5/6 and Patch 6/6 could be merged. Patch 2/6 is doing more changes, but I see the pattern so you might be right that they could all be merged into one patch. However small commits isn't necessarily a bad idea, so I have no complaints about this fragmentation - as long as it is clear they do belong to each other. When applying to the tree, I will probably rearrange the order of these three so they come together.
This patch gets an ACK from me anyway.
kind regards,
David Sommerseth
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAk0kUVsACgkQDC186MBRfroPDgCcCtu0vjtgRwwe2XnysSRHlD7H Q0sAnjfpPDUz3kVoTBh/OFPrXO59WAOk
=f2pw
-----END PGP SIGNATURE-----