SMDK6400: Fix CONFIG_SYS_INIT_SP_ADDR undeclared

PATCH Superseded seedshope 3 participants 17 messages Jan 7, 2011 – Jan 9, 2011 Arm (32-bit)

lore

Share & tools

lore

seedshope

author

2011-01-07 15:53 UTC #0 lore raw

PATCH 1/3 SMDK6400: Fix CONFIG_SYS_INIT_SP_ADDR undeclared

From: seedshope <[email protected]>

CONFIG_SYS_INIT_SP_ADDR point the last PHY of IRAM and substract the global size.

Signed-off-by seedshope <[email protected]>

include/configs/smdk6400.h +5 -0

index 671f2c7..037db4f 100644
@@ -174,6 +174,11 @@
 #define PHYS_SDRAM_1		CONFIG_SYS_SDRAM_BASE	/* SDRAM Bank #1	*/
 #define PHYS_SDRAM_1_SIZE	0x08000000	/* 128 MB in Bank #1	*/
 
+#define CONFIG_SYS_IRAM_BASE        0x0c000000      /* Internal SRAM base address */
+#define CONFIG_SYS_IRAM_SIZE        0x2000          /* 8 KB of internal SRAM memory */
+#define CONFIG_SYS_IRAM_END         (CONFIG_SYS_IRAM_BASE + CONFIG_SYS_IRAM_SIZE)
+#define CONFIG_SYS_INIT_SP_ADDR     (CONFIG_SYS_IRAM_END - GENERATED_GBL_DATA_SIZE)
+
 #define CONFIG_SYS_FLASH_BASE		0x10000000
 #define CONFIG_SYS_MONITOR_BASE	0x00000000

Signature · 1 line

1.7.1

seedshope

author

2011-01-07 15:53 UTC #1 lore raw

PATCH 2/3 SMDK6400:use common arm1176 u-boot.lds of cpu layer

From: seedshope <[email protected]>

Remove u-boot-nand.lds from board/samsung/smdk6400 and use the common u-boot.lds of arm1176 cpu layer. This patch also fix the building errors:

arch/arm/cpu/arm1176/s3c64xx/libs3c64xx.o: In function `mem_ctrl_asm_init':
arch/arm/cpu/arm1176/s3c64xx/cpu_init.S:32: multiple definition of mem_ctrl_asm_init' arch/arm/cpu/arm1176/s3c64xx/cpu_init.S:32: first defined here arch/arm/cpu/arm1176/start.o: In function _rel_dyn_start_ofs':
arch/arm/cpu/arm1176/start.S:379: undefined reference to __rel_dyn_start' arch/arm/cpu/arm1176/start.o: In function _rel_dyn_end_ofs':
arch/arm/cpu/arm1176/start.S:379: undefined reference to __rel_dyn_end' arch/arm/cpu/arm1176/start.o: In function _dynsym_start_ofs':
arch/arm/cpu/arm1176/start.S:379: undefined reference to `__dynsym_start'

Signed-off-by seedshope <[email protected]>

board/samsung/smdk6400/config.mk +0 -1

index 90cbcf2..0443f60 100644
@@ -29,4 +29,3 @@ else
 CONFIG_SYS_TEXT_BASE = 0
 endif
 
-LDSCRIPT := $(SRCTREE)/board/$(BOARDDIR)/u-boot-nand.lds

board/samsung/smdk6400/u-boot-nand.lds deleted +0 ~~-62~~

62 lines not on this page · raw message

Signature · 1 line

1.7.1

Albert ARIBAUD

2011-01-08 06:04 UTC #2 lore raw

PATCH 2/3 SMDK6400:use common arm1176 u-boot.lds of cpu layer

Le 07/01/2011 16:53, seedshope a ?crit :

Quoted 16 lines

From: seedshope<[email protected]>
Remove u-boot-nand.lds from board/samsung/smdk6400 and use the common u-boot.lds of arm1176 cpu layer. This patch also fix the building errors:
arch/arm/cpu/arm1176/s3c64xx/libs3c64xx.o: In function `mem_ctrl_asm_init':
arch/arm/cpu/arm1176/s3c64xx/cpu_init.S:32: multiple definition of mem_ctrl_asm_init' arch/arm/cpu/arm1176/s3c64xx/cpu_init.S:32: first defined here arch/arm/cpu/arm1176/start.o: In function _rel_dyn_start_ofs':
arch/arm/cpu/arm1176/start.S:379: undefined reference to __rel_dyn_start' arch/arm/cpu/arm1176/start.o: In function _rel_dyn_end_ofs':
arch/arm/cpu/arm1176/start.S:379: undefined reference to __rel_dyn_end' arch/arm/cpu/arm1176/start.o: In function _dynsym_start_ofs':
arch/arm/cpu/arm1176/start.S:379: undefined reference to `__dynsym_start'

Quoted 1 line

Signed-off-by seedshope<[email protected]>

In the current u-boot-arm tree, board/samsung/smdk6400/u-boot-nand.lds and arch/arm/cpu/arm1176/u-boot.lds are identical; I am thus ok with the change in itself since the board lds file was useless, but I am not sure the description is valid. Can you double-check this change wrt to the link issue?

Amicalement,

Signature · 1 line

Albert.

seedshope

author

2011-01-08 14:54 UTC #3 lore raw

PATCH 2/3 SMDK6400:use common arm1176 u-boot.lds of cpu layer

Quoted 17 lines · Albert ARIBAUD

Le 07/01/2011 16:53, seedshope a ?crit :
Quoted 16 lines
From: seedshope<[email protected]>
Remove u-boot-nand.lds from board/samsung/smdk6400 and use the common u-boot.lds of arm1176 cpu layer. This patch also fix the building errors:
arch/arm/cpu/arm1176/s3c64xx/libs3c64xx.o: In function `mem_ctrl_asm_init':
arch/arm/cpu/arm1176/s3c64xx/cpu_init.S:32: multiple definition of mem_ctrl_asm_init' arch/arm/cpu/arm1176/s3c64xx/cpu_init.S:32: first defined here arch/arm/cpu/arm1176/start.o: In function _rel_dyn_start_ofs':
arch/arm/cpu/arm1176/start.S:379: undefined reference to __rel_dyn_start' arch/arm/cpu/arm1176/start.o: In function _rel_dyn_end_ofs':
arch/arm/cpu/arm1176/start.S:379: undefined reference to __rel_dyn_end' arch/arm/cpu/arm1176/start.o: In function _dynsym_start_ofs':
arch/arm/cpu/arm1176/start.S:379: undefined reference to `__dynsym_start'

Quoted 6 lines

Quoted 1 line
Signed-off-by seedshope<[email protected]>
In the current u-boot-arm tree, board/samsung/smdk6400/u-boot-nand.lds and arch/arm/cpu/arm1176/u-boot.lds are identical; I am thus ok with the change in itself since the board lds file was useless, but I am not sure the description is valid. Can you double-check this change wrt to the link issue?

I am sure the link issue. But I need to adjust the patch. I should be modify base on
board/samsung/smdk6400/u-boot-nand.lds, Don't delete it.

Quoted 1 line

Amicalement,

seedshope

author

2011-01-07 15:53 UTC #4 lore raw

PATCH 3/3 SMDK6400: Fix build error for smdk6400 nand_spl support

In reply to seedshope

From: seedshope <[email protected]>

Modify u-boot.lds from nand_spl/board/samsung/smdk6400.

start.o: In function `clbss_l':
nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to coloured_LED_init' nand_spl/board/samsung/smdk6400/start.S:358: undefined reference to red_LED_on' start.o: In function `_rel_dyn_start_ofs':
nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to __rel_dyn_start' start.o: In function _rel_dyn_end_ofs':
nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to __rel_dyn_end' start.o: In function _dynsym_start_ofs':
nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__dynsym_start'

Signed-off-by seedshope <[email protected]>

arch/arm/cpu/arm1176/start.S +2 -1

index 237dcfe..bde0357 100644
@@ -353,10 +353,11 @@ clbss_l:str	r2, [r0]		/* clear loop...		    */
 	add	r0, r0, #4
 	cmp	r0, r1
 	bne	clbss_l
-
+#ifndef CONFIG_NAND_SPL
 	bl coloured_LED_init
 	bl red_LED_on
 #endif
+#endif
 
 /*
  * We are done. Do not return, instead branch to second part of board

nand_spl/board/samsung/smdk6400/u-boot.lds +19 -4

index 3ac6aa1..c179db3 100644
@@ -54,8 +54,23 @@ SECTIONS
 	.u_boot_cmd : { *(.u_boot_cmd) }
 	__u_boot_cmd_end = .;
 
-	. = ALIGN(4);
-	__bss_start = .;
-	.bss : { *(.bss) . = ALIGN(4); }
-	_end = .;
+    . = ALIGN(4);
+
+    .rel.dyn : {
+    __rel_dyn_start = .;
+    *(.rel*)
+    __rel_dyn_end = .;
+    }
+
+    .dynsym : {
+    __dynsym_start = .;
+    *(.dynsym)
+    }
+
+    .bss __rel_dyn_start (OVERLAY) : {
+    __bss_start = .;
+    *(.bss)
+    . = ALIGN(4);
+    _end = .;
+    }
 }

Signature · 1 line

1.7.1

Albert ARIBAUD

2011-01-08 06:14 UTC #5 lore raw

PATCH 3/3 SMDK6400: Fix build error for smdk6400 nand_spl support

Hi seedshope,

Le 07/01/2011 16:53, seedshope a ?crit :

Quoted 3 lines

From: seedshope<[email protected]>
Modify u-boot.lds from nand_spl/board/samsung/smdk6400.

You're also modifying start.S. If you mention files in the patch summary, then please mention them all.

Quoted 11 lines

start.o: In function `clbss_l':
nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to coloured_LED_init' nand_spl/board/samsung/smdk6400/start.S:358: undefined reference to red_LED_on' start.o: In function `_rel_dyn_start_ofs':
nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to __rel_dyn_start' start.o: In function _rel_dyn_end_ofs':
nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to __rel_dyn_end' start.o: In function _dynsym_start_ofs':
nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__dynsym_start'
Signed-off-by seedshope<[email protected]>

Please limit the commit message to a simple explanation of the issue fixed, without pasting detailed build messages int it. Here for instance you need only indicate that you're removing references to relocation symbols and calls to LED functions.

Amicalement,

Signature · 1 line

Albert.

seedshope

author

2011-01-08 14:57 UTC #6 lore raw

PATCH 3/3 SMDK6400: Fix build error for smdk6400 nand_spl support

Quoted 8 lines · Albert ARIBAUD

Hi seedshope,
Le 07/01/2011 16:53, seedshope a ?crit :
Quoted 3 lines
From: seedshope<[email protected]>
Modify u-boot.lds from nand_spl/board/samsung/smdk6400.
You're also modifying start.S. If you mention files in the patch summary, then please mention them all.

Quoted 10 lines

Quoted 10 lines
start.o: In function `clbss_l':
nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to coloured_LED_init' nand_spl/board/samsung/smdk6400/start.S:358: undefined reference to red_LED_on' start.o: In function `_rel_dyn_start_ofs':
nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to __rel_dyn_start' start.o: In function _rel_dyn_end_ofs':
nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to __rel_dyn_end' start.o: In function _dynsym_start_ofs':
nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__dynsym_start'

Quoted 5 lines

Quoted 1 line
Signed-off-by seedshope<[email protected]>
Please limit the commit message to a simple explanation of the issue fixed, without pasting detailed build messages int it. Here for instance you need only indicate that you're removing references to relocation symbols and calls to LED functions.

Thanks,
seedshope

Quoted 1 line

Amicalement,

Minkyu Kang

2011-01-08 15:15 UTC #7 lore raw

PATCH 3/3 SMDK6400: Fix build error for smdk6400 nand_spl support

In reply to seedshope

Dear seedshope,

Quoted 24 lines · seedshope

From: seedshope <[email protected]>
Modify u-boot.lds from nand_spl/board/samsung/smdk6400.
start.o: In function `clbss_l':
nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to coloured_LED_init' nand_spl/board/samsung/smdk6400/start.S:358: undefined reference to red_LED_on' start.o: In function `_rel_dyn_start_ofs':
nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to __rel_dyn_start' start.o: In function _rel_dyn_end_ofs':
nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to __rel_dyn_end' start.o: In function _dynsym_start_ofs':
nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__dynsym_start'
Signed-off-by seedshope <[email protected]>
arch/arm/cpu/arm1176/start.S +0 -0
index 237dcfe..bde0357 100644
@@ -353,10 +353,11 @@ clbss_l:str ? ? ? r2, [r0] ? ? ? ? ? ? ? ?/* clear loop... ? ? ? ? ? ? ? ? ? ?*/
? ? ? ?add ? ? r0, r0, #4
? ? ? ?cmp ? ? r0, r1
? ? ? ?bne ? ? clbss_l

arch/arm/cpu/arm1176/start.S clbss_l:str r2, [r0] /* clear loop... */ · line 356

Quoted 2 lines

arch/arm/cpu/arm1176/start.S +1 -1
-
+#ifndef CONFIG_NAND_SPL

CONFIG_PRELOADER is better

Quoted 6 lines

? ? ? ?bl coloured_LED_init
? ? ? ?bl red_LED_on
?#endif
+#endif
?/*

Thanks
Minkyu Kang

Signature · 2 lines

from. prom.
www.promsoft.net

seedshope

author

2011-01-09 01:14 UTC #8 lore raw

PATCH 3/3 SMDK6400: Fix build error for smdk6400 nand_spl support

Quoted 19 lines · Minkyu Kang

Dear seedshope,
Quoted 16 lines · seedshope
From: seedshope<[email protected]>
Modify u-boot.lds from nand_spl/board/samsung/smdk6400.
start.o: In function `clbss_l':
nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to coloured_LED_init' nand_spl/board/samsung/smdk6400/start.S:358: undefined reference to red_LED_on' start.o: In function `_rel_dyn_start_ofs':
nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to __rel_dyn_start' start.o: In function _rel_dyn_end_ofs':
nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to __rel_dyn_end' start.o: In function _dynsym_start_ofs':
nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__dynsym_start'
Signed-off-by seedshope<[email protected]>

Quoted 11 lines

arch/arm/cpu/arm1176/start.S clbss_l:str r2, [r0] /* clear loop... */ · line 356
Quoted 10 lines
arch/arm/cpu/arm1176/start.S +1 -1
index 237dcfe..bde0357 100644
@@ -353,10 +353,11 @@ clbss_l:str       r2, [r0]                /* clear loop...                    */
        add     r0, r0, #4
        cmp     r0, r1
        bne     clbss_l
-
+#ifndef CONFIG_NAND_SPL
CONFIG_PRELOADER is better

No, The nand_spl support can't find the define of coloured_LED_init and red_LED_on.
It is base on the build error:

make smdk6400_config
make
the error information as following:

nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to coloured_LED_init' nand_spl/board/samsung/smdk6400/start.S:358: undefined reference to red_LED_on'

Thanks,

seedshope

Quoted 8 lines

arch/arm/cpu/arm1176/start.S clbss_l:str r2, [r0] /* clear loop... */ · line 362
Quoted 6 lines
arch/arm/cpu/arm1176/start.S +1 -0
        bl coloured_LED_init
        bl red_LED_on
  #endif
+#endif
 
  /*
Thanks
Minkyu Kang

Minkyu Kang

2011-01-09 07:33 UTC #9 lore raw

PATCH 3/3 SMDK6400: Fix build error for smdk6400 nand_spl support

Quoted 45 lines · seedshope

Quoted 26 lines · Minkyu Kang
Dear seedshope,
Quoted 22 lines · On 8 January 2011 00:53, seedshope<[email protected]> ?wrote:
From: seedshope<[email protected]>
Modify u-boot.lds from nand_spl/board/samsung/smdk6400.
start.o: In function `clbss_l':
nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to coloured_LED_init' nand_spl/board/samsung/smdk6400/start.S:358: undefined reference to red_LED_on'
start.o: In function `_rel_dyn_start_ofs':
nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__rel_dyn_start'
start.o: In function `_rel_dyn_end_ofs':
nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__rel_dyn_end'
start.o: In function `_dynsym_start_ofs':
nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__dynsym_start'
Signed-off-by seedshope<[email protected]>
Quoted 13 lines
arch/arm/cpu/arm1176/start.S clbss_l:str r2, [r0] /* clear loop... */ · line 356
Quoted 11 lines
arch/arm/cpu/arm1176/start.S +0 -0
index 237dcfe..bde0357 100644
@@ -353,10 +353,11 @@ clbss_l:str ? ? ? r2, [r0] ? ? ? ? ? ? ? ?/* clear
loop... ? ? ? ? ? ? ? ? ? ?*/
? ? ? ?add ? ? r0, r0, #4
? ? ? ?cmp ? ? r0, r1
? ? ? ?bne ? ? clbss_l
arch/arm/cpu/arm1176/start.S +1 -1
-
+#ifndef CONFIG_NAND_SPL
CONFIG_PRELOADER is better
No, The nand_spl support can't find the define of coloured_LED_init and red_LED_on.
It is base on the build error:

Quoted 9 lines

make smdk6400_config
make
the error information as following:
nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to coloured_LED_init' nand_spl/board/samsung/smdk6400/start.S:358: undefined reference to red_LED_on'

Please add follow define at Makefile.
AFLAGS += -DCONFIG_PRELOADER -DCONFIG_NAND_SPL
CFLAGS += -DCONFIG_PRELOADER -DCONFIG_NAND_SPL

Thanks
Minkyu Kang

Signature · 2 lines

from. prom.
www.promsoft.net

seedshope

author

2011-01-09 12:27 UTC #10 lore raw

PATCH 3/3 SMDK6400: Fix build error for smdk6400 nand_spl support

Quoted 48 lines · Minkyu Kang

Hi
Quoted 45 lines · seedshope
Quoted 24 lines · Minkyu Kang
Dear seedshope,
Quoted 21 lines · seedshope
From: seedshope<[email protected]>
Modify u-boot.lds from nand_spl/board/samsung/smdk6400.
start.o: In function `clbss_l':
nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to coloured_LED_init' nand_spl/board/samsung/smdk6400/start.S:358: undefined reference to red_LED_on'
start.o: In function `_rel_dyn_start_ofs':
nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__rel_dyn_start'
start.o: In function `_rel_dyn_end_ofs':
nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__rel_dyn_end'
start.o: In function `_dynsym_start_ofs':
nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__dynsym_start'
Signed-off-by seedshope<[email protected]>
Quoted 12 lines
arch/arm/cpu/arm1176/start.S clbss_l:str r2, [r0] /* clear loop... */ · line 356
Quoted 11 lines
arch/arm/cpu/arm1176/start.S +0 -0
index 237dcfe..bde0357 100644
@@ -353,10 +353,11 @@ clbss_l:str       r2, [r0]                /* clear
loop... */
        add     r0, r0, #4
        cmp     r0, r1
        bne     clbss_l
arch/arm/cpu/arm1176/start.S +1 -1
-
+#ifndef CONFIG_NAND_SPL
CONFIG_PRELOADER is better
No, The nand_spl support can't find the define of coloured_LED_init and red_LED_on.
It is base on the build error:
make smdk6400_config
make
the error information as following:

Quoted 8 lines

Quoted 5 lines
nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to coloured_LED_init' nand_spl/board/samsung/smdk6400/start.S:358: undefined reference to red_LED_on'
Please add follow define at Makefile.
AFLAGS += -DCONFIG_PRELOADER -DCONFIG_NAND_SPL
CFLAGS += -DCONFIG_PRELOADER -DCONFIG_NAND_SPL

ok, It may be a good method.

But I worried other people will be difficult to see the process of the code running.
So, if add #ifdef CONFIG_NAND_SPL, It is very clear. What do you think about it?

Thanks,
seedshope

Quoted 2 lines

Thanks
Minkyu Kang

Minkyu Kang

2011-01-09 14:12 UTC #11 lore raw

PATCH 3/3 SMDK6400: Fix build error for smdk6400 nand_spl support

Hello,

Quoted 66 lines · seedshope

Quoted 56 lines · Minkyu Kang
Hi
Quoted 52 lines · On 9 January 2011 10:14, seedshope<[email protected]> ?wrote:
Quoted 26 lines · Minkyu Kang
Dear seedshope,
Quoted 22 lines · On 8 January 2011 00:53, seedshope<[email protected]> ? ?wrote:
From: seedshope<[email protected]>
Modify u-boot.lds from nand_spl/board/samsung/smdk6400.
start.o: In function `clbss_l':
nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to coloured_LED_init' nand_spl/board/samsung/smdk6400/start.S:358: undefined reference to red_LED_on'
start.o: In function `_rel_dyn_start_ofs':
nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__rel_dyn_start'
start.o: In function `_rel_dyn_end_ofs':
nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__rel_dyn_end'
start.o: In function `_dynsym_start_ofs':
nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__dynsym_start'
Signed-off-by seedshope<[email protected]>
Quoted 15 lines
arch/arm/cpu/arm1176/start.S clbss_l:str r2, [r0] /* clear loop... */ · line 356
Quoted 13 lines
arch/arm/cpu/arm1176/start.S +0 -0
index 237dcfe..bde0357 100644
@@ -353,10 +353,11 @@ clbss_l:str ? ? ? r2, [r0] ? ? ? ? ? ? ? ?/*
clear
loop... ? ? ? ? ? ? ? ? ? ?*/
? ? ? ?add ? ? r0, r0, #4
? ? ? ?cmp ? ? r0, r1
? ? ? ?bne ? ? clbss_l
arch/arm/cpu/arm1176/start.S +1 -1
-
+#ifndef CONFIG_NAND_SPL
CONFIG_PRELOADER is better
No, The nand_spl support can't find the define of coloured_LED_init and red_LED_on.
It is base on the build error:
make smdk6400_config
make
the error information as following:
Quoted 8 lines
Quoted 5 lines
nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to coloured_LED_init' nand_spl/board/samsung/smdk6400/start.S:358: undefined reference to red_LED_on'
Please add follow define at Makefile.
AFLAGS ?+= -DCONFIG_PRELOADER -DCONFIG_NAND_SPL
CFLAGS ?+= -DCONFIG_PRELOADER -DCONFIG_NAND_SPL

Quoted 7 lines

ok, It may be a good method.
But I worried other people will be difficult ?to see the process of the code running.
So, if add #ifdef ?CONFIG_NAND_SPL, It is very clear. What do you think about it?

Ah, already used CONFIG_NAND_SPL at start.S. OK, we can do this work (change from CONFIG_NAND_SPL to CONFIG_PRELOADER) at another patch.

Thanks
Minkyu Kang

Signature · 2 lines

from. prom.
www.promsoft.net

seedshope

author

2011-01-09 14:52 UTC #12 lore raw

PATCH 3/3 SMDK6400: Fix build error for smdk6400 nand_spl support

Quoted 64 lines · Minkyu Kang

Hello,
Quoted 61 lines · seedshope
Quoted 50 lines · Minkyu Kang
Hi
Quoted 47 lines · seedshope
Quoted 24 lines · Minkyu Kang
Dear seedshope,
Quoted 21 lines · seedshope
From: seedshope<[email protected]>
Modify u-boot.lds from nand_spl/board/samsung/smdk6400.
start.o: In function `clbss_l':
nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to coloured_LED_init' nand_spl/board/samsung/smdk6400/start.S:358: undefined reference to red_LED_on'
start.o: In function `_rel_dyn_start_ofs':
nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__rel_dyn_start'
start.o: In function `_rel_dyn_end_ofs':
nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__rel_dyn_end'
start.o: In function `_dynsym_start_ofs':
nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__dynsym_start'
Signed-off-by seedshope<[email protected]>
Quoted 14 lines
arch/arm/cpu/arm1176/start.S clbss_l:str r2, [r0] /* clear loop... */ · line 356
Quoted 13 lines
arch/arm/cpu/arm1176/start.S +0 -0
index 237dcfe..bde0357 100644
@@ -353,10 +353,11 @@ clbss_l:str       r2, [r0]                /*
clear
loop... */
        add     r0, r0, #4
        cmp     r0, r1
        bne     clbss_l
arch/arm/cpu/arm1176/start.S +1 -1
-
+#ifndef CONFIG_NAND_SPL
CONFIG_PRELOADER is better
No, The nand_spl support can't find the define of coloured_LED_init and red_LED_on.
It is base on the build error:
make smdk6400_config
make
the error information as following:
Quoted 8 lines
Quoted 5 lines
nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to coloured_LED_init' nand_spl/board/samsung/smdk6400/start.S:358: undefined reference to red_LED_on'
Please add follow define at Makefile.
AFLAGS += -DCONFIG_PRELOADER -DCONFIG_NAND_SPL
CFLAGS += -DCONFIG_PRELOADER -DCONFIG_NAND_SPL
ok, It may be a good method.

Quoted 8 lines

Quoted 5 lines
But I worried other people will be difficult to see the process of the code running.
So, if add #ifdef CONFIG_NAND_SPL, It is very clear. What do you think about it?
Ah, already used CONFIG_NAND_SPL at start.S. OK, we can do this work (change from CONFIG_NAND_SPL to CONFIG_PRELOADER) at another patch.

Ok, I will send RR2 for SMDK6400 relate patch.

Thanks,
seedshope

Quoted 2 lines

Thanks
Minkyu Kang

Albert ARIBAUD

2011-01-08 05:55 UTC #13 lore raw

PATCH 1/3 SMDK6400: Fix CONFIG_SYS_INIT_SP_ADDR undeclared

In reply to seedshope

Le 07/01/2011 16:53, seedshope a ?crit :

Quoted 6 lines

From: seedshope<[email protected]>
CONFIG_SYS_INIT_SP_ADDR point the last PHY of IRAM and substract the global size.
Signed-off-by seedshope<[email protected]>

Please fix the From: line in all patches in this set; it should not appear in the long commit message.

Amicalement,

Signature · 1 line

Albert.

seedshope

author

2011-01-08 15:10 UTC #14 lore raw

PATCH 1/3 SMDK6400: Fix CONFIG_SYS_INIT_SP_ADDR undeclared

Quoted 9 lines · Albert ARIBAUD

Le 07/01/2011 16:53, seedshope a ?crit :
Quoted 6 lines
From: seedshope<[email protected]>
CONFIG_SYS_INIT_SP_ADDR point the last PHY of IRAM and substract the global size.
Signed-off-by seedshope<[email protected]>
Please fix the From: line in all patches in this set; it should not appear in the long commit message.

ok, I will send RR2.

Thanks,
seedshope

Quoted 1 line

Amicalement,

Albert ARIBAUD

2011-01-08 15:17 UTC #15 lore raw

PATCH 1/3 SMDK6400: Fix CONFIG_SYS_INIT_SP_ADDR undeclared

Le 08/01/2011 16:10, seedshope a ?crit :

Quoted 7 lines · Albert ARIBAUD

Quoted 6 lines
Le 07/01/2011 16:53, seedshope a ?crit :
Quoted 5 lines
From: seedshope<[email protected]>
CONFIG_SYS_INIT_SP_ADDR point the last PHY of IRAM and substract the global size.

Quoted 6 lines

Quoted 3 lines
Quoted 1 line
Signed-off-by seedshope<[email protected]>
Please fix the From: line in all patches in this set; it should not appear in the long commit message.
ok, I will send RR2.
Thanks,

You're welcome.

Don't forget to add some history in V2, so that people can tell what you changed from V1 to V2 of the patch.

Quoted 1 line

seedshope

Amicalement,

Signature · 1 line

Albert.

seedshope

author

2011-01-09 01:15 UTC #16 lore raw

PATCH 1/3 SMDK6400: Fix CONFIG_SYS_INIT_SP_ADDR undeclared

Quoted 11 lines · Albert ARIBAUD

Le 08/01/2011 16:10, seedshope a ?crit :
Quoted 10 lines · Albert ARIBAUD
Quoted 9 lines
Le 07/01/2011 16:53, seedshope a ?crit :
Quoted 6 lines
From: seedshope<[email protected]>
CONFIG_SYS_INIT_SP_ADDR point the last PHY of IRAM and substract the global size.
Signed-off-by seedshope<[email protected]>
Please fix the From: line in all patches in this set; it should not appear in the long commit message.

Quoted 8 lines

Quoted 3 lines
ok, I will send RR2.
Thanks,
You're welcome.
Don't forget to add some history in V2, so that people can tell what you changed from V1 to V2 of the patch.

ok,

Thanks,
seedshope

Quoted 4 lines

Quoted 2 lines
seedshope
Amicalement,