Skip to content Skip to conversation

243: remove test files before starting

PATCH In review Eric Sandeen 2 participants 2 messages Jan 11, 2011

Share & tools

Eric Sandeen

author

2011-01-11 15:36 UTC #0 lore raw

PATCH 1/1 243: remove test files before starting

I found that overwriting existing files hides a bug in ext4 (since fixed). Removing the files before the test reliably reproduces it.

Signed-off-by Eric Sandeen <[email protected]>

---

243 +3 -0

index 8b2e647..48f7932 100755
@@ -125,6 +125,9 @@ _require_xfs_io_falloc
 # Real QA test starts here.
 rm -f $seq.full
 
+# Remove any leftover files from last run.
+rm -f ${TEST_DIR}/test_?
+
 # Begin test cases.
 echo "Test 1: Fallocate 40960 bytes and write 4096 bytes (buffered io)." \
     >> $seq.full

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Christoph Hellwig

Reviewed-by on v1 1/1

2011-01-11 17:31 UTC #1 lore raw

Quoted 5 lines · Eric Sandeen

I found that overwriting existing files hides a bug in ext4 (since fixed). Removing the files before the test reliably reproduces it.
Signed-off-by Eric Sandeen <[email protected]>

Looks good,

Reviewed-by Christoph Hellwig <[email protected]>

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs