Skip to contentSkip to conversation

error in 2.6.37-git10

DISCUSSION Piotr Hosowicz 3 participants 8 messages Jan 14, 2011 Ecrypt file system

lore
Share & tools
lore

Piotr Hosowicz

author
#0 lore raw

Hello,

Build failed here:

CC [M] fs/ecryptfs/main.o
fs/ecryptfs/main.c:144: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘*’ token fs/ecryptfs/main.c: In function ‘ecryptfs_interpose’:
fs/ecryptfs/main.c:204: error: implicit declaration of function ‘ecryptfs_get_inode’ fs/ecryptfs/main.c:204: warning: initialization makes pointer from integer without a cast fs/ecryptfs/main.c:206: error: expected ‘)’ before ‘return’ fs/ecryptfs/main.c:212: error: expected expression before ‘}’ token fs/ecryptfs/main.c: In function ‘ecryptfs_mount’:
fs/ecryptfs/main.c:569: warning: assignment makes pointer from integer without a cast

Regards,

Piotr Hosowicz

Signature · 5 lines
Z cyklu "Uroki demokracji", czyli pytania i odpowiedzi w teledurniejach:
- Gdzie odbywały się lądowania Aliantów (D-Day)?
- Pearl Harbour?
NP: Patrick O'Hearn - Beautiful World
NB: 2.6.37-20110113-1411-pztidm+
#1 lore raw
Quoted 4 lines · Piotr Hosowicz

Hello,

Build failed here:

Quoted 13 lines

CC [M] fs/ecryptfs/main.o
fs/ecryptfs/main.c:144: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘*’ token
fs/ecryptfs/main.c: In function ‘ecryptfs_interpose’:
fs/ecryptfs/main.c:204: error: implicit declaration of function ‘ecryptfs_get_inode’
fs/ecryptfs/main.c:204: warning: initialization makes pointer from integer without a cast
fs/ecryptfs/main.c:206: error: expected ‘)’ before ‘return’ fs/ecryptfs/main.c:212: error: expected expression before ‘}’ token fs/ecryptfs/main.c: In function ‘ecryptfs_mount’:
fs/ecryptfs/main.c:569: warning: assignment makes pointer from integer without a cast

Could you check whether this is enough?

fs/ecryptfs/main.c +1 -0
index d3b28ab..d2e71a2 100644
@@ -34,6 +34,7 @@
 #include <linux/pagemap.h>
 #include <linux/key.h>
 #include <linux/parser.h>
+#include <linux/fs.h>
 #include <linux/fs_stack.h>
 #include <linux/slab.h>
 #include "ecryptfs_kernel.h"
Signature · 1 line
balbi
author
#2 lore raw
Quoted 19 lines · Felipe Balbi
Quoted 4 lines · Piotr Hosowicz

Hello,

Build failed here:

Quoted 13 lines

CC [M] fs/ecryptfs/main.o
fs/ecryptfs/main.c:144: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘*’ token
fs/ecryptfs/main.c: In function ‘ecryptfs_interpose’:
fs/ecryptfs/main.c:204: error: implicit declaration of function ‘ecryptfs_get_inode’
fs/ecryptfs/main.c:204: warning: initialization makes pointer from integer without a cast
fs/ecryptfs/main.c:206: error: expected ‘)’ before ‘return’ fs/ecryptfs/main.c:212: error: expected expression before ‘}’ token fs/ecryptfs/main.c: In function ‘ecryptfs_mount’:
fs/ecryptfs/main.c:569: warning: assignment makes pointer from integer without a cast

Quoted 1 line

Could you check whether this is enough?

I am building now with this option disabled, maybe I'll have time to test again.

Regards,

Piotr Hosowicz

Signature · 6 lines
"Chcemy waszego dobra!" - powiedział lider
socjaldemokratów. Zaniepokojeni obywatele
zaczeli ukrywać swoje dobra w bezpiecznych
miejscach.
NP: Patrick O'Hearn - Approaching Summit
NB: 2.6.37-20110113-1411-pztidm+
#3 lore raw
Quoted 20 lines · Piotr Hosowicz
Quoted 19 lines · Felipe Balbi
Quoted 17 lines · Piotr Hosowicz

Hello,

Build failed here:

CC [M] fs/ecryptfs/main.o
fs/ecryptfs/main.c:144: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘*’ token
fs/ecryptfs/main.c: In function ‘ecryptfs_interpose’:
fs/ecryptfs/main.c:204: error: implicit declaration of function ‘ecryptfs_get_inode’
fs/ecryptfs/main.c:204: warning: initialization makes pointer from integer without a cast
fs/ecryptfs/main.c:206: error: expected ‘)’ before ‘return’ fs/ecryptfs/main.c:212: error: expected expression before ‘}’ token fs/ecryptfs/main.c: In function ‘ecryptfs_mount’:
fs/ecryptfs/main.c:569: warning: assignment makes pointer from integer without a cast

Quoted 4 lines
Quoted 1 line

Could you check whether this is enough?

I am building now with this option disabled, maybe I'll have time to test again.

I just did. Compiled only that module with that header added. Built cleanly.

Sent a patch and Cced you too.

Signature · 1 line
balbi
author
#4 lore raw
Quoted 21 lines · Felipe Balbi
Quoted 20 lines · Piotr Hosowicz
Quoted 19 lines · Felipe Balbi
Quoted 17 lines · Piotr Hosowicz

Hello,

Build failed here:

CC [M] fs/ecryptfs/main.o
fs/ecryptfs/main.c:144: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘*’ token
fs/ecryptfs/main.c: In function ‘ecryptfs_interpose’:
fs/ecryptfs/main.c:204: error: implicit declaration of function ‘ecryptfs_get_inode’
fs/ecryptfs/main.c:204: warning: initialization makes pointer from integer without a cast
fs/ecryptfs/main.c:206: error: expected ‘)’ before ‘return’ fs/ecryptfs/main.c:212: error: expected expression before ‘}’ token fs/ecryptfs/main.c: In function ‘ecryptfs_mount’:
fs/ecryptfs/main.c:569: warning: assignment makes pointer from integer without a cast

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Could you check whether this is enough?

I am building now with this option disabled, maybe I'll have time to test again.

I just did. Compiled only that module with that header added. Built cleanly.

I corrected and am building again. Hope this helps.

Regards,

Piotr Hosowicz

Signature · 6 lines
W korytarzach kremlowskich Breżniew spotyka Susłowa. Susłow pyta:
- Leonid, wiesz, że jeden but masz żółty, a drugi czarny?
- Wiem, Misza, chciałem nawet zmienić, ale w domu mam to samo,
  jeden żółty i jeden czarny.
NP: Patrick O'Hearn - An Evening Sky
NB: 2.6.37-20110113-1411-pztidm+
author
#5 lore raw
Quoted 24 lines · Piotr Hosowicz
Quoted 23 lines · Felipe Balbi
Quoted 22 lines · Piotr Hosowicz
Quoted 20 lines · Felipe Balbi
Quoted 4 lines · Piotr Hosowicz

Hello,

Build failed here:

Quoted 13 lines

CC [M] fs/ecryptfs/main.o
fs/ecryptfs/main.c:144: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘*’ token
fs/ecryptfs/main.c: In function ‘ecryptfs_interpose’:
fs/ecryptfs/main.c:204: error: implicit declaration of function ‘ecryptfs_get_inode’
fs/ecryptfs/main.c:204: warning: initialization makes pointer from integer without a cast
fs/ecryptfs/main.c:206: error: expected ‘)’ before ‘return’ fs/ecryptfs/main.c:212: error: expected expression before ‘}’ token fs/ecryptfs/main.c: In function ‘ecryptfs_mount’:
fs/ecryptfs/main.c:569: warning: assignment makes pointer from integer without a cast

Could you check whether this is enough?

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

I am building now with this option disabled, maybe I'll have time to test again.

I just did. Compiled only that module with that header added. Built cleanly.

I corrected and am building again. Hope this helps.

I don't know why but it failed again. I disabled and am building again.

Regards,

Piotr Hosowicz

Signature · 5 lines
Janusz Korwin-Mikke:
"ZUS z pewnością jest instytucją przestępczą,
ale nie można nazwać jej zorganizowaną."
NP: Patrick O'Hearn - Approaching Summit
NB: 2.6.37-20110113-1411-pztidm+
#6 lore raw

Hi,

Quoted 3 lines · Piotr Hosowicz
Quoted 1 line

I corrected and am building again. Hope this helps.

I don't know why but it failed again. I disabled and am building again.

for me it builds ok:

  CC [M]  fs/ecryptfs/dentry.o
  CC [M]  fs/ecryptfs/file.o
  CC [M]  fs/ecryptfs/inode.o
  CC [M]  fs/ecryptfs/main.o
  CC [M]  fs/ecryptfs/super.o
  CC [M]  fs/ecryptfs/mmap.o
  CC [M]  fs/ecryptfs/read_write.o
  CC [M]  fs/ecryptfs/crypto.o
  CC [M]  fs/ecryptfs/keystore.o
  CC [M]  fs/ecryptfs/messaging.o
  CC [M]  fs/ecryptfs/miscdev.o
  CC [M]  fs/ecryptfs/kthread.o
  CC [M]  fs/ecryptfs/debug.o
  LD [M]  fs/ecryptfs/ecryptfs.o

weird.

Signature · 1 line
balbi
#7 lore raw
Quoted 24 lines · Felipe Balbi

Hi,

Quoted 3 lines · Piotr Hosowicz
Quoted 1 line

I corrected and am building again. Hope this helps.

I don't know why but it failed again. I disabled and am building again.

for me it builds ok:

  CC [M]  fs/ecryptfs/dentry.o
  CC [M]  fs/ecryptfs/file.o
  CC [M]  fs/ecryptfs/inode.o
  CC [M]  fs/ecryptfs/main.o
  CC [M]  fs/ecryptfs/super.o
  CC [M]  fs/ecryptfs/mmap.o
  CC [M]  fs/ecryptfs/read_write.o
  CC [M]  fs/ecryptfs/crypto.o
  CC [M]  fs/ecryptfs/keystore.o
  CC [M]  fs/ecryptfs/messaging.o
  CC [M]  fs/ecryptfs/miscdev.o
  CC [M]  fs/ecryptfs/kthread.o
  CC [M]  fs/ecryptfs/debug.o
  LD [M]  fs/ecryptfs/ecryptfs.o
Quoted 2 lines

weird.

This is because it was fixed meanwhile

commit 6254b32b5791e47ba1c679d023f26985fa34755a

Author: Linus Torvalds <[email protected]>
Date:   Thu Jan 13 17:19:38 2011 -0800

ecryptfs: fix broken build

Stephen Rothwell reports that the vfs merge broke the build of ecryptfs. The breakage comes from commit 66cb76666d69 ("sanitize ecryptfs ->mount()") which was obviously not even build tested. Tssk, tssk, Al.

This is the minimal build fixup for the situation, although I don't have a filesystem to actually test it with.

Reported-by Stephen Rothwell <[email protected]>
Cc Al Viro <[email protected]>
Signed-off-by Linus Torvalds <[email protected]>