sctp: Make some local functions static
Subsystems (2)
PATCH 1/1 sctp: Make some local functions static
sparse proposed to mark these functions as static as they are only accessed locally. This patch is doing that.
Signed-off-by Holger Hans Peter Freyther <[email protected]>
--- net/sctp/probe.c | 10 +++++----- net/sctp/sm_make_chunk.c | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-)
net/sctp/probe.c +5 -5
@@ -122,11 +122,11 @@ static const struct file_operations sctpprobe_fops = { .llseek = noop_llseek, }; -sctp_disposition_t jsctp_sf_eat_sack (const struct sctp_endpoint *ep, -const struct sctp_association *asoc, -const sctp_subtype_t type, -void *arg, -sctp_cmd_seq_t *commands) +static sctp_disposition_t jsctp_sf_eat_sack (const struct sctp_endpoint *ep, +const struct sctp_association *asoc, +const sctp_subtype_t type, +void *arg, +sctp_cmd_seq_t *commands) {struct sctp_transport *sp;static __u32 lcwnd =0 ;
net/sctp/sm_make_chunk.c +2 -2
@@ -132,8 +132,8 @@ void sctp_init_cause(struct sctp_chunk *chunk, __be16 cause_code,* abort chunk. Differs from sctp_init_cause in that it won't oops * if there isn't enough space in the op error chunk */ -int sctp_init_cause_fixed (struct sctp_chunk *chunk,__be16 cause_code, -size_t paylen) +static int sctp_init_cause_fixed (struct sctp_chunk *chunk,__be16 cause_code, +size_t paylen) {sctp_errhdr_t err;__u16 len;
Quoted 3 lines
sparse proposed to mark these functions as static as they are only accessed locally. This patch is doing that.
It is OK to me.
Acked-by Wei Yongjun <[email protected]>
Would your please send patch inline and cc to David and [email protected]? thanks
Quoted 7 lines
Signed-off-by Holger Hans Peter Freyther <[email protected]>--- net/sctp/probe.c | 10 +++++----- net/sctp/sm_make_chunk.c | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-)