Skip to contentSkip to conversation

add checking the CONFIG_ENV_IS_IN_SPI_FLASH in Enbedded env

PATCH New Yoshihiro Shimoda 3 participants 4 messages Jan 17, 2011 – Jan 19, 2011

lore
Share & tools
lore

Yoshihiro Shimoda

author
#0 lore raw

PATCH 1/1 add checking the CONFIG_ENV_IS_IN_SPI_FLASH in Enbedded env

Fix the problem which cannot build the U-boot, if we only set the CONFIG_ENV_IS_IN_SPI_FLASH.

Signed-off-by Yoshihiro Shimoda <[email protected]>
---
 include/environment.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/environment.h +1 -0
index 082b3e1..8a4f393 100644
@@ -106,6 +106,7 @@ extern unsigned long nand_env_oob_offset;
 /* Embedded env is only supported for some flash types */
 #ifdef CONFIG_ENV_IS_EMBEDDED
 # if !defined(CONFIG_ENV_IS_IN_FLASH) && \
+     !defined(CONFIG_ENV_IS_IN_SPI_FLASH) && \
      !defined(CONFIG_ENV_IS_IN_NAND) && \
      !defined(CONFIG_ENV_IS_IN_ONENAND)
 #  error "CONFIG_ENV_IS_EMBEDDED not supported for your flash type"
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 add checking the CONFIG_ENV_IS_IN_SPI_FLASH in Enbedded env

Quoted 4 lines · Yoshihiro Shimoda

Fix the problem which cannot build the U-boot, if we only set the CONFIG_ENV_IS_IN_SPI_FLASH.

Signed-off-by Yoshihiro Shimoda <[email protected]>
Acked-by Nobuhiro Iwamatsu <[email protected]>
Quoted 23 lines
---
 include/environment.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/environment.h +1 -0
index 082b3e1..8a4f393 100644
@@ -106,6 +106,7 @@ extern unsigned long nand_env_oob_offset;
 /* Embedded env is only supported for some flash types */
 #ifdef CONFIG_ENV_IS_EMBEDDED
 # if !defined(CONFIG_ENV_IS_IN_FLASH) && \
+     !defined(CONFIG_ENV_IS_IN_SPI_FLASH) && \
      !defined(CONFIG_ENV_IS_IN_NAND) && \
      !defined(CONFIG_ENV_IS_IN_ONENAND)
 #  error "CONFIG_ENV_IS_EMBEDDED not supported for your flash type"
Signature · 6 lines
1.7.1

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
#2 lore raw

PATCH 1/1 add checking the CONFIG_ENV_IS_IN_SPI_FLASH in Enbedded env

In reply to Yoshihiro Shimoda

Dear Yoshihiro Shimoda,

Quoted 13 lines · In message <[email protected]> you wrote:

Fix the problem which cannot build the U-boot, if we only set the CONFIG_ENV_IS_IN_SPI_FLASH.

Signed-off-by Yoshihiro Shimoda <[email protected]>
---
 include/environment.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/environment.h +0 -0
index 082b3e1..8a4f393 100644

include/environment.h extern unsigned long nand_env_oob_offset; · line 111

Quoted 6 lines
include/environment.h +1 -0
@@ -106,6 +106,7 @@ extern unsigned long nand_env_oob_offset;
 /* Embedded env is only supported for some flash types */
 #ifdef CONFIG_ENV_IS_EMBEDDED
 # if !defined(CONFIG_ENV_IS_IN_FLASH) && \
+     !defined(CONFIG_ENV_IS_IN_SPI_FLASH) && \
      !defined(CONFIG_ENV_IS_IN_NAND) && \
      !defined(CONFIG_ENV_IS_IN_ONENAND)

Please keep list sorted.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Randal said it would be tough to do in sed. He didn't say  he  didn't
understand  sed.  Randal  understands sed quite well. Which is why he
uses Perl. :-)         - Larry Wall in <[email protected]>
author
#3 lore raw

PATCH 1/1 add checking the CONFIG_ENV_IS_IN_SPI_FLASH in Enbedded env

Dear Wolfgang Denk,

Quoted 10 lines · Wolfgang Denk

Dear Yoshihiro Shimoda,

Quoted 6 lines

/* Embedded env is only supported for some flash types */ #ifdef CONFIG_ENV_IS_EMBEDDED

 # if !defined(CONFIG_ENV_IS_IN_FLASH) && \
+     !defined(CONFIG_ENV_IS_IN_SPI_FLASH) && \
      !defined(CONFIG_ENV_IS_IN_NAND) && \
      !defined(CONFIG_ENV_IS_IN_ONENAND)

Please keep list sorted.

Oh, I didn't realize that is sorted by alphabet.
I will fix it.

Best regards,
Yoshihiro Shimoda