Skip to contentSkip to conversation

usb: gadget/fsl_mxc_udc: Detect the CPU type in run-time

PATCH Superseded Fabio Estevam 3 participants 4 messages Jan 19, 2011 – Jan 20, 2011 USB

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH v2 1/1 usb: gadget/fsl_mxc_udc: Detect the CPU type in run-time

Make sure we are running on a MX35 processor.

Signed-off-by Fabio Estevam <[email protected]>
---
 drivers/usb/gadget/fsl_mxc_udc.c |   19 +++++++++++--------
 1 files changed, 11 insertions(+), 8 deletions(-)
drivers/usb/gadget/fsl_mxc_udc.c +11 -8
index 77b1eb5..c1a65cd 100644
@@ -89,14 +89,17 @@ void fsl_udc_clk_finalize(struct platform_device *pdev)
 {
 	struct fsl_usb2_platform_data *pdata = pdev->dev.platform_data;
 #if defined(CONFIG_ARCH_MX35)
-	unsigned int v;
-
-	/* workaround ENGcm09152 for i.MX35 */
-	if (pdata->workaround & FLS_USB2_WORKAROUND_ENGCM09152) {
-		v = readl(MX35_IO_ADDRESS(MX35_USB_BASE_ADDR +
-				USBPHYCTRL_OTGBASE_OFFSET));
-		writel(v | USBPHYCTRL_EVDO, MX35_IO_ADDRESS(MX35_USB_BASE_ADDR +
-				USBPHYCTRL_OTGBASE_OFFSET));
+	if (cpu_is_mx35()) {
+		unsigned int v;
+
+		/* workaround ENGcm09152 for i.MX35 */
+		if (pdata->workaround & FLS_USB2_WORKAROUND_ENGCM09152) {
+			v = readl(MX35_IO_ADDRESS(MX35_USB_BASE_ADDR +
+					USBPHYCTRL_OTGBASE_OFFSET));
+			writel(v | USBPHYCTRL_EVDO,
+				MX35_IO_ADDRESS(MX35_USB_BASE_ADDR +
+					USBPHYCTRL_OTGBASE_OFFSET));
+		}
 	}
 #endif
Signature · 1 line
1.6.0.4
#1 lore raw

PATCH v2 1/1 usb: gadget/fsl_mxc_udc: Detect the CPU type in run-time

Quoted 3 lines · Fabio Estevam

Make sure we are running on a MX35 processor.

Signed-off-by Fabio Estevam<[email protected]>
Acked-by Eric B?nard <[email protected]>
Quoted 34 lines
---
  drivers/usb/gadget/fsl_mxc_udc.c |   19 +++++++++++--------
  1 files changed, 11 insertions(+), 8 deletions(-)
drivers/usb/gadget/fsl_mxc_udc.c +11 -8
index 77b1eb5..c1a65cd 100644
@@ -89,14 +89,17 @@ void fsl_udc_clk_finalize(struct platform_device *pdev)
  {
  	struct fsl_usb2_platform_data *pdata = pdev->dev.platform_data;
  #if defined(CONFIG_ARCH_MX35)
-	unsigned int v;
-
-	/* workaround ENGcm09152 for i.MX35 */
-	if (pdata->workaround&  FLS_USB2_WORKAROUND_ENGCM09152) {
-		v = readl(MX35_IO_ADDRESS(MX35_USB_BASE_ADDR +
-				USBPHYCTRL_OTGBASE_OFFSET));
-		writel(v | USBPHYCTRL_EVDO, MX35_IO_ADDRESS(MX35_USB_BASE_ADDR +
-				USBPHYCTRL_OTGBASE_OFFSET));
+	if (cpu_is_mx35()) {
+		unsigned int v;
+
+		/* workaround ENGcm09152 for i.MX35 */
+		if (pdata->workaround&  FLS_USB2_WORKAROUND_ENGCM09152) {
+			v = readl(MX35_IO_ADDRESS(MX35_USB_BASE_ADDR +
+					USBPHYCTRL_OTGBASE_OFFSET));
+			writel(v | USBPHYCTRL_EVDO,
+				MX35_IO_ADDRESS(MX35_USB_BASE_ADDR +
+					USBPHYCTRL_OTGBASE_OFFSET));
+		}
  	}
  #endif
#3 lore raw

PATCH v2 1/1 usb: gadget/fsl_mxc_udc: Detect the CPU type in run-time

Quoted 5 lines · Uwe Kleine-K?nig
Quoted 3 lines · Fabio Estevam

Make sure we are running on a MX35 processor.

Signed-off-by Fabio Estevam <[email protected]>

Looks good, Acked-by: Uwe Kleine-K?nig <[email protected]>

looking again s/CONFIG_ARCH_MX35/CONFIG_SOC_IMX35/ would be nice.

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |