ARM: */start.S: code cleanup

PATCH New Jason Liu 4 participants 4 messages Dec 23, 2010 – Jan 20, 2011 Arm (32-bit)

lore

Share & tools

lore

Jason Liu

author

2010-12-23 04:35 UTC #0 lore raw

PATCH v2 1/1 ARM: */start.S: code cleanup

Remove the useless code from start.S

Signed-off-by Jason Liu <[email protected]>

---
Changes for v2:
-Address the comments from Albert to make changes to all
ARM cpus with one single patch

---
 arch/arm/cpu/arm1136/start.S   |    2 --
 arch/arm/cpu/arm1176/start.S   |    2 --
 arch/arm/cpu/arm720t/start.S   |    2 --
 arch/arm/cpu/arm920t/start.S   |    2 --
 arch/arm/cpu/arm925t/start.S   |    2 --
 arch/arm/cpu/arm926ejs/start.S |    2 --
 arch/arm/cpu/arm946es/start.S  |    2 --
 arch/arm/cpu/arm_intcm/start.S |    2 --
 arch/arm/cpu/armv7/start.S     |    2 --
 arch/arm/cpu/ixp/start.S       |    2 --
 arch/arm/cpu/lh7a40x/start.S   |    2 --
 arch/arm/cpu/pxa/start.S       |    2 --
 arch/arm/cpu/s3c44b0/start.S   |    2 --
 arch/arm/cpu/sa1100/start.S    |    2 --
 14 files changed, 0 insertions(+), 28 deletions(-)

arch/arm/cpu/arm1136/start.S +0 -2

index 9a6f6cb..b771d31 100644
@@ -196,7 +196,6 @@ stack_setup:
 	cmp	r0, r6
 	beq	clear_bss		/* skip relocation */
 	mov	r1, r6			/* r1 <- scratch for copy_loop */
-	ldr	r2, _TEXT_BASE
 	ldr	r3, _bss_start_ofs
 	add	r2, r0, r3		/* r2 <- source end address	    */

@@ -251,7 +250,6 @@ clear_bss:
 #ifndef CONFIG_PRELOADER
 	ldr	r0, _bss_start_ofs
 	ldr	r1, _bss_end_ofs
-	ldr	r3, _TEXT_BASE		/* Text base */
 	mov	r4, r6			/* reloc addr */
 	add	r0, r0, r4
 	add	r1, r1, r4

arch/arm/cpu/arm1176/start.S +0 -2

index 237dcfe..363329a 100644
@@ -250,7 +250,6 @@ stack_setup:
 	cmp	r0, r6
 	beq	clear_bss		/* skip relocation */
 	mov	r1, r6			/* r1 <- scratch for copy_loop */
-	ldr	r2, _TEXT_BASE
 	ldr	r3, _bss_start_ofs
 	add	r2, r0, r3		/* r2 <- source end address	    */

@@ -343,7 +342,6 @@ clear_bss:
 #ifndef CONFIG_PRELOADER
 	ldr	r0, _bss_start_ofs
 	ldr	r1, _bss_end_ofs
-	ldr	r3, _TEXT_BASE		/* Text base */
 	mov	r4, r6			/* reloc addr */
 	add	r0, r0, r4
 	add	r1, r1, r4

arch/arm/cpu/arm720t/start.S +0 -2

index abfa124..c098118 100644
@@ -165,7 +165,6 @@ stack_setup:
 	cmp	r0, r6
 	beq	clear_bss		/* skip relocation */
 	mov	r1, r6			/* r1 <- scratch for copy_loop */
-	ldr	r2, _TEXT_BASE
 	ldr	r3, _bss_start_ofs
 	add	r2, r0, r3		/* r2 <- source end address	    */

@@ -220,7 +219,6 @@ clear_bss:
 #ifndef CONFIG_PRELOADER
 	ldr	r0, _bss_start_ofs
 	ldr	r1, _bss_end_ofs
-	ldr	r3, _TEXT_BASE		/* Text base */
 	mov	r4, r6			/* reloc addr */
 	add	r0, r0, r4
 	add	r1, r1, r4

arch/arm/cpu/arm920t/start.S +0 -2

index 08f178d..6bccf61 100644
@@ -211,7 +211,6 @@ stack_setup:
 	cmp	r0, r6
 	beq	clear_bss		/* skip relocation */
 	mov	r1, r6			/* r1 <- scratch for copy_loop */
-	ldr	r2, _TEXT_BASE
 	ldr	r3, _bss_start_ofs
 	add	r2, r0, r3		/* r2 <- source end address	    */

@@ -266,7 +265,6 @@ clear_bss:
 #ifndef CONFIG_PRELOADER
 	ldr	r0, _bss_start_ofs
 	ldr	r1, _bss_end_ofs
-	ldr	r3, _TEXT_BASE		/* Text base */
 	mov	r4, r6			/* reloc addr */
 	add	r0, r0, r4
 	add	r1, r1, r4

arch/arm/cpu/arm925t/start.S +0 -2

index 2c0c869..20ecdd5 100644
@@ -202,7 +202,6 @@ stack_setup:
 	cmp	r0, r6
 	beq	clear_bss		/* skip relocation */
 	mov	r1, r6			/* r1 <- scratch for copy_loop */
-	ldr	r2, _TEXT_BASE
 	ldr	r3, _bss_start_ofs
 	add	r2, r0, r3		/* r2 <- source end address	    */

@@ -257,7 +256,6 @@ clear_bss:
 #ifndef CONFIG_PRELOADER
 	ldr	r0, _bss_start_ofs
 	ldr	r1, _bss_end_ofs
-	ldr	r3, _TEXT_BASE		/* Text base */
 	mov	r4, r6			/* reloc addr */
 	add	r0, r0, r4
 	add	r1, r1, r4

arch/arm/cpu/arm926ejs/start.S +0 -2

index 5519252..eb93ac9 100644
@@ -201,7 +201,6 @@ stack_setup:
 	cmp	r0, r6
 	beq	clear_bss		/* skip relocation */
 	mov	r1, r6			/* r1 <- scratch for copy loop */
-	ldr	r2, _TEXT_BASE
 	ldr	r3, _bss_start_ofs
 	add	r2, r0, r3		/* r2 <- source end address	    */

@@ -256,7 +255,6 @@ clear_bss:
 #ifndef CONFIG_PRELOADER
 	ldr	r0, _bss_start_ofs
 	ldr	r1, _bss_end_ofs
-	ldr	r3, _TEXT_BASE		/* Text base */
 	mov	r4, r6			/* reloc addr */
 	add	r0, r0, r4
 	add	r1, r1, r4

arch/arm/cpu/arm946es/start.S +0 -2

index f9c9470..296effc 100644
@@ -173,7 +173,6 @@ stack_setup:
 	cmp	r0, r6
 	beq	clear_bss		/* skip relocation */
 	mov	r1, r6			/* r1 <- scratch for copy_loop */
-	ldr	r2, _TEXT_BASE
 	ldr	r3, _bss_start_ofs
 	add	r2, r0, r3		/* r2 <- source end address	    */

@@ -228,7 +227,6 @@ clear_bss:
 #ifndef CONFIG_PRELOADER
 	ldr	r0, _bss_start_ofs
 	ldr	r1, _bss_end_ofs
-	ldr	r3, _TEXT_BASE		/* Text base */
 	mov	r4, r6			/* reloc addr */
 	add	r0, r0, r4
 	add	r1, r1, r4

arch/arm/cpu/arm_intcm/start.S +0 -2

index d28e745..e8518e2 100644
@@ -169,7 +169,6 @@ stack_setup:
 	cmp	r0, r6
 	beq	clear_bss		/* skip relocation */
 	mov	r1, r6			/* r1 <- scratch for copy_loop */
-	ldr	r2, _TEXT_BASE
 	ldr	r3, _bss_start_ofs
 	add	r2, r0, r3		/* r2 <- source end address	    */

@@ -224,7 +223,6 @@ clear_bss:
 #ifndef CONFIG_PRELOADER
 	ldr	r0, _bss_start_ofs
 	ldr	r1, _bss_end_ofs
-	ldr	r3, _TEXT_BASE		/* Text base */
 	mov	r4, r6			/* reloc addr */
 	add	r0, r0, r4
 	add	r1, r1, r4

arch/arm/cpu/armv7/start.S +0 -2

index 684f2d2..cb4f92f 100644
@@ -171,7 +171,6 @@ stack_setup:
 	beq	clear_bss		/* skip relocation */
 #endif
 	mov	r1, r6			/* r1 <- scratch for copy_loop */
-	ldr	r2, _TEXT_BASE
 	ldr	r3, _bss_start_ofs
 	add	r2, r0, r3		/* r2 <- source end address	    */

@@ -224,7 +223,6 @@ fixnext:
 clear_bss:
 	ldr	r0, _bss_start_ofs
 	ldr	r1, _bss_end_ofs
-	ldr	r3, _TEXT_BASE		/* Text base */
 	mov	r4, r6			/* reloc addr */
 	add	r0, r0, r4
 	add	r1, r1, r4

arch/arm/cpu/ixp/start.S +0 -2

index 9f8c15b..f71a398 100644
@@ -295,7 +295,6 @@ stack_setup:
 	cmp	r0, r6
 	beq	clear_bss		/* skip relocation */
 	mov	r1, r6			/* r1 <- scratch for copy_loop */
-	ldr	r2, _TEXT_BASE
 	ldr	r3, _bss_start_ofs
 	add	r2, r0, r3		/* r2 <- source end address	    */

@@ -350,7 +349,6 @@ clear_bss:
 #ifndef CONFIG_PRELOADER
 	ldr	r0, _bss_start_ofs
 	ldr	r1, _bss_end_ofs
-	ldr	r3, _TEXT_BASE		/* Text base */
 	mov	r4, r6			/* reloc addr */
 	add	r0, r0, r4
 	add	r1, r1, r4

arch/arm/cpu/lh7a40x/start.S +0 -2

index 32dfe8b..1457427 100644
@@ -182,7 +182,6 @@ stack_setup:
 	cmp	r0, r6
 	beq	clear_bss		/* skip relocation */
 	mov	r1, r6			/* r1 <- scratch for copy_loop */
-	ldr	r2, _TEXT_BASE
 	ldr	r3, _bss_start_ofs
 	add	r2, r0, r3		/* r2 <- source end address	    */

@@ -237,7 +236,6 @@ clear_bss:
 #ifndef CONFIG_PRELOADER
 	ldr	r0, _bss_start_ofs
 	ldr	r1, _bss_end_ofs
-	ldr	r3, _TEXT_BASE		/* Text base */
 	mov	r4, r6			/* reloc addr */
 	add	r0, r0, r4
 	add	r1, r1, r4

arch/arm/cpu/pxa/start.S +0 -2

index fbd0def..d2d391e 100644
@@ -247,7 +247,6 @@ stack_setup:
 	cmp	r0, r6
 	beq	clear_bss		/* skip relocation */
 	mov	r1, r6			/* r1 <- scratch for copy_loop */
-	ldr	r2, _TEXT_BASE
 	ldr	r3, _bss_start_ofs
 	add	r2, r0, r3		/* r2 <- source end address	    */

@@ -304,7 +303,6 @@ clear_bss:
 #ifndef CONFIG_PRELOADER
 	ldr	r0, _bss_start_ofs
 	ldr	r1, _bss_end_ofs
-	ldr	r3, _TEXT_BASE		/* Text base */
 	mov	r4, r6			/* reloc addr */
 	add	r0, r0, r4
 	add	r1, r1, r4

arch/arm/cpu/s3c44b0/start.S +0 -2

index 9379af6..9c9c3b3 100644
@@ -154,7 +154,6 @@ stack_setup:
 	cmp	r0, r6
 	beq	clear_bss		/* skip relocation */
 	mov	r1, r6			/* r1 <- scratch for copy_loop */
-	ldr	r2, _TEXT_BASE
 	ldr	r3, _bss_start_ofs
 	add	r2, r0, r3		/* r2 <- source end address	    */

@@ -209,7 +208,6 @@ clear_bss:
 #ifndef CONFIG_PRELOADER
 	ldr	r0, _bss_start_ofs
 	ldr	r1, _bss_end_ofs
-	ldr	r3, _TEXT_BASE		/* Text base */
 	mov	r4, r6			/* reloc addr */
 	add	r0, r0, r4
 	add	r1, r1, r4

arch/arm/cpu/sa1100/start.S +0 -2

index 7c2db4f..815d704 100644
@@ -158,7 +158,6 @@ stack_setup:
 	cmp	r0, r6
 	beq	clear_bss		/* skip relocation */
 	mov	r1, r6			/* r1 <- scratch for copy_loop */
-	ldr	r2, _TEXT_BASE
 	ldr	r3, _bss_start_ofs
 	add	r2, r0, r3		/* r2 <- source end address	    */

@@ -213,7 +212,6 @@ clear_bss:
 #ifndef CONFIG_PRELOADER
 	ldr	r0, _bss_start_ofs
 	ldr	r1, _bss_end_ofs
-	ldr	r3, _TEXT_BASE		/* Text base */
 	mov	r4, r6			/* reloc addr */
 	add	r0, r0, r4
 	add	r1, r1, r4

Signature · 1 line

1.7.0.4

Jason Liu

2011-01-17 19:54 UTC #1 lore raw

PATCH v2 1/1 ARM: */start.S: code cleanup

Hi, Albert,

2010/12/23 Jason Liu <[email protected]>:

Quoted 23 lines

Remove the useless code from start.S

Signed-off-by Jason Liu <[email protected]>

---
Changes for v2:
-Address the comments from Albert to make changes to all ?ARM cpus with one single patch
---

?arch/arm/cpu/arm1136/start.S ? | ? ?2 --
?arch/arm/cpu/arm1176/start.S ? | ? ?2 --
?arch/arm/cpu/arm720t/start.S ? | ? ?2 --
?arch/arm/cpu/arm920t/start.S ? | ? ?2 --
?arch/arm/cpu/arm925t/start.S ? | ? ?2 --
?arch/arm/cpu/arm926ejs/start.S | ? ?2 --
?arch/arm/cpu/arm946es/start.S ?| ? ?2 --
?arch/arm/cpu/arm_intcm/start.S | ? ?2 --
?arch/arm/cpu/armv7/start.S ? ? | ? ?2 --
?arch/arm/cpu/ixp/start.S ? ? ? | ? ?2 --
?arch/arm/cpu/lh7a40x/start.S ? | ? ?2 --
?arch/arm/cpu/pxa/start.S ? ? ? | ? ?2 --
?arch/arm/cpu/s3c44b0/start.S ? | ? ?2 --
?arch/arm/cpu/sa1100/start.S ? ?| ? ?2 --

Quoted 2 lines

?14 files changed, 0 insertions(+), 28 deletions(-)

Any feedback about this patch?

Quoted 6 lines

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Andreas Bießmann

2011-01-18 07:27 UTC #2 lore raw

PATCH v2 1/1 ARM: */start.S: code cleanup

Dear Jason Liu,
Dear Albert Aribaud,

Am 17.01.2011 um 20:54 schrieb Jason Liu:

Quoted 13 lines

Hi, Albert,
2010/12/23 Jason Liu <[email protected]>:
Quoted 9 lines
Remove the useless code from start.S
Signed-off-by Jason Liu <[email protected]>
---
Changes for v2:
-Address the comments from Albert to make changes to all
ARM cpus with one single patch
---

Quoted 3 lines

Quoted 1 line
 arch/arm/cpu/arm920t/start.S   |    2 --
Any feedback about this patch?

Tested-by Andreas Bie?mann <[email protected]>

This patch is correct for arm920t. This patch is most probable correct for other architectures.

regards

Andreas Bie?mann

Albert ARIBAUD

2011-01-20 20:28 UTC #3 lore raw

PATCH v2 1/1 ARM: */start.S: code cleanup

Le 18/01/2011 08:27, Andreas Bie?mann a ?crit :

Quoted 18 lines

Dear Jason Liu,
Dear Albert Aribaud,
Am 17.01.2011 um 20:54 schrieb Jason Liu:
Quoted 12 lines
Hi, Albert,
2010/12/23 Jason Liu<[email protected]>:
Quoted 9 lines
Remove the useless code from start.S
Signed-off-by Jason Liu<[email protected]>
---
Changes for v2:
-Address the comments from Albert to make changes to all
ARM cpus with one single patch
---

Quoted 5 lines

Quoted 3 lines
Quoted 1 line
  arch/arm/cpu/arm920t/start.S   |    2 --
Any feedback about this patch?
Tested-by Andreas Bie?mann<[email protected]>

Applied to u-boot-arm, thanks -- and apologies for the backlogging.

Amicalement,

Signature · 1 line

Albert.