Skip to contentSkip to conversation

DaVinci: Fix DM365 & DM644X build error

PATCH New Mohammed Afzal 3 participants 3 messages Jan 20, 2011

lore
Share & tools
lore

Mohammed Afzal

author
#0 lore raw

PATCH 1/1 DaVinci: Fix DM365 & DM644X build error

DM365 & DM644X builds 'davinci_emac_mii_mode_sel()', which uses 'davinci_syscfg_regs' macro, and the macro is valid iff CONFIG_SOC_DA8XX is defined.

Fix: Before compiling 'davinci_emac_mii_mode_sel()', make sure that CONFIG_SOC_DA8XX is defined.

Signed-off-by Mohammed Afzal <[email protected]>
---
 board/davinci/common/misc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
board/davinci/common/misc.c +1 -1
index 08c898f..c0a6c41 100644
@@ -80,7 +80,7 @@ err:
 /*
  * Set the mii mode as MII or RMII
  */
-#if defined(CONFIG_DRIVER_TI_EMAC)
+#if defined(CONFIG_DRIVER_TI_EMAC) && defined(CONFIG_SOC_DA8XX)
 void davinci_emac_mii_mode_sel(int mode_sel)
 {
 	int val;
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 DaVinci: Fix DM365 & DM644X build error

Le 20/01/2011 12:27, Mohammed Afzal a ?crit :

Quoted 17 lines

DM365& DM644X builds 'davinci_emac_mii_mode_sel()', which uses 'davinci_syscfg_regs' macro, and the macro is valid iff CONFIG_SOC_DA8XX is defined.

Fix: Before compiling 'davinci_emac_mii_mode_sel()', make sure that CONFIG_SOC_DA8XX is defined.

Signed-off-by Mohammed Afzal<[email protected]>
---
  board/davinci/common/misc.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
board/davinci/common/misc.c +0 -0
index 08c898f..c0a6c41 100644

board/davinci/common/misc.c err: · line 86

Quoted 8 lines
board/davinci/common/misc.c +1 -1
@@ -80,7 +80,7 @@ err:
  /*
   * Set the mii mode as MII or RMII
   */
-#if defined(CONFIG_DRIVER_TI_EMAC)
+#if defined(CONFIG_DRIVER_TI_EMAC)&&  defined(CONFIG_SOC_DA8XX)
  void davinci_emac_mii_mode_sel(int mode_sel)
  {
  	int val;

Seems this is already fixed by commit 51861a953aa10fde5c861ca022f0833f326e3041 which is in u-boot-ti/master, right?

Amicalement,

Signature · 1 line
Albert.
#2 lore raw

PATCH 1/1 DaVinci: Fix DM365 & DM644X build error

Quoted 5 lines

Seems this is already fixed by commit 51861a953aa10fde5c861ca022f0833f326e3041 which is in u-boot-ti/master, right?

Yes that is correct I believe. Before my vacation I was getting the entire Davinci series of SOCs compiling as they were broken for various reasons and this is one of the fixes I had made IIRC.

This commit should be in u-boot-arm/master as well

--Sandeep