davinci: da8xx/omap-l1x: add platform device for davinci-pcm-audio
Subsystems (3)
PATCH 1/1 davinci: da8xx/omap-l1x: add platform device for davinci-pcm-audio
After the multi-component commit f0fba2ad for ASoC, we need to register the platform device for davinci-pcm-audio.
This patch and patch at [1] are required for audio to work on DA850/OMAP-L138.
[1] https://patchwork.kernel.org/patch/495211/
--- arch/arm/mach-davinci/devices-da8xx.c | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-)
arch/arm/mach-davinci/devices-da8xx.c +12 -0
@@ -480,8 +480,20 @@ static struct platform_device da850_mcasp_device = { .resource = da850_mcasp_resources, }; +struct platform_device davinci_pcm_device = { + .name ="davinci-pcm-audio" , + .id =-1 , +}; + +static void davinci_init_pcm (void ) +{ +platform_device_register (&davinci_pcm_device); +} +void __init da8xx_register_mcasp (int id,struct snd_platform_data *pdata) { +davinci_init_pcm (); +/* DA830/OMAP-L137 has 3 instances of McASP */ if (cpu_is_davinci_da830 () && id ==1 ) { da830_mcasp1_device.dev.platform_data = pdata;
Signature · 1 line
1.7.1
PATCH 1/1 davinci: da8xx/omap-l1x: add platform device for davinci-pcm-audio
Hello.
Quoted 1 line · Sudhakar
After the multi-component commit
f0fba2ad
Please also specify the commit summary in parens, as asked by Linus.
Quoted 25 lines
for ASoC, we need to
register the platform device for davinci-pcm-audio.This patch and patch at [1] are required for audio to work on DA850/OMAP-L138.
[1] https://patchwork.kernel.org/patch/495211/
Signed-off-by Rajashekhara, Sudhakar <[email protected]>Tested-by Dan Sharon <[email protected]>--- arch/arm/mach-davinci/devices-da8xx.c | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-)arch/arm/mach-davinci/devices-da8xx.c +3
-0@@ -480,8 +480,20 @@ static struct platform_device da850_mcasp_device = { .resource = da850_mcasp_resources, }; +struct platform_device davinci_pcm_device = { + .name ="davinci-pcm-audio" , + .id =-1 ,
arch/arm/mach-davinci/devices-da8xx.c static struct platform_device da850_mcasp_device = { · line 495
Quoted 10 lines
arch/arm/mach-davinci/devices-da8xx.c +8
-0+}; + +static void davinci_init_pcm (void ) +{ +platform_device_register (&davinci_pcm_device); +} +void __init da8xx_register_mcasp (int id,struct snd_platform_data *pdata) { +davinci_init_pcm ();
Why not call platform_device_register() directly?
WBR, Sergei
PATCH 1/1 davinci: da8xx/omap-l1x: add platform device for davinci-pcm-audio
Hi Sergei,
Quoted 8 lines · Sergei Shtylyov
Hello.
Quoted 1 line · Sudhakar
After the multi-component commit
f0fba2adPlease also specify the commit summary in parens, as asked by Linus.
Sure, will do it.
Quoted 22 lines
Quoted 22 lines
for ASoC, we need to
register the platform device for davinci-pcm-audio.This patch and patch at [1] are required for audio to work on DA850/OMAP-L138.
[1] https://patchwork.kernel.org/patch/495211/
Signed-off-by Rajashekhara, Sudhakar <[email protected]>Tested-by Dan Sharon <[email protected]>--- arch/arm/mach-davinci/devices-da8xx.c | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-)arch/arm/mach-davinci/devices-da8xx.c +0
-0@@ -480,8 +480,20 @@ static struct platform_device da850_mcasp_device = { .resource = da850_mcasp_resources, };
Quoted 16 lines
arch/arm/mach-davinci/devices-da8xx.c static struct platform_device da850_mcasp_device = { · line 495
Quoted 13 lines
arch/arm/mach-davinci/devices-da8xx.c +11
-0+struct platform_device davinci_pcm_device = { + .name ="davinci-pcm-audio" , + .id =-1 , +}; + +static void davinci_init_pcm (void ) +{ +platform_device_register (&davinci_pcm_device); +} +void __init da8xx_register_mcasp (int id,struct snd_platform_data *pdata) { +davinci_init_pcm ();Why not call
platform_device_register()directly?
This is a good suggestion. Anyhow I am calling only platform_device_register() functions inside da8xx_register_mcasp(), so I can add this one as well.
Regards,
Sudhakar