Skip to contentSkip to conversation

mmc: mmc_mxc: Allow selection only for the correct platforms

PATCH New Fabio Estevam 5 participants 7 messages Jan 20, 2011 – Feb 9, 2011 MMC, SD and SDIO

lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH 1/1 mmc: mmc_mxc: Allow selection only for the correct platforms

Currently MMC_MXC driver can be selected by all i.MX devices.

Restrict its use only for the appropriate processors.

Signed-off-by Fabio Estevam <[email protected]>
---
 drivers/mmc/host/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mmc/host/Kconfig +1 -1
index d618e86..a3a9ec1 100644
@@ -288,7 +288,7 @@ config MMC_MSM
 
 config MMC_MXC
 	tristate "Freescale i.MX2/3 Multimedia Card Interface support"
-	depends on ARCH_MXC
+	depends on MACH_MX21 || MACH_MX27 || ARCH_MX31
 	help
 	  This selects the Freescale i.MX2/3 Multimedia card Interface.
 	  If you have a i.MX platform with a Multimedia Card slot,
Signature · 1 line
1.6.0.4
#1 lore raw

PATCH 1/1 mmc: mmc_mxc: Allow selection only for the correct platforms

Quoted 5 lines · Fabio Estevam

Currently MMC_MXC driver can be selected by all i.MX devices.

Restrict its use only for the appropriate processors.

Signed-off-by Fabio Estevam <[email protected]>
Acked-by Sascha Hauer <[email protected]>
Quoted 22 lines
---
 drivers/mmc/host/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mmc/host/Kconfig +1 -1
index d618e86..a3a9ec1 100644
@@ -288,7 +288,7 @@ config MMC_MSM
 
 config MMC_MXC
 	tristate "Freescale i.MX2/3 Multimedia Card Interface support"
-	depends on ARCH_MXC
+	depends on MACH_MX21 || MACH_MX27 || ARCH_MX31
 	help
 	  This selects the Freescale i.MX2/3 Multimedia card Interface.
 	  If you have a i.MX platform with a Multimedia Card slot,
Signature · 1 line
1.6.0.4
Signature · 4 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
#2 lore raw

PATCH 1/1 mmc: mmc_mxc: Allow selection only for the correct platforms

Chris?

-----Original Message-----
From: Sascha Hauer [mailto:s.hauer at pengutronix.de]
Sent: Friday, January 21, 2011 8:35 AM
To: Estevam Fabio-R49496
Cc: linux-mmc at vger.kernel.org; cjb at laptop.org; kernel at pengutronix.de; u.kleine-koenig at pengutronix.de; linux-arm-kernel at lists.infradead.org
Subject: Re: [PATCH] mmc: mmc_mxc: Allow selection only for the correct platforms

Quoted 5 lines · Fabio Estevam

Currently MMC_MXC driver can be selected by all i.MX devices.

Restrict its use only for the appropriate processors.

Signed-off-by Fabio Estevam <[email protected]>
Acked-by Sascha Hauer <[email protected]>
Quoted 22 lines
---
 drivers/mmc/host/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mmc/host/Kconfig index renamed from drivers/mmc/host/Kconfig +0 -0

d618e86..a3a9ec1 100644

drivers/mmc/host/Kconfig +1 -2
@@ -288,7 +288,7 @@ config MMC_MSM
 
 config MMC_MXC
 	tristate "Freescale i.MX2/3 Multimedia Card Interface support"
-	depends on ARCH_MXC
+	depends on MACH_MX21 || MACH_MX27 || ARCH_MX31
 	help
 	  This selects the Freescale i.MX2/3 Multimedia card Interface.
 	  If you have a i.MX platform with a Multimedia Card slot,
--

1.6.0.4

Signature · 4 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
#3 lore raw

PATCH 1/1 mmc: mmc_mxc: Allow selection only for the correct platforms

Hi Fabio,

Quoted 8 lines · On Wed, Feb 09, 2011 at 12:40:51AM +0000, Estevam Fabio-R49496 wrote:
Quoted 5 lines · Fabio Estevam

Currently MMC_MXC driver can be selected by all i.MX devices.

Restrict its use only for the appropriate processors.

Signed-off-by Fabio Estevam <[email protected]>
Acked-by Sascha Hauer <[email protected]>

Thanks for the ping -- I've pushed this to mmc-next with Sascha's ACK now.

Signature · 2 lines
Chris Ball   <[email protected]>   <http://printf.net/>
One Laptop Per Child
#4 lore raw

PATCH 1/1 mmc: mmc_mxc: Allow selection only for the correct platforms

In reply to Fabio Estevam

Hallo,

Quoted 14 lines · Fabio Estevam

Currently MMC_MXC driver can be selected by all i.MX devices.

Restrict its use only for the appropriate processors.

Signed-off-by Fabio Estevam <[email protected]>
---
 drivers/mmc/host/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mmc/host/Kconfig +0 -0
index d618e86..a3a9ec1 100644

drivers/mmc/host/Kconfig config MMC_MSM · line 291

Quoted 5 lines
drivers/mmc/host/Kconfig +1 -1
@@ -288,7 +288,7 @@ config MMC_MSM
 
 config MMC_MXC
 	tristate "Freescale i.MX2/3 Multimedia Card Interface support"
-	depends on ARCH_MXC
+	depends on MACH_MX21 || MACH_MX27 || ARCH_MX31

What about

depends IMX_HAVE_PLATFORM_MXC_MMC

? Then if i.MX29 has the same IP you don't need to touch this again.

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
author
#5 lore raw

PATCH 1/1 mmc: mmc_mxc: Allow selection only for the correct platforms

Hi Uwe,

Quoted 18 lines · Uwe Kleine-K?nig

Hallo,

Quoted 15 lines · Fabio Estevam

Currently MMC_MXC driver can be selected by all i.MX devices.

Restrict its use only for the appropriate processors.

Signed-off-by Fabio Estevam <[email protected]>
---
 drivers/mmc/host/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mmc/host/Kconfig +0 -0
index d618e86..a3a9ec1 100644
@@ -288,7 +288,7 @@ config MMC_MSM
Quoted 7 lines

drivers/mmc/host/Kconfig config MMC_MSM · line 291

Quoted 4 lines
drivers/mmc/host/Kconfig +1 -1
 config MMC_MXC
 	tristate "Freescale i.MX2/3 Multimedia Card Interface support"
-	depends on ARCH_MXC
+	depends on MACH_MX21 || MACH_MX27 || ARCH_MX31

What about

depends IMX_HAVE_PLATFORM_MXC_MMC

I would prefer to let the architectures explicitly in Kconfig.

If someone selects IMX_HAVE_PLATFORM_MXC_MMC by mistake on a MX51 board, it will be possible to select the MXC_MMC driver in the kernel for MX51, which is incorrect.

Using the approach of explicitly marking the architectures that support MXC_MMC would avoid such problems as well.

Quoted 2 lines

? Then if i.MX29 has the same IP you don't need to touch this again.

Not likely to happen.

Thanks,

Fabio Estevam

#6 lore raw

PATCH 1/1 mmc: mmc_mxc: Allow selection only for the correct platforms

Hello Fabio,

Quoted 23 lines · Fabio Estevam
Quoted 22 lines · Uwe Kleine-K?nig
Quoted 14 lines · Fabio Estevam

Currently MMC_MXC driver can be selected by all i.MX devices.

Restrict its use only for the appropriate processors.

Signed-off-by Fabio Estevam <[email protected]>
---
 drivers/mmc/host/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mmc/host/Kconfig +0 -0
index d618e86..a3a9ec1 100644

drivers/mmc/host/Kconfig config MMC_MSM · line 291

Quoted 5 lines
drivers/mmc/host/Kconfig +1 -1
@@ -288,7 +288,7 @@ config MMC_MSM
 
 config MMC_MXC
 	tristate "Freescale i.MX2/3 Multimedia Card Interface support"
-	depends on ARCH_MXC
+	depends on MACH_MX21 || MACH_MX27 || ARCH_MX31

What about

Quoted 7 lines
Quoted 1 line

depends IMX_HAVE_PLATFORM_MXC_MMC

I would prefer to let the architectures explicitly in Kconfig.

If someone selects IMX_HAVE_PLATFORM_MXC_MMC by mistake on a MX51 board, it will be possible to select the MXC_MMC driver in the kernel for MX51, which is incorrect.

it's not optimal, but nothing happens unless this someone registers a corresponding device, too.

Quoted 6 lines

Using the approach of explicitly marking the architectures that support MXC_MMC would avoid such problems as well.

Quoted 2 lines

? Then if i.MX29 has the same IP you don't need to touch this again.

Not likely to happen.

I wouldn't bet ...

Note I don't argue, if you still prefer the explicit list it's OK for me.

Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |