Skip to contentSkip to conversation

hid kernel module for wireless remote LC Power model RC1000MCE

PATCH In review chris schlund 2 participants 2 messages Jan 24, 2011 – Jan 25, 2011 HID

lore
Share & tools
lore

chris schlund

author
#0 lore raw

PATCH 1/1 hid kernel module for wireless remote LC Power model RC1000MCE

Hi,

I bought a remote control LC Power RC1000MCE (usb rf keyboard). Some keys were not working. Therefore I took the hid-topseed kernel module copied it and prepared it as a new kernel module hid-lcpower which provides the correct keymapping for this remote control. I tested it on the 2.6.32 kernel.
I modified it to compile with the kernel version 2.6.37 (untested).

Sorry If I made some formal errors in here. This is my first patch and I am not used to this process.

Thanks
Chris

39$ cat lc-power.patch

drivers/hid/hid-core.c 2011-01-24 17:01:00.000000000 +0100 renamed from drivers/hid/hid-core.c 2011-01-05 01:50:19.000000000 +0100 +0 -0
diff -urN linux-2.6.37/drivers/hid/hid-core.c linux/drivers/hid/hid-core.c
@@ -1312,6 +1312,7 @@
        { HID_USB_DEVICE(USB_VENDOR_ID_KENSINGTON,

USB_DEVICE_ID_KS_SLIMBLADE) },

        { HID_USB_DEVICE(USB_VENDOR_ID_KYE, USB_DEVICE_ID_KYE_ERGO_525V) },
        { HID_USB_DEVICE(USB_VENDOR_ID_LABTEC,

USB_DEVICE_ID_LABTEC_WIRELESS_KEYBOARD) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_LCPOWER, USB_DEVICE_ID_LCPOWER_LC1000 ) },
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
USB_DEVICE_ID_MX3000_RECEIVER) },
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
USB_DEVICE_ID_S510_RECEIVER) },
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
USB_DEVICE_ID_S510_RECEIVER_2) },

drivers/hid/hid-ids.h 2011-01-24 17:01:00.000000000 +0100 renamed from drivers/hid/hid-ids.h 2011-01-05 01:50:19.000000000 +0100 +3 -0
diff -urN linux-2.6.37/drivers/hid/hid-ids.h linux/drivers/hid/hid-ids.h
@@ -330,6 +330,9 @@
 #define USB_VENDOR_ID_LABTEC           0x1020
 #define USB_DEVICE_ID_LABTEC_WIRELESS_KEYBOARD 0x0006
 
+#define USB_VENDOR_ID_LCPOWER          0x1241
+#define USB_DEVICE_ID_LCPOWER_LC1000   0xf767
+
 #define USB_VENDOR_ID_LD               0x0f11
 #define USB_DEVICE_ID_LD_CASSY         0x1000
 #define USB_DEVICE_ID_LD_POCKETCASSY   0x1010
drivers/hid/hid-lcpower.c 2011-01-24 17:01:00.000000000 +0100 renamed from drivers/hid/hid-lcpower.c 1970-01-01 01:00:00.000000000 +0100 +70 -0

70 lines not on this page · raw message

drivers/hid/Kconfig 2011-01-24 17:01:00.000000000 +0100 renamed from drivers/hid/Kconfig 2011-01-05 01:50:19.000000000 +0100 +7 -0
diff -urN linux-2.6.37/drivers/hid/Kconfig linux/drivers/hid/Kconfig
@@ -207,6 +207,13 @@
        ---help---
        Support for Kensington Slimblade Trackball.
 
+config HID_LCPOWER
+       tristate "LC-Power" if EMBEDDED
+       depends on USB_HID
+       default !EMBEDDED
+       ---help---
+       Support for LC-Power RC1000MCE RF remote control.
+
 config HID_LOGITECH
        tristate "Logitech devices" if EMBEDDED
        depends on USB_HID
drivers/hid/Makefile 2011-01-24 17:01:00.000000000 +0100 renamed from drivers/hid/Makefile 2011-01-05 01:50:19.000000000 +0100 +1 -0
diff -urN linux-2.6.37/drivers/hid/Makefile linux/drivers/hid/Makefile
@@ -41,6 +41,7 @@
 obj-$(CONFIG_HID_GYRATION)     += hid-gyration.o
 obj-$(CONFIG_HID_KENSINGTON)   += hid-kensington.o
 obj-$(CONFIG_HID_KYE)          += hid-kye.o
+obj-$(CONFIG_HID_LCPOWER)      += hid-lcpower.o
 obj-$(CONFIG_HID_LOGITECH)     += hid-logitech.o
 obj-$(CONFIG_HID_MAGICMOUSE)   += hid-magicmouse.o
 obj-$(CONFIG_HID_MICROSOFT)    += hid-microsoft.o
#1 lore raw
Quoted 6 lines · chris schlund

I bought a remote control LC Power RC1000MCE (usb rf keyboard). Some keys were not working. Therefore I took the hid-topseed kernel module copied it and prepared it as a new kernel module hid-lcpower which provides the correct keymapping for this remote control.
I tested it on the 2.6.32 kernel.
I modified it to compile with the kernel version 2.6.37 (untested).

Hi Chris,

thanks a lot for the driver.

First, I am missing your Signed-off-by: line, without which I can't apply your driver. Please see Documentation/SubmittingPatches for details.

Second, your mailer has damaged (line-wrapped) the patch.

[ ... snip ... ]

drivers/hid/Kconfig 2011-01-24 17:01:00.000000000 +0100 line 213

Quoted 4 lines
drivers/hid/Kconfig 2011-01-24 17:01:00.000000000 +0100 renamed from drivers/hid/Kconfig 2011-01-05 01:50:19.000000000 +0100 +4 -0
+config HID_LCPOWER
+       tristate "LC-Power" if EMBEDDED
+       depends on USB_HID
+       default !EMBEDDED

Also, we are not going the EMBEDDED path any more (see commit 73d5e8f77e88a4 for explanation).

Could you please fix that up and resend?

Thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs, Novell Inc.