Skip to contentSkip to conversation

Change the visible output for transfers to display hex numbers

PATCH New Alexander Holler 2 participants 3 messages Jan 25, 2011 Networking

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Change the visible output for transfers to display hex numbers

When files were transfered the output is currently
-
Bytes transferred = 1976384 (1e2840 hex)
-
Using the decimal length as input for other commands conflicts with the the default base of 16 needed.

Change the output to
-
Bytes transferred = 0x1e2840 (1976384 bytes)
-
to reflect what should be used as input for other commands.

---
 net/net.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
net/net.c +1 -1
index a609632..a454411 100644
@@ -528,7 +528,7 @@ restart:
 		case NETLOOP_SUCCESS:
 			if (NetBootFileXferSize > 0) {
 				char buf[20];
-				printf("Bytes transferred = %ld (%lx hex)\n",
+				printf("Bytes transferred = 0x%lx (%ld bytes)\n",
 					NetBootFileXferSize,
 					NetBootFileXferSize);
 				sprintf(buf, "%lX", NetBootFileXferSize);
Signature · 1 line
1.7.3.4
#1 lore raw

PATCH 1/1 Change the visible output for transfers to display hex numbers

Dear Alexander Holler,

Quoted 7 lines · In message <[email protected]> you wrote:

When files were transfered the output is currently
-
Bytes transferred = 1976384 (1e2840 hex)
-
Using the decimal length as input for other commands conflicts with the the default base of 16 needed.

Quoted 5 lines

Change the output to
-
Bytes transferred = 0x1e2840 (1976384 bytes)
-
to reflect what should be used as input for other commands.

In which way does this reflect what "should be used as input for other commands"?

I don't even understand why you use this manually with copy & paste.

Why don't you simply refer to the ${filesize} variable?

In any case, if you want to change this format, you must change _all_ occurrences of it, i. e. include all the commands that load from external storage (ide, usb, scsi, sata, nand, dataflash, SPI-Flash, ...).

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Lots of folks confuse bad management with destiny.   -- Frank Hubbard
#2 lore raw

PATCH 1/1 Change the visible output for transfers to display hex numbers

Hello,

Am 25.01.2011 11:27, schrieb Wolfgang Denk:

Quoted 19 lines

Dear Alexander Holler,

Quoted 7 lines · In message<[email protected]> you wrote:

When files were transfered the output is currently
-
Bytes transferred = 1976384 (1e2840 hex)
-
Using the decimal length as input for other commands conflicts with the the default base of 16 needed.

Quoted 5 lines

Change the output to
-
Bytes transferred = 0x1e2840 (1976384 bytes)
-
to reflect what should be used as input for other commands.

In which way does this reflect what "should be used as input for other commands"?

Quoted 3 lines

I don't even understand why you use this manually with copy& paste.

Why don't you simply refer to the ${filesize} variable?

TIMTOWTDI

Quoted 4 lines

In any case, if you want to change this format, you must change _all_ occurrences of it, i. e. include all the commands that load from external storage (ide, usb, scsi, sata, nand, dataflash, SPI-Flash, ...).

Than I prefer not to change something and live with that unorthogonality. Besides several READMEs, net/net.c is the only source where

git grep "Bytes transferred"

shows that such an output is used.

Regards,

Alexander