Skip to contentSkip to conversation

ALSA: HDA: Fix automute on Thinkpad L412/L512

PATCH In review David Henningsson 2 participants 2 messages Jan 26, 2011 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: HDA: Fix automute on Thinkpad L412/L512

More Thinkpad machines with invalid SKU found, that disables
automute between speakers and headphones on these machines. I'm considering putting in a quirk mask instead, but I'm not exactly sure on how wide I should make it...any suggestion?

Signature · 2 lines
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic
Quoted 1 line

From ffe97bdd72c997ba5c0bfd0e05288fe9f4093b45 Mon Sep 17 00:00:00 2001

From: David Henningsson <[email protected]>
Date: Wed, 26 Jan 2011 11:46:12 +0100
Subject: [PATCH] ALSA: HDA: Fix automute on Thinkpad L412/L512

More Thinkpad machines with invalid SKU found, that disables automute between speakers and headphones on these machines.

---
 sound/pci/hda/patch_realtek.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
sound/pci/hda/patch_realtek.c +4 -2
index be4df4c..2fa9ed9 100644
@@ -14954,9 +14954,11 @@ static struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x104d, 0x9084, "Sony VAIO", ALC275_FIXUP_SONY_HWEQ),
 	SND_PCI_QUIRK_VENDOR(0x104d, "Sony VAIO", ALC269_FIXUP_SONY_VAIO),
 	SND_PCI_QUIRK(0x1028, 0x0470, "Dell M101z", ALC269_FIXUP_DELL_M101Z),
-	SND_PCI_QUIRK(0x17aa, 0x21b8, "Thinkpad Edge 14", ALC269_FIXUP_SKU_IGNORE),
-	SND_PCI_QUIRK(0x17aa, 0x21e9, "Thinkpad Edge 14", ALC269_FIXUP_SKU_IGNORE),
 	SND_PCI_QUIRK(0x17aa, 0x20f2, "Thinkpad SL410/510", ALC269_FIXUP_SKU_IGNORE),
+	SND_PCI_QUIRK(0x17aa, 0x215e, "Thinkpad L512", ALC269_FIXUP_SKU_IGNORE),
+	SND_PCI_QUIRK(0x17aa, 0x21b8, "Thinkpad Edge 14", ALC269_FIXUP_SKU_IGNORE),
+	SND_PCI_QUIRK(0x17aa, 0x21ca, "Thinkpad L412", ALC269_FIXUP_SKU_IGNORE),
+	SND_PCI_QUIRK(0x17aa, 0x21e9, "Thinkpad Edge 15", ALC269_FIXUP_SKU_IGNORE),
 	SND_PCI_QUIRK(0x1043, 0x1a13, "Asus G73Jw", ALC269_FIXUP_ASUS_G73JW),
 	SND_PCI_QUIRK(0x17aa, 0x9e54, "LENOVO NB", ALC269_FIXUP_LENOVO_EAPD),
 	{}
Signature · 1 line
1.7.1

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

#1 lore raw

At Wed, 26 Jan 2011 11:53:52 +0100,

Quoted 5 lines · David Henningsson

More Thinkpad machines with invalid SKU found, that disables automute between speakers and headphones on these machines. I'm considering putting in a quirk mask instead, but I'm not exactly sure on how wide I should make it...any suggestion?

Using a vendor mask for this quirk would be a relatively low risk, I suppose. At most, a desktop that has really no speaker might be wrongly configured. But I don't think there is such one.

Anyway, I applied this patch as is now for 2.6.38. For quirk mask, let's do it for 2.6.39.

thanks,

Takashi

Quoted 39 lines

David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic
[2 0001-ALSA-HDA-Fix-automute-on-Thinkpad-L412-L512.patch <text/x-patch (7bit)>]

Quoted 1 line

From ffe97bdd72c997ba5c0bfd0e05288fe9f4093b45 Mon Sep 17 00:00:00 2001

From: David Henningsson <[email protected]>
Date: Wed, 26 Jan 2011 11:46:12 +0100
Subject: [PATCH] ALSA: HDA: Fix automute on Thinkpad L412/L512

More Thinkpad machines with invalid SKU found, that disables automute between speakers and headphones on these machines.

---
 sound/pci/hda/patch_realtek.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
sound/pci/hda/patch_realtek.c +4 -2
index be4df4c..2fa9ed9 100644
@@ -14954,9 +14954,11 @@ static struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x104d, 0x9084, "Sony VAIO", ALC275_FIXUP_SONY_HWEQ),
 	SND_PCI_QUIRK_VENDOR(0x104d, "Sony VAIO", ALC269_FIXUP_SONY_VAIO),
 	SND_PCI_QUIRK(0x1028, 0x0470, "Dell M101z", ALC269_FIXUP_DELL_M101Z),
-	SND_PCI_QUIRK(0x17aa, 0x21b8, "Thinkpad Edge 14", ALC269_FIXUP_SKU_IGNORE),
-	SND_PCI_QUIRK(0x17aa, 0x21e9, "Thinkpad Edge 14", ALC269_FIXUP_SKU_IGNORE),
 	SND_PCI_QUIRK(0x17aa, 0x20f2, "Thinkpad SL410/510", ALC269_FIXUP_SKU_IGNORE),
+	SND_PCI_QUIRK(0x17aa, 0x215e, "Thinkpad L512", ALC269_FIXUP_SKU_IGNORE),
+	SND_PCI_QUIRK(0x17aa, 0x21b8, "Thinkpad Edge 14", ALC269_FIXUP_SKU_IGNORE),
+	SND_PCI_QUIRK(0x17aa, 0x21ca, "Thinkpad L412", ALC269_FIXUP_SKU_IGNORE),
+	SND_PCI_QUIRK(0x17aa, 0x21e9, "Thinkpad Edge 15", ALC269_FIXUP_SKU_IGNORE),
 	SND_PCI_QUIRK(0x1043, 0x1a13, "Asus G73Jw", ALC269_FIXUP_ASUS_G73JW),
 	SND_PCI_QUIRK(0x17aa, 0x9e54, "LENOVO NB", ALC269_FIXUP_LENOVO_EAPD),
 	{}
Signature · 1 line
1.7.1