ARM: S5PV210: Add GONI board setup for CIF camera support

PATCH Superseded Sylwester Nawrocki 4 participants 11 messages Jan 7, 2011 – Jan 28, 2011

Subsystems (3)

Arm (32-bit) Arm sub-architectures Arm Samsung Exynos

lore

Share & tools

lore

Sylwester Nawrocki

author

2011-01-07 16:57 UTC #0 lore raw

PATCH 1/1 ARM: S5PV210: Add GONI board setup for CIF camera support

Hello,

the following patch series introduces changes in GONI board setup file required for the CIF camera sensor driver.
The first patch adds the I2C0 bus driver, the second one adds the regulator supply definitions and the third one just increases virtual size of the framebuffer window 0 for preview double buffering.

The patch series contains:

[PATCH 1/3] ARM: S5PV210: Enable I2C0 bus on GONI board [PATCH 2/3] ARM: S5PV210: Add supplies for CIF camera on GONI board [PATCH 3/3] ARM: S5PV210: Change framebuffer window 0 size on GONI

Created against kgene-for-next branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git

Regards,
Sylwester

--
Sylwester Nawrocki
Samsung Poland R&D Center

Sylwester Nawrocki

author

2011-01-07 16:57 UTC #1 lore raw

PATCH 1/3 ARM: S5PV210: Enable I2C0 bus on GONI board

Add I2C0 bus platform device for camera sensors.

Signed-off-by Sylwester Nawrocki <[email protected]>

Signed-off-by Kyungmin Park <[email protected]>

---
 arch/arm/mach-s5pv210/Kconfig     |    1 +
 arch/arm/mach-s5pv210/mach-goni.c |    4 ++++
 2 files changed, 5 insertions(+), 0 deletions(-)

arch/arm/mach-s5pv210/Kconfig +1 -0

index 53aabef..b0aa462 100644
@@ -75,6 +75,7 @@ config MACH_GONI
 	bool "GONI"
 	select CPU_S5PV210
 	select S5P_GPIO_INT
+	select S3C_DEV_I2C0
 	select S3C_DEV_FB
 	select S5P_DEV_FIMC0
 	select S5P_DEV_FIMC1

arch/arm/mach-s5pv210/mach-goni.c +4 -0

index e22d511..fc34575 100644
@@ -800,6 +800,7 @@ static struct platform_device *goni_devices[] __initdata = {
 	&s5pv210_device_iis0,
 	&s3c_device_usb_hsotg,
 	&samsung_device_keypad,
+	&s3c_device_i2c0,
 	&s3c_device_i2c1,
 	&s3c_device_i2c2,
 	&wm8994_fixed_voltage0,

@@ -827,6 +828,9 @@ static void __init goni_machine_init(void)
 	/* Radio: call before I2C 1 registeration */
 	goni_radio_init();
 
+	/* I2C0 */
+	s3c_i2c0_set_platdata(NULL);
+
 	/* I2C1 */
 	s3c_i2c1_set_platdata(NULL);
 	i2c_register_board_info(1, i2c1_devs, ARRAY_SIZE(i2c1_devs));

Signature · 1 line

1.7.3.5

Kukjin Kim

2011-01-28 09:28 UTC #2 lore raw

PATCH 1/3 ARM: S5PV210: Enable I2C0 bus on GONI board

Quoted 15 lines · Sylwester Nawrocki

Add I2C0 bus platform device for camera sensors.
Signed-off-by Sylwester Nawrocki <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
 arch/arm/mach-s5pv210/Kconfig     |    1 +
 arch/arm/mach-s5pv210/mach-goni.c |    4 ++++
 2 files changed, 5 insertions(+), 0 deletions(-)
arch/arm/mach-s5pv210/Kconfig +0 -0
index 53aabef..b0aa462 100644

arch/arm/mach-s5pv210/Kconfig config MACH_GONI · line 78

Quoted 4 lines

arch/arm/mach-s5pv210/Kconfig +1 -0

@@ -75,6 +75,7 @@ config MACH_GONI
 	bool "GONI"
 	select CPU_S5PV210
 	select S5P_GPIO_INT
+	select S3C_DEV_I2C0

NO...Where is S3C_DEV_I2C0?
Basically, platform device of i2c0 which is in arch/arm/plat-samsung/dev-i2c0.c is always selected.

Review

Quoted 4 lines

arch/arm/mach-s5pv210/Kconfig +0 -0
 	select S3C_DEV_FB
 	select S5P_DEV_FIMC0
 	select S5P_DEV_FIMC1
(quoted diff) +0 -0

b/arch/arm/mach-s5pv210/mach-

arch/arm/mach-s5pv210/mach-goni.c static struct platform_device *goni_devices[]

Quoted 5 lines

goni.c
index e22d511..fc34575 100644
arch/arm/mach-s5pv210/mach-goni.c +0 -0
@@ -800,6 +800,7 @@ static struct platform_device *goni_devices[]

__initdata

Quoted 19 lines

arch/arm/mach-s5pv210/mach-goni.c +1 -0

 = {
 	&s5pv210_device_iis0,
 	&s3c_device_usb_hsotg,
 	&samsung_device_keypad,
+	&s3c_device_i2c0,
 	&s3c_device_i2c1,
 	&s3c_device_i2c2,

arch/arm/mach-s5pv210/mach-goni.c +3 -1

 	&wm8994_fixed_voltage0,

@@ -827,6 +828,9 @@ static void __init goni_machine_init(void)
 	/* Radio: call before I2C 1 registeration */
 	goni_radio_init();
 
+	/* I2C0 */
+	s3c_i2c0_set_platdata(NULL);
+
 	/* I2C1 */
 	s3c_i2c1_set_platdata(NULL);
 	i2c_register_board_info(1, i2c1_devs, ARRAY_SIZE(i2c1_devs));
--

Quoted 1 line

1.7.3.5

Others, ok...please re-work this against on latest my for-next.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

Sylwester Nawrocki

2011-01-28 14:18 UTC #3 lore raw

PATCH 1/3 ARM: S5PV210: Enable I2C0 bus on GONI board

Hi Kukjin,

Quoted 11 lines · Kukjin Kim

Quoted 10 lines · Sylwester Nawrocki
Add I2C0 bus platform device for camera sensors.
Signed-off-by Sylwester Nawrocki<[email protected]>
Signed-off-by Kyungmin Park<[email protected]>
---
  arch/arm/mach-s5pv210/Kconfig     |    1 +
  arch/arm/mach-s5pv210/mach-goni.c |    4 ++++
  2 files changed, 5 insertions(+), 0 deletions(-)

Quoted 13 lines

arch/arm/mach-s5pv210/Kconfig config MACH_GONI · line 78
Quoted 9 lines
arch/arm/mach-s5pv210/Kconfig +1 -0
index 53aabef..b0aa462 100644
@@ -75,6 +75,7 @@ config MACH_GONI
  	bool "GONI"
  	select CPU_S5PV210
  	select S5P_GPIO_INT
+	select S3C_DEV_I2C0
NO...Where is S3C_DEV_I2C0?
Basically, platform device of i2c0 which is in arch/arm/plat-samsung/dev-i2c0.c is always selected.

Oh, sorry about that omission. I'll resend that one corrected.

Thanks,
Sylwester

Sylwester Nawrocki

author

2011-01-07 16:57 UTC #4 lore raw

PATCH 2/3 ARM: S5PV210: Add supplies for CIF camera on GONI board

In reply to Sylwester Nawrocki

Add regulator supplies required for NOON010PC30 CIF sensor.

Signed-off-by Sylwester Nawrocki <[email protected]>

Signed-off-by Kyungmin Park <[email protected]>

---
 arch/arm/mach-s5pv210/mach-goni.c |   24 +++++++++++++++++++++---
 1 files changed, 21 insertions(+), 3 deletions(-)

arch/arm/mach-s5pv210/mach-goni.c +21 -3

index fc34575..2051cee 100644
@@ -273,6 +273,18 @@ static struct regulator_consumer_supply goni_ldo5_consumers[] = {
 	REGULATOR_SUPPLY("vmmc", "s3c-sdhci.0"),
 };
 
+static struct regulator_consumer_supply goni_ldo11_consumers[] = {
+	REGULATOR_SUPPLY("vddio", "0-0030"), /* "CAM_IO_2.8V" */
+};
+
+static struct regulator_consumer_supply goni_ldo13_consumers[] = {
+	REGULATOR_SUPPLY("vdda", "0-0030"), /* "CAM_A_2.8V" */
+};
+
+static struct regulator_consumer_supply goni_ldo14_consumers[] = {
+	REGULATOR_SUPPLY("vdd_core", "0-0030"), /* "CAM_CIF_1.8V" */
+};
+
 static struct regulator_init_data goni_ldo2_data = {
 	.constraints	= {
 		.name		= "VALIVE_1.1V",

@@ -371,8 +383,10 @@ static struct regulator_init_data goni_ldo11_data = {
 		.min_uV		= 2800000,
 		.max_uV		= 2800000,
 		.apply_uV	= 1,
-		.always_on	= 1,
+		.valid_ops_mask	= REGULATOR_CHANGE_STATUS,
 	},
+	.num_consumer_supplies	= ARRAY_SIZE(goni_ldo11_consumers),
+	.consumer_supplies	= goni_ldo11_consumers,
 };
 
 static struct regulator_init_data goni_ldo12_data = {

@@ -391,8 +405,10 @@ static struct regulator_init_data goni_ldo13_data = {
 		.min_uV		= 2800000,
 		.max_uV		= 2800000,
 		.apply_uV	= 1,
-		.always_on	= 1,
+		.valid_ops_mask	= REGULATOR_CHANGE_STATUS,
 	},
+	.num_consumer_supplies	= ARRAY_SIZE(goni_ldo13_consumers),
+	.consumer_supplies	= goni_ldo13_consumers,
 };
 
 static struct regulator_init_data goni_ldo14_data = {

@@ -401,8 +417,10 @@ static struct regulator_init_data goni_ldo14_data = {
 		.min_uV		= 1800000,
 		.max_uV		= 1800000,
 		.apply_uV	= 1,
-		.always_on	= 1,
+		.valid_ops_mask	= REGULATOR_CHANGE_STATUS,
 	},
+	.num_consumer_supplies	= ARRAY_SIZE(goni_ldo14_consumers),
+	.consumer_supplies	= goni_ldo14_consumers,
 };
 
 static struct regulator_init_data goni_ldo15_data = {

Signature · 1 line

1.7.3.5

Kukjin Kim

2011-01-28 09:32 UTC #5 lore raw

PATCH 2/3 ARM: S5PV210: Add supplies for CIF camera on GONI board

Review

Quoted 10 lines · Sylwester Nawrocki

Add regulator supplies required for NOON010PC30 CIF sensor.
Signed-off-by Sylwester Nawrocki <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
 arch/arm/mach-s5pv210/mach-goni.c |   24 +++++++++++++++++++++---
 1 files changed, 21 insertions(+), 3 deletions(-)
(quoted diff) +0 -0

b/arch/arm/mach-s5pv210/mach-

arch/arm/mach-s5pv210/mach-goni.c static struct regulator_consumer_supply · line 279

Quoted 12 lines

goni.c
index fc34575..2051cee 100644

arch/arm/mach-s5pv210/mach-goni.c +3 -0

@@ -273,6 +273,18 @@ static struct regulator_consumer_supply
 goni_ldo5_consumers[] = {
 	REGULATOR_SUPPLY("vmmc", "s3c-sdhci.0"),
 };
 
+static struct regulator_consumer_supply goni_ldo11_consumers[] = {
+	REGULATOR_SUPPLY("vddio", "0-0030"), /* "CAM_IO_2.8V" */
+};

Need array in goni_ldo11_consumers?

+static struct regulator_consumer_supply goni_ldo11_consumers =
+ REGULATOR_SUPPLY("vddio", "0-0030"); /* "CAM_IO_2.8V" */

arch/arm/mach-s5pv210/mach-goni.c static struct regulator_consumer_supply goni_ldo5_consumers[] = { · line 282

Quoted 4 lines

arch/arm/mach-s5pv210/mach-goni.c +4 -0

+
+static struct regulator_consumer_supply goni_ldo13_consumers[] = {
+	REGULATOR_SUPPLY("vdda", "0-0030"), /* "CAM_A_2.8V" */
+};

Same above.

arch/arm/mach-s5pv210/mach-goni.c static struct regulator_consumer_supply goni_ldo5_consumers[] = { · line 286

Quoted 4 lines

arch/arm/mach-s5pv210/mach-goni.c +4 -0

+
+static struct regulator_consumer_supply goni_ldo14_consumers[] = {
+	REGULATOR_SUPPLY("vdd_core", "0-0030"), /* "CAM_CIF_1.8V" */
+};

Same above.

arch/arm/mach-s5pv210/mach-goni.c static struct regulator_init_data goni_ldo11_data = { · line 389

Quoted 13 lines

arch/arm/mach-s5pv210/mach-goni.c +1 -0

+
 static struct regulator_init_data goni_ldo2_data = {
 	.constraints	= {

arch/arm/mach-s5pv210/mach-goni.c +3 -1

 		.name		= "VALIVE_1.1V",

@@ -371,8 +383,10 @@ static struct regulator_init_data goni_ldo11_data = {
 		.min_uV		= 2800000,
 		.max_uV		= 2800000,
 		.apply_uV	= 1,
-		.always_on	= 1,
+		.valid_ops_mask	= REGULATOR_CHANGE_STATUS,
 	},
+	.num_consumer_supplies	= ARRAY_SIZE(goni_ldo11_consumers),
+	.consumer_supplies	= goni_ldo11_consumers,

If you modify as per my suggestion, then need to change this like following.

+ .num_consumer_supplies = 1,
+ .consumer_supplies = &goni_ldo11_consumers,

arch/arm/mach-s5pv210/mach-goni.c static struct regulator_init_data goni_ldo13_data = { · line 411

Quoted 12 lines

arch/arm/mach-s5pv210/mach-goni.c +3 -1

 };
 
 static struct regulator_init_data goni_ldo12_data = {

@@ -391,8 +405,10 @@ static struct regulator_init_data goni_ldo13_data = {
 		.min_uV		= 2800000,
 		.max_uV		= 2800000,
 		.apply_uV	= 1,
-		.always_on	= 1,
+		.valid_ops_mask	= REGULATOR_CHANGE_STATUS,
 	},
+	.num_consumer_supplies	= ARRAY_SIZE(goni_ldo13_consumers),
+	.consumer_supplies	= goni_ldo13_consumers,

Same above.

arch/arm/mach-s5pv210/mach-goni.c static struct regulator_init_data goni_ldo14_data = { · line 423

Quoted 12 lines

arch/arm/mach-s5pv210/mach-goni.c +3 -1

 };
 
 static struct regulator_init_data goni_ldo14_data = {

@@ -401,8 +417,10 @@ static struct regulator_init_data goni_ldo14_data = {
 		.min_uV		= 1800000,
 		.max_uV		= 1800000,
 		.apply_uV	= 1,
-		.always_on	= 1,
+		.valid_ops_mask	= REGULATOR_CHANGE_STATUS,
 	},
+	.num_consumer_supplies	= ARRAY_SIZE(goni_ldo14_consumers),
+	.consumer_supplies	= goni_ldo14_consumers,

Same above.

Quoted 5 lines

arch/arm/mach-s5pv210/mach-goni.c +0 -1
 };
 
 static struct regulator_init_data goni_ldo15_data = {
--
1.7.3.5

If required array in there, please let me know.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

Kyungmin Park

2011-01-28 10:53 UTC #6 lore raw

PATCH 2/3 ARM: S5PV210: Add supplies for CIF camera on GONI board

Quoted 21 lines · Kukjin Kim

Review
Quoted 10 lines · Sylwester Nawrocki
Add regulator supplies required for NOON010PC30 CIF sensor.
Signed-off-by Sylwester Nawrocki <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
?arch/arm/mach-s5pv210/mach-goni.c | ? 24 +++++++++++++++++++++--- ?1 files changed, 21 insertions(+), 3 deletions(-)
(quoted diff) +0 -0
b/arch/arm/mach-s5pv210/mach-
Quoted 9 lines
goni.c
index fc34575..2051cee 100644
arch/arm/mach-s5pv210/mach-goni.c +0 -0
@@ -273,6 +273,18 @@ static struct regulator_consumer_supply
 goni_ldo5_consumers[] = {
 ? ? ? REGULATOR_SUPPLY("vmmc", "s3c-sdhci.0"),
 ?};
 

Quoted 5 lines

arch/arm/mach-s5pv210/mach-goni.c static struct regulator_consumer_supply goni_ldo5_consumers[] = { · line 278
Quoted 3 lines
arch/arm/mach-s5pv210/mach-goni.c +3 -0
+static struct regulator_consumer_supply goni_ldo11_consumers[] = {
+ ? ? REGULATOR_SUPPLY("vddio", "0-0030"), /* "CAM_IO_2.8V" */
+};
Need array in goni_ldo11_consumers?

Yes, it's required for consistency and most consumers use this style.

Look smdk board file
http://git.kernel.org/?p=linux/kernel/git/kgene/linux-samsung.git;a=blob;f=arch/arm/mach-s3c64xx/mach-smdk6410.c;h=e85192a86fbe1a9f51bb9da15f20899bf0b4ab3e;hb=refs/heads/for-next

303 #ifdef CONFIG_REGULATOR
304 /* ARM core */
305 static struct regulator_consumer_supply smdk6410_vddarm_consumers[] = {
306 {
307 .supply = "vddarm",
308 }
309 };
310
311 /* VDDARM, BUCK1 on J5 */
312 static struct regulator_init_data smdk6410_vddarm = {
313 .constraints = {

 314                 .name = "PVDD_ARM",
 315                 .min_uV = 1000000,
 316                 .max_uV = 1300000,
 317                 .always_on = 1,
 318                 .valid_ops_mask = REGULATOR_CHANGE_VOLTAGE,
 319         },
 320         .num_consumer_supplies = ARRAY_SIZE(smdk6410_vddarm_consumers),
 321         .consumer_supplies = smdk6410_vddarm_consumers,

322 };

Quoted 18 lines

+static struct regulator_consumer_supply goni_ldo11_consumers =
+ ? ? ? REGULATOR_SUPPLY("vddio", "0-0030"); /* "CAM_IO_2.8V" */
arch/arm/mach-s5pv210/mach-goni.c static struct regulator_consumer_supply goni_ldo5_consumers[] = { · line 282
Quoted 4 lines
arch/arm/mach-s5pv210/mach-goni.c +4 -0
+
+static struct regulator_consumer_supply goni_ldo13_consumers[] = {
+ ? ? REGULATOR_SUPPLY("vdda", "0-0030"), /* "CAM_A_2.8V" */
+};
Same above.
arch/arm/mach-s5pv210/mach-goni.c static struct regulator_consumer_supply goni_ldo5_consumers[] = { · line 286
Quoted 4 lines
arch/arm/mach-s5pv210/mach-goni.c +4 -0
+
+static struct regulator_consumer_supply goni_ldo14_consumers[] = {
+ ? ? REGULATOR_SUPPLY("vdd_core", "0-0030"), /* "CAM_CIF_1.8V" */
+};
Same above.

Quoted 15 lines

arch/arm/mach-s5pv210/mach-goni.c static struct regulator_init_data goni_ldo11_data = { · line 389
Quoted 13 lines
arch/arm/mach-s5pv210/mach-goni.c +1 -0
+
 ?static struct regulator_init_data goni_ldo2_data = {
 ? ? ? .constraints ? ?= {
? ? ? ? ? ? ? .name ? ? ? ? ? = "VALIVE_1.1V",
arch/arm/mach-s5pv210/mach-goni.c +3 -1
@@ -371,8 +383,10 @@ static struct regulator_init_data goni_ldo11_data = {
 ? ? ? ? ? ? ? .min_uV ? ? ? ? = 2800000,
 ? ? ? ? ? ? ? .max_uV ? ? ? ? = 2800000,
 ? ? ? ? ? ? ? .apply_uV ? ? ? = 1,
- ? ? ? ? ? ? .always_on ? ? ?= 1,
+ ? ? ? ? ? ? .valid_ops_mask = REGULATOR_CHANGE_STATUS,
 ? ? ? },
+ ? ? .num_consumer_supplies ?= ARRAY_SIZE(goni_ldo11_consumers),
+ ? ? .consumer_supplies ? ? ?= goni_ldo11_consumers,
If you modify as per my suggestion, then need to change this like following.

Same, I want to use the same style even though it has one consumer. and If it has one consumer, ARRAY_SIZE(some_consumers) has 1 at compile time.

Quoted 55 lines

+ ? ? ? .num_consumer_supplies ?= 1,
+ ? ? ? .consumer_supplies ? ? ?= &goni_ldo11_consumers,
arch/arm/mach-s5pv210/mach-goni.c static struct regulator_init_data goni_ldo13_data = { · line 411
Quoted 12 lines
arch/arm/mach-s5pv210/mach-goni.c +3 -1
 ?};
 
 ?static struct regulator_init_data goni_ldo12_data = {
@@ -391,8 +405,10 @@ static struct regulator_init_data goni_ldo13_data = {
 ? ? ? ? ? ? ? .min_uV ? ? ? ? = 2800000,
 ? ? ? ? ? ? ? .max_uV ? ? ? ? = 2800000,
 ? ? ? ? ? ? ? .apply_uV ? ? ? = 1,
- ? ? ? ? ? ? .always_on ? ? ?= 1,
+ ? ? ? ? ? ? .valid_ops_mask = REGULATOR_CHANGE_STATUS,
 ? ? ? },
+ ? ? .num_consumer_supplies ?= ARRAY_SIZE(goni_ldo13_consumers),
+ ? ? .consumer_supplies ? ? ?= goni_ldo13_consumers,
Same above.
arch/arm/mach-s5pv210/mach-goni.c static struct regulator_init_data goni_ldo14_data = { · line 423
Quoted 12 lines
arch/arm/mach-s5pv210/mach-goni.c +3 -1
 ?};
 
 ?static struct regulator_init_data goni_ldo14_data = {
@@ -401,8 +417,10 @@ static struct regulator_init_data goni_ldo14_data = {
 ? ? ? ? ? ? ? .min_uV ? ? ? ? = 1800000,
 ? ? ? ? ? ? ? .max_uV ? ? ? ? = 1800000,
 ? ? ? ? ? ? ? .apply_uV ? ? ? = 1,
- ? ? ? ? ? ? .always_on ? ? ?= 1,
+ ? ? ? ? ? ? .valid_ops_mask = REGULATOR_CHANGE_STATUS,
 ? ? ? },
+ ? ? .num_consumer_supplies ?= ARRAY_SIZE(goni_ldo14_consumers),
+ ? ? .consumer_supplies ? ? ?= goni_ldo14_consumers,
Same above.
Quoted 5 lines
arch/arm/mach-s5pv210/mach-goni.c +0 -1
 ?};
 
 ?static struct regulator_init_data goni_ldo15_data = {
--
1.7.3.5
If required array in there, please let me know.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo at vger.kernel.org
More majordomo info at ?http://vger.kernel.org/majordomo-info.html

Sylwester Nawrocki

2011-01-28 11:49 UTC #7 lore raw

PATCH 2/3 ARM: S5PV210: Add supplies for CIF camera on GONI board

In reply to Kukjin Kim

Quoted 31 lines · Kukjin Kim

Review
Quoted 10 lines · Sylwester Nawrocki
Add regulator supplies required for NOON010PC30 CIF sensor.
Signed-off-by Sylwester Nawrocki<[email protected]>
Signed-off-by Kyungmin Park<[email protected]>
---
  arch/arm/mach-s5pv210/mach-goni.c |   24 +++++++++++++++++++++---
  1 files changed, 21 insertions(+), 3 deletions(-)
(quoted diff) +0 -0
b/arch/arm/mach-s5pv210/mach-
arch/arm/mach-s5pv210/mach-goni.c static struct regulator_consumer_supply · line 279
Quoted 12 lines
goni.c
index fc34575..2051cee 100644
arch/arm/mach-s5pv210/mach-goni.c +3 -0
@@ -273,6 +273,18 @@ static struct regulator_consumer_supply
 goni_ldo5_consumers[] = {
  	REGULATOR_SUPPLY("vmmc", "s3c-sdhci.0"),
  };
 
+static struct regulator_consumer_supply goni_ldo11_consumers[] = {
+	REGULATOR_SUPPLY("vddio", "0-0030"), /* "CAM_IO_2.8V" */
+};
Need array in goni_ldo11_consumers?
(quoted diff) +2 -0
+static struct regulator_consumer_supply goni_ldo11_consumers =
+	REGULATOR_SUPPLY("vddio", "0-0030"); /* "CAM_IO_2.8V" */
Quoted 2 lines
arch/arm/mach-s5pv210/mach-goni.c +1 -0
+

...

Quoted 19 lines

arch/arm/mach-s5pv210/mach-goni.c static struct regulator_init_data goni_ldo11_data = { · line 389

Quoted 13 lines

arch/arm/mach-s5pv210/mach-goni.c +4 -1

+
  static struct regulator_init_data goni_ldo2_data = {
  	.constraints	= {
  		.name		= "VALIVE_1.1V",

@@ -371,8 +383,10 @@ static struct regulator_init_data goni_ldo11_data = {
  		.min_uV		= 2800000,
  		.max_uV		= 2800000,
  		.apply_uV	= 1,
-		.always_on	= 1,
+		.valid_ops_mask	= REGULATOR_CHANGE_STATUS,
  	},
+	.num_consumer_supplies	= ARRAY_SIZE(goni_ldo11_consumers),
+	.consumer_supplies	= goni_ldo11_consumers,

If you modify as per my suggestion, then need to change this like following.

(quoted diff) +2 -0

+	.num_consumer_supplies	= 1,
+	.consumer_supplies	=&goni_ldo11_consumers,

Quoted 1 line

arch/arm/mach-s5pv210/mach-goni.c static struct regulator_init_data goni_ldo11_data = { · line 390
Quoted 1 line
arch/arm/mach-s5pv210/mach-goni.c +0 -0
  };

Although the current state of this file is not reflecting it, there is more devices sharing the regulators I've added supply definitions for, e.g the second camera in the system.
So the arrays are really needed. If I modify it as you as you are suggesting then it will have to be changed when the other supplies are added.

Thanks,
Sylwester

Sylwester Nawrocki

author

2011-01-07 16:57 UTC #8 lore raw

PATCH 3/3 ARM: S5PV210: Change framebuffer window 0 size on GONI

In reply to Sylwester Nawrocki

Increase virtual size of the frambuffer window 0
for the display panning support.

Signed-off-by Sylwester Nawrocki <[email protected]>

Signed-off-by Kyungmin Park <[email protected]>

---
 arch/arm/mach-s5pv210/mach-goni.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

arch/arm/mach-s5pv210/mach-goni.c +2 -0

index 2051cee..ed06f20 100644
@@ -108,6 +108,8 @@ static struct s3c_fb_pd_win goni_fb_win0 = {
 	},
 	.max_bpp	= 32,
 	.default_bpp	= 16,
+	.virtual_x	= 480,
+	.virtual_y	= 2 * 800,
 };
 
 static struct s3c_fb_platdata goni_lcd_pdata __initdata = {

Signature · 1 line

1.7.3.5

Kukjin Kim

2011-01-28 09:35 UTC #9 lore raw

PATCH 3/3 ARM: S5PV210: Change framebuffer window 0 size on GONI

Review

Quoted 11 lines · Sylwester Nawrocki

Increase virtual size of the frambuffer window 0
for the display panning support.
Signed-off-by Sylwester Nawrocki <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
 arch/arm/mach-s5pv210/mach-goni.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
(quoted diff) +0 -0

b/arch/arm/mach-s5pv210/mach-

Quoted 14 lines

goni.c
index 2051cee..ed06f20 100644

arch/arm/mach-s5pv210/mach-goni.c +2 -1

@@ -108,6 +108,8 @@ static struct s3c_fb_pd_win goni_fb_win0 = {
 	},
 	.max_bpp	= 32,
 	.default_bpp	= 16,
+	.virtual_x	= 480,
+	.virtual_y	= 2 * 800,
 };
 
 static struct s3c_fb_platdata goni_lcd_pdata __initdata = {
--

Quoted 1 line

1.7.3.5

Looks ok...but I want to apply with your other 1/3 and 2/3 patches. Will apply this after getting your other patches.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

Sylwester Nawrocki

2011-01-26 12:52 UTC #10 lore raw

PATCH 1/1 ARM: S5PV210: Add GONI board setup for CIF camera support

In reply to Sylwester Nawrocki

Hello,

Quoted 9 lines · Sylwester Nawrocki

Hello,
the following patch series introduces changes in GONI board setup file required for the CIF camera sensor driver.
The first patch adds the I2C0 bus driver, the second one adds the regulator supply definitions and the third one just increases virtual size of the framebuffer window 0 for preview double buffering.

Quoted 9 lines

The patch series contains:
[PATCH 1/3] ARM: S5PV210: Enable I2C0 bus on GONI board [PATCH 2/3] ARM: S5PV210: Add supplies for CIF camera on GONI board [PATCH 3/3] ARM: S5PV210: Change framebuffer window 0 size on GONI
Created against kgene-for-next branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git

Any comments about these patches?

Regards,
Sylwester