Skip to contentSkip to conversation

gdk-pixbuf: add jpeg into DEPENDS

GIT PULL Dexuan Cui 3 participants 6 messages Jan 30, 2011 – Jan 31, 2011

lore
Share & tools
lore
author
#1 lore raw

From: Dexuan Cui <[email protected]>

This fixes the following error:

| checking for jpeg_destroy_decompress in -ljpeg... no
| configure: WARNING: *** JPEG loader will not be built (JPEG library not found) ***
| configure: error:
| *** Checks for JPEG loader failed. You can build without it by passing
| *** --without-libjpeg to configure but some programs using GTK+ may
| *** not work properly
| FATAL: oe_runconf failed
---
 meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.22.1.bb |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.22.1.bb +2 -0
index ae57507..8080719 100644
@@ -1,5 +1,7 @@
 require gdk-pixbuf.inc
 
+DEPENDS += "jpeg"
+
 PR = "r0"
 
 FILES_${PN} = "${bindir}/gdk-pixbuf-query-loaders \
Signature · 1 line
1.7.2
#2 lore raw
In reply to Dexuan Cui

Op 30 jan 2011, om 16:06 heeft Dexuan Cui het volgende geschreven:

Quoted 3 lines

From: Dexuan Cui <[email protected]>

meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.22.1.bb | 2 ++

OE is using BBCLASS_EXTEND in gtk+ to provide the pixbug loaders, doing this in yocto would reduce duplicate functionality a lot.

regards,

Koen

#3 lore raw
Quoted 8 lines · Koen Kooi

Op 30 jan 2011, om 16:06 heeft Dexuan Cui het volgende geschreven:

Quoted 3 lines

From: Dexuan Cui <[email protected]>

meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.22.1.bb | 2 ++

OE is using BBCLASS_EXTEND in gtk+ to provide the pixbug loaders, doing this in yocto would reduce duplicate functionality a lot.

Hi Koen,
I think you meant in Poky whether we could add BBCLASSEXTEND = "native" into gdk-pixbuf_2.22.1.bb and remove gdk-pixbuf-native_2.22.1.bb. The two recipes look quite different so I doubt we can do that. Let me Cc the original patch submitter Edwin for the background.

Thanks,
-- Dexuan

#4 lore raw

Koen,

The gtk+ on OE is not latest version, that is, gdk-pixbuf is still part of it. I think the function is not clear-cut.

On poky, gtk+ is latest stable version, where gdk-pxibuf is separated as a stand-alone bb file. Running of gdk-pixbuf-csource need one config file produced by gdk-pixbuf-query-loaders, so native and target packages' installation are different. Target package need postinst to run it when 1st boot, while native package need install_append to run it before populate_sysroot.

Does it make sense? Is there any way to avoid duplicatation?

Thanks,
edwin

Quoted 18 lines · Dexuan
Quoted 8 lines · Koen Kooi

Op 30 jan 2011, om 16:06 heeft Dexuan Cui het volgende geschreven:

Quoted 3 lines

From: Dexuan Cui <[email protected]>

meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.22.1.bb | 2 ++

OE is using BBCLASS_EXTEND in gtk+ to provide the pixbug loaders, doing this in yocto would reduce duplicate functionality a lot.

Hi Koen,
I think you meant in Poky whether we could add BBCLASSEXTEND = "native" into gdk-pixbuf_2.22.1.bb and remove gdk-pixbuf-native_2.22.1.bb.

The two recipes look quite different so I doubt we can do that. Let me Cc the original patch submitter Edwin for the background.

Thanks,
-- Dexuan

#5 lore raw

Op 31 jan 2011, om 08:24 heeft Zhai, Edwin het volgende geschreven:

Quoted 7 lines

Koen,

The gtk+ on OE is not latest version, that is, gdk-pixbuf is still part of it. I think the function is not clear-cut.

On poky, gtk+ is latest stable version, where gdk-pxibuf is separated as a stand-alone bb file. Running of gdk-pixbuf-csource need one config file produced by gdk-pixbuf-query-loaders, so native and target packages' installation are different. Target package need postinst to run it when 1st boot, while native package need install_append to run it before populate_sysroot.

Does it make sense? Is there any way to avoid duplicatation?

I just read up on gdk-pixbuf an noticed it was split out again of gtk+ like you said :) So using BBCLASS_EXTEND in the gdk-pixbuf recipe would seem the way to go.

regards,

Koen

Quoted 24 lines

Thanks,
edwin

Quoted 18 lines · Dexuan
Quoted 8 lines · Koen Kooi

Op 30 jan 2011, om 16:06 heeft Dexuan Cui het volgende geschreven:

Quoted 3 lines

From: Dexuan Cui <[email protected]>

meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.22.1.bb | 2 ++

OE is using BBCLASS_EXTEND in gtk+ to provide the pixbug loaders, doing this in yocto would reduce duplicate functionality a lot.

Hi Koen,
I think you meant in Poky whether we could add BBCLASSEXTEND = "native" into gdk-pixbuf_2.22.1.bb and remove gdk-pixbuf-native_2.22.1.bb.

The two recipes look quite different so I doubt we can do that. Let me Cc the original patch submitter Edwin for the background.

Thanks,
-- Dexuan