Skip to contentSkip to conversation

t5526: Fix wrong argument order in "git config"

PATCH In review Jens Lehmann 2 participants 2 messages Jun 15, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 t5526: Fix wrong argument order in "git config"

This fixes a typo where the "git config" arguments "-f" and "--unset" were swapped leading to the creation of a "--unset" file.

---

Now that 1.7.4 is out and somebody else already stumbled across this typo I introduced ...

 t/t5526-fetch-submodules.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
t/t5526-fetch-submodules.sh +1 -1
index 884a5e5..a5f4585 100755
@@ -124,7 +124,7 @@ test_expect_success "--recurse-submodules overrides fetchRecurseSubmodules setti
 	(
 		cd downstream &&
 		git fetch --recurse-submodules >../actual.out 2>../actual.err &&
-		git config -f --unset .gitmodules submodule.submodule.fetchRecurseSubmodules true &&
+		git config --unset -f .gitmodules submodule.submodule.fetchRecurseSubmodules &&
 		git config --unset submodule.submodule.fetchRecurseSubmodules
 	) &&
 	test_cmp expect.out actual.out &&
Signature · 1 line
1.7.3.4.27.g3921d.dirty
#1 lore raw
Quoted 8 lines · Jens Lehmann

This fixes a typo where the "git config" arguments "-f" and "--unset" were swapped leading to the creation of a "--unset" file.

---

Now that 1.7.4 is out and somebody else already stumbled across this typo I introduced ...

Thanks.

Quoted 19 lines
 t/t5526-fetch-submodules.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
t/t5526-fetch-submodules.sh +1 -1
index 884a5e5..a5f4585 100755
@@ -124,7 +124,7 @@ test_expect_success "--recurse-submodules overrides fetchRecurseSubmodules setti
 	(
 		cd downstream &&
 		git fetch --recurse-submodules >../actual.out 2>../actual.err &&
-		git config -f --unset .gitmodules submodule.submodule.fetchRecurseSubmodules true &&
+		git config --unset -f .gitmodules submodule.submodule.fetchRecurseSubmodules &&
 		git config --unset submodule.submodule.fetchRecurseSubmodules
 	) &&
 	test_cmp expect.out actual.out &&
Signature · 1 line
1.7.3.4.27.g3921d.dirty