Skip to contentSkip to conversation

Missing config_hw() in ieee80211_ibss_join?

DISCUSSION Ben Greear 2 participants 3 messages Jan 31, 2011

lore
Share & tools
lore

Ben Greear

author
#0 lore raw

The method ieee80211_ibss_join can change the operating channel, but I don't see anywhere that it calls config_hw to flush the changes into the kernel.

Should we add such a call?

This was found by code inspection...I didn't actually try using this code...

Thanks,
Ben

Signature · 2 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com
#1 lore raw
Quoted 5 lines · Ben Greear

The method ieee80211_ibss_join can change the operating channel, but I don't see anywhere that it calls config_hw to flush the changes into the kernel.

Should we add such a call?

I don't think so -- it doesn't actually really join until it has scanned first etc.?

johannes

author
#2 lore raw
Quoted 9 lines · Johannes Berg
Quoted 5 lines · Ben Greear

The method ieee80211_ibss_join can change the operating channel, but I don't see anywhere that it calls config_hw to flush the changes into the kernel.

Should we add such a call?

I don't think so -- it doesn't actually really join until it has scanned first etc.?

Ok, good enough for me. I don't think this will cause any problems with my scan-on-channel logic, but it looked a bit strange while I was auditing the oper-channel related code.

Thanks,
Ben

Signature · 2 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com