Skip to contentSkip to conversation

KVM: x86: Drop obsolete warning about INIT on runnable VCPU

PATCH Applied Jan Kiszka 2 participants 2 messages Feb 1, 2011 – Feb 3, 2011

Subsystems (3)
x86 KVM KVM x86
lore
Share & tools
lore

Jan Kiszka

author
#0 lore raw

PATCH 1/1 KVM: x86: Drop obsolete warning about INIT on runnable VCPU

This warning was once used for debugging QEMU user space. Though uncommon, it is actually possible to send an INIT request to a running VCPU. So better drop this warning before someone misuses it to flood kernel logs this way.

Signed-off-by Jan Kiszka <[email protected]>
---
 arch/x86/kvm/lapic.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
arch/x86/kvm/lapic.c +0 -4
index 93cf9d0..0171e66 100644
@@ -417,10 +417,6 @@ static int __apic_accept_irq(struct kvm_lapic *apic, int delivery_mode,
 	case APIC_DM_INIT:
 		if (level) {
 			result = 1;
-			if (vcpu->arch.mp_state == KVM_MP_STATE_RUNNABLE)
-				printk(KERN_DEBUG
-				       "INIT on a runnable vcpu %d\n",
-				       vcpu->vcpu_id);
 			vcpu->arch.mp_state = KVM_MP_STATE_INIT_RECEIVED;
 			kvm_make_request(KVM_REQ_EVENT, vcpu);
 			kvm_vcpu_kick(vcpu);
Signature · 1 line
1.7.1
Applied
#1 lore raw
Quoted 9 lines · Jan Kiszka

This warning was once used for debugging QEMU user space. Though uncommon, it is actually possible to send an INIT request to a running VCPU. So better drop this warning before someone misuses it to flood kernel logs this way.

Signed-off-by Jan Kiszka <[email protected]>
---
 arch/x86/kvm/lapic.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

Applied, thanks.