Skip to contentSkip to conversation

PR and .bbappend

DISCUSSION Gary Thomas 4 participants 4 messages Feb 2, 2011

lore
Share & tools
lore
#0 lore raw

Should .bbappend files have a PR in them? If so, must it match the one in the main .bb file?

Signature · 4 lines
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------
#1 lore raw
Quoted 2 lines · Gary Thomas

Should .bbappend files have a PR in them?  If so, must it match the one in the main .bb file?

All metadata in a .bbappend is essentially concatenated to the recipe.
If you define PR in the .bbappend, it will override the one in the
recipe, which is unlikely what you want, as that loses information. The better route is to do something like PR .= ".1" in the .bbappend, and bump that when changing the bbappend file.

Signature · 5 lines
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
#2 lore raw
Quoted 9 lines · Chris Larson
Quoted 2 lines · Gary Thomas

Should .bbappend files have a PR in them? If so, must it match the one in the main .bb file?

All metadata in a .bbappend is essentially concatenated to the recipe.
If you define PR in the .bbappend, it will override the one in the
recipe, which is unlikely what you want, as that loses information. The better route is to do something like PR .= ".1" in the .bbappend, and bump that when changing the bbappend file.

I was going to suggest the same thing. A good approach is to append a value to the existing PR. (I suggest this get added as a best practice in the documentation on bbappend... I'm not sure who the correct person is to point this out to though.)

--Mark

#3 lore raw
Quoted 11 lines · Mark Hatle
Quoted 9 lines · Chris Larson
Quoted 2 lines · Gary Thomas

Should .bbappend files have a PR in them? If so, must it match the one in the main .bb file?

All metadata in a .bbappend is essentially concatenated to the recipe.
If you define PR in the .bbappend, it will override the one in the
recipe, which is unlikely what you want, as that loses information. The better route is to do something like PR .= ".1" in the .bbappend, and bump that when changing the bbappend file.

Quoted 4 lines

I was going to suggest the same thing. A good approach is to append a value to the existing PR. (I suggest this get added as a best practice in the documentation on bbappend... I'm not sure who the correct person is to point this out to though.)

That would be Scott R, on CC.

Quoted 6 lines

--Mark
_______________________________________________
poky mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/poky

Signature · 3 lines
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel