arm: mach-omap2: board-rm680: fix rm680_vemmc regulator constraints

PATCH New Aaro Koskinen 4 participants 4 messages Feb 1, 2011 – Feb 4, 2011

Subsystems (3)

Arm (32-bit) Arm sub-architectures OMAP2+ support

lore

Share & tools

lore

Aaro Koskinen

author

2011-02-01 15:34 UTC #0 lore raw

PATCH 1/1 arm: mach-omap2: board-rm680: fix rm680_vemmc regulator constraints

With the commit 757902513019e6ee469791ff76f954b19ca8d036 fixed voltage regulator setup will fail if there are voltage constraints defined. This made MMC unusable on this board. Fix by just deleting those redundant constraints.

Signed-off-by Aaro Koskinen <[email protected]>

---
 arch/arm/mach-omap2/board-rm680.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

arch/arm/mach-omap2/board-rm680.c +0 -3

index cb77be7..39a71bb 100644
@@ -40,9 +40,6 @@ static struct regulator_consumer_supply rm680_vemmc_consumers[] = {
 static struct regulator_init_data rm680_vemmc = {
 	.constraints =	{
 		.name			= "rm680_vemmc",
-		.min_uV			= 2900000,
-		.max_uV			= 2900000,
-		.apply_uV		= 1,
 		.valid_modes_mask	= REGULATOR_MODE_NORMAL
 					| REGULATOR_MODE_STANDBY,
 		.valid_ops_mask		= REGULATOR_CHANGE_STATUS

Signature · 1 line

1.5.6.5

Jarkko Nikula

2011-02-01 18:27 UTC #1 lore raw

PATCH 1/1 arm: mach-omap2: board-rm680: fix rm680_vemmc regulator constraints

Quoted 5 lines · On Tue, 1 Feb 2011 17:36:28 +0200 Aaro Koskinen <[email protected]>…

With the commit 757902513019e6ee469791ff76f954b19ca8d036 fixed voltage regulator setup will fail if there are voltage constraints defined. This made MMC unusable on this board. Fix by just deleting those redundant constraints.

True. Before there were a test min_uV == max_uV && ops->set_voltage and now min_uV == max_uV followed by test for ops->set_voltage that returns EINVAL if not set (NULL for fixed voltage regulator obviously).

Reviewed-by Jarkko Nikula <[email protected]>

Tony Lindgren

maintainer

2011-02-01 23:52 UTC #2 lore raw

PATCH 1/1 arm: mach-omap2: board-rm680: fix rm680_vemmc regulator constraints

Quoted 8 lines · Jarkko Nikula

Quoted 5 lines · On Tue, 1 Feb 2011 17:36:28 +0200 Aaro Koskinen <[email protected]>…
With the commit 757902513019e6ee469791ff76f954b19ca8d036 fixed voltage regulator setup will fail if there are voltage constraints defined. This made MMC unusable on this board. Fix by just deleting those redundant constraints.

Quoted 5 lines

True. Before there were a test min_uV == max_uV && ops->set_voltage and now min_uV == max_uV followed by test for ops->set_voltage that returns EINVAL if not set (NULL for fixed voltage regulator obviously).
Reviewed-by Jarkko Nikula <[email protected]>

Thanks adding into devel-fixes.

Tony

Sergei Shtylyov

2011-02-04 13:31 UTC #3 lore raw

PATCH 1/1 arm: mach-omap2: board-rm680: fix rm680_vemmc regulator constraints

In reply to Aaro Koskinen

Hello.

Quoted 1 line · Aaro Koskinen

With the commit 757902513019e6ee469791ff76f954b19ca8d036 fixed voltage

Please also specify the commit summary in parens, as asked by Linus.

Quoted 5 lines

regulator setup will fail if there are voltage constraints defined. This made MMC unusable on this board. Fix by just deleting those redundant constraints.
Signed-off-by Aaro Koskinen<[email protected]>

WBR, Sergei