Skip to contentSkip to conversation

x86, pci: early dump skip device the same way as later probe code

PATCH New Yinghai Lu 1 participant 1 message Feb 7, 2011

Subsystems (2)
x86 PCI
lore
Share & tools
lore

Yinghai Lu

author
#0 lore raw

PATCH 1/1 x86, pci: early dump skip device the same way as later probe code

Use VENDOR_ID instead of CLASS_REVISION.

Do have one system with 0x00ffffff CLASS_REVSION

Signed-off-by Yinghai Lu <[email protected]>
---
 arch/x86/pci/early.c |   13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)
arch/x86/pci/early.c +9 -4
Index: linux-2.6/arch/x86/pci/early.c
===================================================================
@@ -88,12 +88,17 @@ void early_dump_pci_devices(void)
 	for (bus = 0; bus < 256; bus++) {
 		for (slot = 0; slot < 32; slot++) {
 			for (func = 0; func < 8; func++) {
-				u32 class;
+				u32 l;
 				u8 type;
 
-				class = read_pci_config(bus, slot, func,
-							PCI_CLASS_REVISION);
-				if (class == 0xffffffff)
+				l = read_pci_config(bus, slot, func,
+							PCI_VENDOR_ID);
+				/*
+				 * some broken boards return 0 or ~0 if a slot
+				 *  is empty
+				 */
+				if (l == 0xffffffff || l == 0x00000000 ||
+				    l == 0x0000ffff || l == 0xffff0000)
 					continue;
 
 				early_dump_pci_device(bus, slot, func);