Skip to contentSkip to conversation

cleanup() should not be called before setup() in cases dup3_01 and eventfd2_01

PATCH In review Peng Haitao 2 participants 2 messages Feb 14, 2011

lore
Share & tools
lore

Peng Haitao

author
#0 lore raw

PATCH 1/1 cleanup() should not be called before setup() in cases dup3_01 and eventfd2_01

Hi Garrett,

Signed-off-by Peng Haitao <[email protected]>
---
 testcases/kernel/syscalls/dup3/dup3_01.c         |    4 ++--
 testcases/kernel/syscalls/eventfd2/eventfd2_01.c |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
testcases/kernel/syscalls/dup3/dup3_01.c +2 -2
index c95e79a..a0f1d63 100644
@@ -126,7 +126,7 @@ int main(int argc, char *argv[])
 	int fd, coe;
 
 	if ((tst_kvercmp(2, 6, 27)) < 0)
-		tst_brkm(TCONF, cleanup,
+		tst_brkm(TCONF, NULL,
 			 "This test can only run on kernels that are 2.6.27 and higher");
 	setup();
 

@@ -161,4 +161,4 @@ int main(int argc, char *argv[])
 
 	cleanup();
 	tst_exit();
-}
\ No newline at end of file
+}
testcases/kernel/syscalls/eventfd2/eventfd2_01.c +2 -2
index 38f2ed0..0e87e85 100644
@@ -133,7 +133,7 @@ int main(int argc, char *argv[])
 	int fd, coe;
 
 	if ((tst_kvercmp(2, 6, 27)) < 0) {
-		tst_brkm(TCONF, cleanup,
+		tst_brkm(TCONF, NULL,
 		    "This test can only run on kernels that are 2.6.27 and higher");
 	}
 	setup();

@@ -167,4 +167,4 @@ int main(int argc, char *argv[])
 	tst_resm(TPASS, "eventfd2(EFD_CLOEXEC) Passed");
 	cleanup();
 	tst_exit();
-}
\ No newline at end of file
+}
Signature · 17 lines
1.7.3.1

-- 
Best Regards,
Peng Haitao


------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
#1 lore raw
Quoted 3 lines · Peng Haitao

Hi Garrett,

Signed-off-by Peng Haitao <[email protected]>

Committed -- thanks!
-Garrett

------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list