DM9000B: Fix reg_save after spin_lock in dm9000_timeout

PATCH In review Henry Nestler 1 participant 1 message Feb 20, 2011

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Henry Nestler

author

2011-02-20 21:45 UTC #0 lore raw

PATCH 1/2 DM9000B: Fix reg_save after spin_lock in dm9000_timeout

The spin_lock should hold before reading register.
---
Kernel version 2.6.38-rc5

 drivers/net/dm9000.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

drivers/net/dm9000.c +1 -1

index 2d4c4fc..2bbd496 100644
@@ -852,8 +852,8 @@ static void dm9000_timeout(struct net_device *dev)
 	unsigned long flags;
 
 	/* Save previous register address */
-	reg_save = readb(db->io_addr);
 	spin_lock_irqsave(&db->lock, flags);
+	reg_save = readb(db->io_addr);
 
 	netif_stop_queue(dev);
 	dm9000_reset(db);