Skip to contentSkip to conversation

Fix BUG 472

GIT PULL New Dongxiao Xu 2 participants 3 messages Feb 17, 2011 – Feb 22, 2011

lore
Share & tools
lore
#0 lore raw

From: Dongxiao Xu <[email protected]>

This pull request fixes [BUGID #472], please help to review and pull.

User may still need to configure network even if all the services are not available currently, for example, setting online/offline mode, etc.

Enable the applet pop up menu even if the service status is unavailable.

Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: dxu4/bugfix
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dxu4/bugfix

Thanks,
Dongxiao Xu <[email protected]>
---

Dongxiao Xu (1):
connman-gnome: Enable config menu popup even services are not
available

 .../connman-gnome/applet_menu_popup_fix.patch      |   19 +++++++++++++++++++
 .../connman/connman-gnome_0.5.bb                   |    5 +++--
 2 files changed, 22 insertions(+), 2 deletions(-)
 create mode 100644 meta/recipes-connectivity/connman/connman-gnome/applet_menu_popup_fix.patch
#1 lore raw

PATCH 1/1 connman-gnome: Enable config menu popup even services are not available

From: Dongxiao Xu <[email protected]>

User may still want to configure networks even if current services are not available, for example, set online/offline mode, etc.

Enable the popup menu even if the status is unavailable.

This fixes [BUGID #472]

---
 .../connman-gnome/applet_menu_popup_fix.patch      |   19 +++++++++++++++++++
 .../connman/connman-gnome_0.5.bb                   |    5 +++--
 2 files changed, 22 insertions(+), 2 deletions(-)
 create mode 100644 meta/recipes-connectivity/connman/connman-gnome/applet_menu_popup_fix.patch
meta/recipes-connectivity/connman/connman-gnome/applet_menu_popup_fix.patch new file +19 -0
new file mode 100644
index 0000000..d34257b
@@ -0,0 +1,19 @@
+Even if all services are not available, we still need to let user have
+the ability to configure network, for example, online/offline, etc.
+Therefore enable the callback menu even when status is unavailable.
+
+Signed-off-by: Dongxiao Xu <[email protected]>
+
+diff --git a/applet/status.c b/applet/status.c
+index 13ec752..d817f22 100644
+--- a/applet/status.c
++++ b/applet/status.c
+@@ -231,8 +231,6 @@ void status_unavailable(void)
+ {
+ 	icon_animation_stop(animation);
+ 
+-	available = FALSE;
+-
+ 	gtk_status_icon_set_from_pixbuf(statusicon, pixbuf_notifier);
+ 	gtk_status_icon_set_tooltip(statusicon,
+ 				"Connection Manager daemon is not running");
meta/recipes-connectivity/connman/connman-gnome_0.5.bb +3 -2
index 3b7d1b8..dc5527b 100644
@@ -6,14 +6,15 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=eb723b61539feef013de476e68b5c50a \
                     file://properties/main.c;beginline=1;endline=20;md5=50c77c81871308b033ab7a1504626afb \
                     file://common/connman-dbus.c;beginline=1;endline=20;md5=de6b485c0e717a0236402d220187717a"
 DEPENDS = "gtk+ dbus"
-PR = "r3"
+PR = "r4"
 
 RRECOMMENDS_${PN} = "python python-dbus connman connman-plugin-ethernet connman-plugin-loopback connman-plugin-udhcp connman-plugin-wifi connman-plugin-fake connman-plugin-bluetooth connman-plugin-dnsproxy"
 
 SRC_URI = "http://www.kernel.org/pub/linux/network/connman/connman-gnome-${PV}.tar.gz \
            file://connman-gnome.patch \
            file://remove-connman-property-desktop-file.patch \
-           file://service_name_update.patch"
+           file://service_name_update.patch \
+           file://applet_menu_popup_fix.patch"
 
 SRC_URI[md5sum] = "0e1c4c25d19cad9b08a216848a320716"
 SRC_URI[sha256sum] = "4d5fe481b444fc3e64fd9caa149dbcd76de166a25733f18fd93da01d2abf5d1c"
Signature · 1 line
1.6.3.3
Applied
#2 lore raw
In reply to Dongxiao Xu
Quoted 24 lines · Dongxiao Xu

From: Dongxiao Xu<[email protected]>

This pull request fixes [BUGID #472], please help to review and pull.

User may still need to configure network even if all the services are not available currently, for example, setting online/offline mode, etc.

Enable the applet pop up menu even if the service status is unavailable.

Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: dxu4/bugfix
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dxu4/bugfix

Thanks,
Dongxiao Xu<[email protected]>
---

Dongxiao Xu (1):
connman-gnome: Enable config menu popup even services are not
available

  .../connman-gnome/applet_menu_popup_fix.patch      |   19 +++++++++++++++++++
  .../connman/connman-gnome_0.5.bb                   |    5 +++--
  2 files changed, 22 insertions(+), 2 deletions(-)
Quoted 7 lines

create mode 100644 meta/recipes-connectivity/connman/connman-gnome/applet_menu_popup_fix.patch

_______________________________________________
poky mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/poky

Merged into Master

Thanks
Sau!