Skip to contentSkip to conversation

USB 10/100 RJ45 Ethernet Network Adapter

PATCH In review Shahar Havivi 4 participants 5 messages Feb 22, 2011

Subsystems (4)
Networking Network drivers USB networking drivers USB davicom DM9601 driver
lore
Share & tools
lore

Shahar Havivi

author
#0 lore raw

PATCH 1/1 USB 10/100 RJ45 Ethernet Network Adapter

The device is very similar to (0x0fe6, 0x8101),
And works well with dm9601 driver.

---
 drivers/net/usb/dm9601.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
drivers/net/usb/dm9601.c +5 -0
index 02b622e..2d1c8ae 100644
@@ -654,6 +654,11 @@ static const struct usb_device_id products[] = {
 	 USB_DEVICE(0x0a46, 0x9000),	/* DM9000E */
 	 .driver_info = (unsigned long)&dm9601_info,
 	 },
+	{
+	 USB_DEVICE(0x0fe6, 0x9700),	/* DM9601 USB to Fast Ethernet Adapter */
+
+	 .driver_info = (unsigned long)&dm9601_info,
+	 },
 	{},			// END
 };
Signature · 1 line
1.7.3.4
Acked-by on v1 1/1
#1 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Shahar" == Shahar Havivi <[email protected]> writes:

Shahar> The device is very similar to (0x0fe6, 0x8101), Shahar> And works well with dm9601 driver. Shahar> ---

 Shahar>  drivers/net/usb/dm9601.c |    5 +++++

Shahar> 1 files changed, 5 insertions(+), 0 deletions(-)

Shahar> diff --git a/drivers/net/usb/dm9601.c b/drivers/net/usb/dm9601.c Shahar> index 02b622e..2d1c8ae 100644
Shahar> --- a/drivers/net/usb/dm9601.c
Shahar> +++ b/drivers/net/usb/dm9601.c
Shahar> @@ -654,6 +654,11 @@ static const struct usb_device_id products[] = {

 Shahar>  	 USB_DEVICE(0x0a46, 0x9000),	/* DM9000E */
 Shahar>  	 .driver_info = (unsigned long)&dm9601_info,
 Shahar>  	 },

Shahar> + {
Shahar> + USB_DEVICE(0x0fe6, 0x9700), /* DM9601 USB to Fast Ethernet Adapter */
Shahar> +
Shahar> + .driver_info = (unsigned long)&dm9601_info,
Shahar> + },
Shahar> {}, // END

Please put it after the 0x8100 device and get rid of the empty line before .driver_info - Otherwise it looks good.

Acked-by Peter Korsgaard <[email protected]>
Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw
In reply to Shahar Havivi

Hello.

Quoted 2 lines · Shahar Havivi

The device is very similar to (0x0fe6, 0x8101),
And works well with dm9601 driver.

You should sign off your patch in order for it to be merged.

Quoted 9 lines
---
 drivers/net/usb/dm9601.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
drivers/net/usb/dm9601.c +0 -0
index 02b622e..2d1c8ae 100644

drivers/net/usb/dm9601.c static const struct usb_device_id products[] = { · line 659

Quoted 6 lines
drivers/net/usb/dm9601.c +3 -0
@@ -654,6 +654,11 @@ static const struct usb_device_id products[] = {
 	 USB_DEVICE(0x0a46, 0x9000),	/* DM9000E */
 	 .driver_info = (unsigned long)&dm9601_info,
 	 },
+	{
+	 USB_DEVICE(0x0fe6, 0x9700),	/* DM9601 USB to Fast Ethernet Adapter */
+

Extra empty line shouldn't be here I guess...

drivers/net/usb/dm9601.c static const struct usb_device_id products[] = { · line 663

Quoted 4 lines
drivers/net/usb/dm9601.c +2 -0
+	 .driver_info = (unsigned long)&dm9601_info,
+	 },
 	{},			// END
 };

WBR, Sergei

maintainer
#3 lore raw

From: Sergei Shtylyov <[email protected]>
Date: Tue, 22 Feb 2011 22:18:39 +0300

Quoted 8 lines

Hello.

Quoted 2 lines · Shahar Havivi

The device is very similar to (0x0fe6, 0x8101),
And works well with dm9601 driver.

You should sign off your patch in order for it to be merged.

He did, see the follow-up patch with subject

[PATCH-v2] Added support for usb ethernet (0x0fe6, 0x9700)

#4 lore raw

Hello.

Quoted 9 lines · David Miller
Quoted 5 lines
Quoted 2 lines · Shahar Havivi

The device is very similar to (0x0fe6, 0x8101),
And works well with dm9601 driver.

You should sign off your patch in order for it to be merged.

He did, see the follow-up patch with subject

[PATCH-v2] Added support for usb ethernet (0x0fe6, 0x9700)

Yeah, I've somewhat hasted with following up.

WBR, Sergei