groff - fix do_install failure

PATCH In review Mike Westerhof 2 participants 2 messages Feb 23, 2011

Share & tools

Mike Westerhof

author

2011-02-23 18:45 UTC #0 lore raw

PATCH 1/1 groff - fix do_install failure

Bitbaking groff fails in the do_install step, complaining that img/pic* does not exist. Normally, these files would be created by groff itself during the build process, but since we are cross-compiling, the old recipe replaces the invocation of groff and troff with echo commands. However, echo does not create the output files, which eventually results in the do_install failure.

This patch makes groff dependent on groff-native, and instead of using echo, it instructs the build process to use the staged groff binaries.

Signed-off-by Mike Westerhof <[email protected]>

---

recipes/groff/groff_1.20.1.bb +8 -5

index 6ea87dc..5869ff7 100644
@@ -1,7 +1,10 @@
 DESCRIPTION = "GNU roff"
 SECTION = "base"
 LICENSE = "GPL"
-PR = "r2"
+PR = "r3"
+
+DEPENDS = "groff-native"
+DEPENDS_virtclass-native = ""
 
 SRC_URI = "http://ftp.gnu.org/gnu/groff/groff-${PV}.tar.gz \
           "

@@ -15,10 +18,10 @@ PARALLEL_MAKE = ""
 do_configure_prepend(){
        if [ "${BUILD_SYS}" != "${HOST_SYS}" ]; then
                sed -i \
-                   -e '/^GROFFBIN=/s:=.*:=echo:' \
-                   -e '/^TROFFBIN=/s:=.*:=echo:' \
-                   -e '/^GROFF_BIN_PATH=/s:=.*:=:' \
-                   -e '/^GROFF_BIN_DIR=/s:=.*:=:' \
+                   -e '/^GROFFBIN=/s:=.*:=${STAGING_BINDIR_NATIVE}/groff:' \
+                   -e '/^TROFFBIN=/s:=.*:=${STAGING_BINDIR_NATIVE}/troff:' \
+                   -e '/^GROFF_BIN_PATH=/s:=.*:=${STAGING_BINDIR_NATIVE}:' \
+                   -e '/^GROFF_BIN_DIR=/s:=.*:=${STAGING_BINDIR_NATIVE}:' \
                    ${S}/contrib/*/Makefile.sub \
                    ${S}/doc/Makefile.in \
                    ${S}/doc/Makefile.sub

Khem Raj

Acked-by on v1 1/1

2011-02-23 19:32 UTC #1 lore raw

Quoted 10 lines · Mike Westerhof

Bitbaking groff fails in the do_install step, complaining that img/pic* does not exist. Normally, these files would be created by groff itself during the build process, but since we are cross-compiling, the old recipe replaces the invocation of groff and troff with echo commands. However, echo does not create the output files, which eventually results in the do_install failure.
This patch makes groff dependent on groff-native, and instead of using echo, it instructs the build process to use the staged groff binaries.
Signed-off-by Mike Westerhof <[email protected]>

looks good.

Acked-by Khem Raj <[email protected]>

Quoted 39 lines

---
recipes/groff/groff_1.20.1.bb +0 -0
index 6ea87dc..5869ff7 100644
@@ -1,7 +1,10 @@
DESCRIPTION = "GNU roff"
SECTION = "base"
LICENSE = "GPL"
recipes/groff/groff_1.20.1.bb +4 -1
-PR = "r2"
+PR = "r3"
+
+DEPENDS = "groff-native"
+DEPENDS_virtclass-native = ""
SRC_URI = "http://ftp.gnu.org/gnu/groff/groff-${PV}.tar.gz \
"
recipes/groff/groff_1.20.1.bb +0 -0
@@ -15,10 +18,10 @@ PARALLEL_MAKE = ""
  do_configure_prepend(){
if [ "${BUILD_SYS}" != "${HOST_SYS}" ]; then
sed -i \
- -e '/^GROFFBIN=/s:=.*:=echo:' \
- -e '/^TROFFBIN=/s:=.*:=echo:' \
- -e '/^GROFF_BIN_PATH=/s:=.*:=:' \
- -e '/^GROFF_BIN_DIR=/s:=.*:=:' \
+ -e '/^GROFFBIN=/s:=.*:=${STAGING_BINDIR_NATIVE}/groff:' \
+ -e '/^TROFFBIN=/s:=.*:=${STAGING_BINDIR_NATIVE}/troff:' \
+ -e '/^GROFF_BIN_PATH=/s:=.*:=${STAGING_BINDIR_NATIVE}:' \
+ -e '/^GROFF_BIN_DIR=/s:=.*:=${STAGING_BINDIR_NATIVE}:' \
${S}/contrib/*/Makefile.sub \
${S}/doc/Makefile.in \
${S}/doc/Makefile.sub
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel