ARM: reenable DEBUG_SECTION_MISMATCH
PATCH 1/1 ARM: reenable DEBUG_SECTION_MISMATCH
For 2.6.38-rc4-git9 only 29 out of 133 defconfigs still produce section mismatches. These defconfigs produce 55 mismatches (weighted sum, so maybe less uniq mismatches).
This is in my opinion enough to start scaring people about the remaining problems.
--- lib/Kconfig.debug | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
lib/Kconfig.debug +1 -1
@@ -102,7 +102,7 @@ config HEADERS_CHECK config DEBUG_SECTION_MISMATCH bool "Enable full Section mismatch analysis" - depends on UNDEFINED || (BLACKFIN) + depends on ARM || BLACKFIN default y # This option is on purpose disabled for now. # It will be enabled when we are down to a reasonable number
Signature · 1 line
1.7.2.3
Quoted 6 lines · On Wed, 16 Feb 2011 18:23:13 +0100 Uwe Kleine-K?nig wrote:
For 2.6.38-rc4-git9 only 29 out of 133 defconfigs still produce section mismatches. These defconfigs produce 55 mismatches (weighted sum, so maybe less uniq mismatches).
This is in my opinion enough to start scaring people about the remaining problems.
Yes, we have way too many of these and need more eyes on them.
Quoted 11 lines
Signed-off-by Uwe Kleine-K?nig <[email protected]>--- lib/Kconfig.debug | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)lib/Kconfig.debug +0
-0
lib/Kconfig.debug config HEADERS_CHECK · line 105
Quoted 5 lines
lib/Kconfig.debug +1
-1@@ -102,7 +102,7 @@ config HEADERS_CHECK config DEBUG_SECTION_MISMATCH bool "Enable full Section mismatch analysis" - depends on UNDEFINED || (BLACKFIN) + depends on ARM || BLACKFIN
I would even like something like this:
depends on ARM || BLACKFIN || KERNEL_DEVELOPER
or even
select DEBUG_SECTION_MISMATCH if KERNEL_DEVELOPER
to make these warnings appear... but even with today's other warnings, lots of them are ignored.
lib/Kconfig.debug config HEADERS_CHECK · line 108
Quoted 4 lines
lib/Kconfig.debug +0
-0default y # This option is on purpose disabled for now. # It will be enabled when we are down to a reasonable number
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
PATCH 1/1 ARM: reenable DEBUG_SECTION_MISMATCH
In reply to Uwe Kleine-KönigQuoted 6 lines · Uwe Kleine-K?nig
For 2.6.38-rc4-git9 only 29 out of 133 defconfigs still produce section mismatches. These defconfigs produce 55 mismatches (weighted sum, so maybe less uniq mismatches).
This is in my opinion enough to start scaring people about the remaining problems.
@Vincent: Additionally it would be great if kautobuild would recognise these as warnings.
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |
Quoted 17 lines · Uwe Kleine-K?nig
For 2.6.38-rc4-git9 only 29 out of 133 defconfigs still produce section mismatches. These defconfigs produce 55 mismatches (weighted sum, so maybe less uniq mismatches).
This is in my opinion enough to start scaring people about the remaining problems.
Signed-off-by Uwe Kleine-K?nig <[email protected]>--- lib/Kconfig.debug | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)lib/Kconfig.debug +0
-0
lib/Kconfig.debug config HEADERS_CHECK · line 108
Quoted 8 lines
lib/Kconfig.debug +1
-1@@ -102,7 +102,7 @@ config HEADERS_CHECK config DEBUG_SECTION_MISMATCH bool "Enable full Section mismatch analysis" - depends on UNDEFINED || (BLACKFIN) + depends on ARM || BLACKFIN default y # This option is on purpose disabled for now. # It will be enabled when we are down to a reasonable number
If we are deciding to make this ARCH dependent then a blacklist is much preferred.
I know that we have warnings lingering in the kernel for a long time. But throwing these waring in the face of people for each build will be eoung incentive to get most fixed.
Last I took a deeper look at this I had allyesconfig + allmodconfig almost warning free on x86. But I recall that especially the HOTPLUG_CPU stuff was tricky as they misuse the annotation.
We could try to enable it per default - and seem if people scream too much.
Sam
PATCH 1/1 kbuild: reenable section mismatch analysis
This was disabled in commit
e5f95c8 (kbuild: print only total number of section mismatces found)
because there were too many warnings. Now we're down to a reasonable number again, so we start scaring people with the details.
--- lib/Kconfig.debug | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-)
lib/Kconfig.debug +0 -4
@@ -102,11 +102,7 @@ config HEADERS_CHECK config DEBUG_SECTION_MISMATCH bool "Enable full Section mismatch analysis" - depends on UNDEFINED || (BLACKFIN) default y - # This option is on purpose disabled for now. - # It will be enabled when we are down to a reasonable number - # of section mismatch warnings (< 10 for an allyesconfig build) help The section mismatch analysis checks if there are illegal references from one section to another section.
Signature · 1 line
1.7.2.3
Re: [PATCH] kbuild: reenable section mismatch analysis
Quoted 8 lines · On Fri, 18 Feb 2011 21:47:20 +0100 Uwe Kleine-K?nig wrote:
This was disabled in commit
e5f95c8 (kbuild: print only total number of section mismatces found)
because there were too many warnings. Now we're down to a reasonable number again, so we start scaring people with the details.
Signed-off-by Uwe Kleine-K?nig <[email protected]>
Thanks.
Quoted 11 lines
--- lib/Kconfig.debug | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-)lib/Kconfig.debug +0
-0@@ -102,11 +102,7 @@ config HEADERS_CHECK
lib/Kconfig.debug config HEADERS_CHECK · line 108
Quoted 10 lines
lib/Kconfig.debug +0
-4config DEBUG_SECTION_MISMATCH bool "Enable full Section mismatch analysis" - depends on UNDEFINED || (BLACKFIN) default y - # This option is on purpose disabled for now. - # It will be enabled when we are down to a reasonable number - # of section mismatch warnings (< 10 for an allyesconfig build) help The section mismatch analysis checks if there are illegal references from one section to another section.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
Re: [PATCH] kbuild: reenable section mismatch analysis
In reply to Uwe Kleine-König2011/2/18 Uwe Kleine-K?nig <[email protected]>:
Quoted 6 lines
This was disabled in commit
? ? ? ?e5f95c8 (kbuild: print only total number of section mismatces found)
because there were too many warnings. ?Now we're down to a reasonable number again, so we start scaring people with the details.
-mike
Re: [PATCH] kbuild: reenable section mismatch analysis
In reply to Uwe Kleine-KönigQuoted 8 lines · Uwe Kleine-K?nig
This was disabled in commit
e5f95c8 (kbuild: print only total number of section mismatces found)
because there were too many warnings. Now we're down to a reasonable number again, so we start scaring people with the details.
Signed-off-by Uwe Kleine-K?nig <[email protected]>
OK, applied to kbuild-2.6.git#kbuild.
Thanks,
Michal
Andrew Morton
maintainerRe: [PATCH] kbuild: reenable section mismatch analysis
In reply to Uwe Kleine-KönigQuoted 18 lines · On Fri, 18 Feb 2011 21:47:20 +0100 Uwe Kleine-K__nig…
This was disabled in commit
e5f95c8 (kbuild: print only total number of section mismatces found)
because there were too many warnings. Now we're down to a reasonable number again, so we start scaring people with the details.
Signed-off-by Uwe Kleine-K__nig <[email protected]>--- lib/Kconfig.debug | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-)lib/Kconfig.debug +0
-0@@ -102,11 +102,7 @@ config HEADERS_CHECK
lib/Kconfig.debug config HEADERS_CHECK · line 108
Quoted 10 lines
lib/Kconfig.debug +0
-4config DEBUG_SECTION_MISMATCH bool "Enable full Section mismatch analysis" - depends on UNDEFINED || (BLACKFIN) default y - # This option is on purpose disabled for now. - # It will be enabled when we are down to a reasonable number - # of section mismatch warnings (< 10 for an allyesconfig build) help The section mismatch analysis checks if there are illegal references from one section to another section.
eaaaargh! 650 lines of crap added to my i386 allmodconfig build output.
I'll be locally opting out of this one, thanks.
Re: [PATCH] kbuild: reenable section mismatch analysis
Quoted 21 lines · On Thu, 10 Mar 2011 16:41:00 -0800 Andrew Morton wrote:
Quoted 18 lines · On Fri, 18 Feb 2011 21:47:20 +0100 Uwe Kleine-K__nig…
This was disabled in commit
e5f95c8 (kbuild: print only total number of section mismatces found)
because there were too many warnings. Now we're down to a reasonable number again, so we start scaring people with the details.
Signed-off-by Uwe Kleine-K__nig <[email protected]>--- lib/Kconfig.debug | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-)lib/Kconfig.debug +0
-0@@ -102,11 +102,7 @@ config HEADERS_CHECK
Quoted 12 lines
lib/Kconfig.debug config HEADERS_CHECK · line 108
Quoted 10 lines
lib/Kconfig.debug +0
-4config DEBUG_SECTION_MISMATCH bool "Enable full Section mismatch analysis" - depends on UNDEFINED || (BLACKFIN) default y - # This option is on purpose disabled for now. - # It will be enabled when we are down to a reasonable number - # of section mismatch warnings (< 10 for an allyesconfig build) help The section mismatch analysis checks if there are illegal references from one section to another section.eaaaargh! 650 lines of crap added to my i386 allmodconfig build output.
Each message is a bit longish, yes.
Quoted 2 lines
I'll be locally opting out of this one, thanks.
--
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
Re: [PATCH] kbuild: reenable section mismatch analysis
In reply to Andrew Morton2011/3/10 Andrew Morton :
Quoted 12 lines · On Fri, 18 Feb 2011 21:47:20 +0100 Uwe Kleine-K__nig wrote:
Quoted 11 lines
This was disabled in commit
? ? ? e5f95c8 (kbuild: print only total number of section mismatces found)
because there were too many warnings. ?Now we're down to a reasonable number again, so we start scaring people with the details.
lib/Kconfig.debug +0
-0@@ -102,11 +102,7 @@ config HEADERS_CHECK
Quoted 12 lines
Quoted 10 lines
?config
DEBUG_SECTION_MISMATCH
? ? ? bool "Enable full Section mismatch analysis"
- ? ? depends on UNDEFINED || (BLACKFIN)
? ? ? default y
- ? ? # This option is on purpose disabled for now.
- ? ? # It will be enabled when we are down to a reasonable number
- ? ? # of section mismatch warnings (< 10 for an allyesconfig build) ? ? ? help
? ? ? ? The section mismatch analysis checks if there are illegal ? ? ? ? references from one section to another section.eaaaargh! ?650 lines of crap added to my i386 allmodconfig build output.
and it's going to keep staying all f-ed up until people start seeing this stuff themselves when they write the bad code
-mike
Andrew Morton
maintainerRe: [PATCH] kbuild: reenable section mismatch analysis
Quoted 5 lines · On Thu, 10 Mar 2011 20:00:54 -0500 Mike Frysinger <[email protected]> wrote:
Quoted 2 lines
eaaaargh! __650 lines of crap added to my i386 allmodconfig build output.
and it's going to keep staying all f-ed up until people start seeing this stuff themselves when they write the bad code
That won't work - everyone will either disable the messages or will train themselves to ignore them.
Re: [PATCH] kbuild: reenable section mismatch analysis
Quoted 8 lines · Andrew Morton
Quoted 4 lines · On Thu, 10 Mar 2011 20:00:54 -0500 Mike Frysinger wrote:
Quoted 1 line
eaaaargh! __650 lines of crap added to my i386 allmodconfig build output.
and it's going to keep staying all f-ed up until people start seeing this stuff themselves when they write the bad code
That won't work - everyone will either disable the messages or will train themselves to ignore them.
the status quo is obviously not working. i spent quite a bit of time in the past to get the warnings down to 0 for my builds and all ive seen since then is the # creep back up. if people arent being made aware of the issue, they obviously arent going to do anything about it. some people might condition themselves to ignore it, but that applies to any sort of warning message.
-mike
Re: [PATCH] kbuild: reenable section mismatch analysis
In reply to Andrew MortonQuoted 34 lines · Andrew Morton
Quoted 18 lines · On Fri, 18 Feb 2011 21:47:20 +0100 Uwe Kleine-K__nig…
This was disabled in commit
e5f95c8 (kbuild: print only total number of section mismatces found)
because there were too many warnings. Now we're down to a reasonable number again, so we start scaring people with the details.
Signed-off-by Uwe Kleine-K__nig <[email protected]>--- lib/Kconfig.debug | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-)lib/Kconfig.debug +0
-0@@ -102,11 +102,7 @@ config HEADERS_CHECKlib/Kconfig.debug config HEADERS_CHECK · line 108
Quoted 10 lines
lib/Kconfig.debug +0
-4config DEBUG_SECTION_MISMATCH bool "Enable full Section mismatch analysis" - depends on UNDEFINED || (BLACKFIN) default y - # This option is on purpose disabled for now. - # It will be enabled when we are down to a reasonable number - # of section mismatch warnings (< 10 for an allyesconfig build) help The section mismatch analysis checks if there are illegal references from one section to another section.eaaaargh! 650 lines of crap added to my i386 allmodconfig build output.
Quoted 1 line
I'll be locally opting out of this one, thanks.
How about that we enable this in the merge window. And if it continue to be unreasonable then drop it again around rc5 time?
The likelyhood that warnings are fixed is bigger if people see them and get annoyed.
Sam