The parent process need exit of waitpid11.c, waitpid12.c, waitpid13.c

PATCH In review Peng Haitao 3 participants 7 messages Feb 24, 2011 – Mar 9, 2011

lore

Share & tools

lore

Peng Haitao

author

2011-02-24 10:08 UTC #0 lore raw

PATCH 1/1 The parent process need exit of waitpid11.c, waitpid12.c, waitpid13.c

Hi Garrett,

There are two processes in cases, and the test need run from child process, so parent process should exit after invoking cleanup().

Signed-off-by Peng Haitao <[email protected]>

---
 testcases/kernel/syscalls/waitpid/waitpid11.c |    1 +
 testcases/kernel/syscalls/waitpid/waitpid12.c |    1 +
 testcases/kernel/syscalls/waitpid/waitpid13.c |    1 +
 3 files changed, 3 insertions(+), 0 deletions(-)

testcases/kernel/syscalls/waitpid/waitpid11.c +1 -0

index 1e631da..d61b624 100644
@@ -112,6 +112,7 @@ int main(int ac, char **av)
 				tst_resm(TPASS, "%s PASSED", TCID);
 			}
 			cleanup();
+			tst_exit();
 		 } else if (pid < 0) {
 			tst_brkm(TBROK, cleanup, "fork failed");
 		 }

testcases/kernel/syscalls/waitpid/waitpid12.c +1 -0

index 5c0ebe6..ac99c9a 100644
@@ -113,6 +113,7 @@ int main(int argc, char **argv)
 				tst_resm(TPASS, "%s PASSED", TCID);
 			}
 			cleanup();
+			tst_exit();
 		 } else if (pid < 0) {
 			tst_brkm(TBROK, cleanup, "fork failed");
 		 }

testcases/kernel/syscalls/waitpid/waitpid13.c +1 -0

index 8b908a9..7f7393e 100644
@@ -110,6 +110,7 @@ int main(int ac, char **av)
 				tst_resm(TPASS, "%s PASSED", TCID);
 			}
 			cleanup();
+			tst_exit();
 		 } else if (pid < 0) {
 			tst_brkm(TBROK, cleanup, "fork failed");
 		 }

Signature · 17 lines

1.7.1

-- 
Best Regards,
Peng Haitao


------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Garrett Cooper

2011-02-24 16:46 UTC #1 lore raw

Quoted 4 lines · Peng Haitao

Hi Garrett,
There are two processes in cases, and the test need run from child process, so parent process should exit after invoking cleanup().

Looks fine. I'll commit it tonight if no one else beats me to it. Thanks,
-Garrett

------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Peng Haitao

author

2011-02-28 01:06 UTC #2 lore raw

Garrett Cooper said the following on 2011-2-25 0:46:

Quoted 5 lines

Quoted 2 lines
There are two processes in cases, and the test need run from child process, so parent process should exit after invoking cleanup().
Looks fine. I'll commit it tonight if no one else beats me to it. Thanks,

Garrett,

Would you commit the patch?

Thanks,

Signature · 14 lines

Best Regards,
Peng Haitao


------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Garrett Cooper

2011-03-04 10:13 UTC #3 lore raw

Quoted 10 lines · Peng Haitao

Garrett Cooper said the following on 2011-2-25 0:46:
Quoted 5 lines
Quoted 2 lines
There are two processes in cases, and the test need run from child process, so parent process should exit after invoking cleanup().
Looks fine. I'll commit it tonight if no one else beats me to it. Thanks,
Garrett,
Would you commit the patch?

I've committed a more extensive patch. Please test it out and let me know how it goes -- thanks!
-Garrett

------------------------------------------------------------------------------
What You Don't Know About Data Connectivity CAN Hurt You This paper provides an overview of data connectivity, details its effect on application quality, and explores various alternative solutions. http://p.sf.net/sfu/progress-d2d
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Caspar Zhang

2011-03-04 16:00 UTC #4 lore raw

Quoted 3 lines · Garrett Cooper

I've committed a more extensive patch. Please test it out and let me know how it goes -- thanks!
-Garrett

Hi Garrett, compile error occurs in this patch, here is a fix.

Signature · 4 lines

Quality Engineer (Kernel) in
Red Hat Software (Beijing) Co., R&D Branch
http://www.cn.redhat.com/
TEL: +86-10-62608150

From c52a6798caa5dd673eea50b9a41686713e6c1303 Mon Sep 17 00:00:00 2001
From: Caspar Zhang <[email protected]>
Date: Fri, 4 Mar 2011 23:57:39 +0800
Subject: [PATCH] syscalls: waitpid11: fix compile err

Signed-off-by Caspar Zhang <[email protected]>

---
 testcases/kernel/syscalls/waitpid/waitpid11.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

testcases/kernel/syscalls/waitpid/waitpid11.c +1 -1

index 45d828c..368e984 100644
@@ -283,7 +283,7 @@ int main(int ac, char **av)
 void setup_sigint(void)
 {
 	if (signal(SIGINT, inthandlr) == SIG_ERR)
-		tst_brkm(TFAIL|TERRNO, "signal SIGINT failed");
+		tst_brkm(TFAIL|TERRNO, NULL, "signal SIGINT failed");
 }
 
 void setup(void)

Signature · 1 line

1.7.4.1

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Garrett Cooper

2011-03-04 16:17 UTC #5 lore raw

Quoted 6 lines · Caspar Zhang

Quoted 3 lines · Garrett Cooper
I've committed a more extensive patch. Please test it out and let me know how it goes -- thanks!
-Garrett
Hi Garrett, compile error occurs in this patch, here is a fix.

Sorry for the error -- thanks.
-Garrett

Peng Haitao

author

2011-03-09 05:22 UTC #6 lore raw

In reply to Garrett Cooper

Hi Garrett,

Garrett Cooper said the following on 2011-3-4 18:13:

Quoted 4 lines

Quoted 1 line
Would you commit the patch?
I've committed a more extensive patch. Please test it out and let me know how it goes -- thanks!

The patch is OK, thanks for you work.

Best Regards,
Peng

------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
_______________________________________________
Ltp-list mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list