Skip to contentSkip to conversation

alpha: Fix use of irq_to_desc in irq.c

PATCH In review Oliver Falk 2 participants 2 messages Feb 28, 2011 Alpha port

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 alpha: Fix use of irq_to_desc in irq.c

Fixes:
arch/alpha/kernel/irq.c: In function ‘irq_select_affinity’:
arch/alpha/kernel/irq.c:47: error: subscripted value is neither array nor pointer make[1]: *** [arch/alpha/kernel/irq.o] Error 1

alpha/kernel/irq.c renamed from alpha/kernel/irq.c.orig +1 -1
@@ -44,7 +44,7 @@
 
 int irq_select_affinity(unsigned int irq)
 {
-	struct irq_desc *desc = irq_to_desc[irq];
+	struct irq_desc *desc = irq_to_desc(irq);
 	static int last_cpu;
 	int cpu = last_cpu + 1;
 

Seems to be a typo from here:

<http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=a891b393dd7f6ed84ecee98c0eac4a808ff2cbbc>

-of
--
To unsubscribe from this list: send the line "unsubscribe linux-alpha" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

maintainer
#1 lore raw
Quoted 19 lines · Oliver Falk

Fixes:
arch/alpha/kernel/irq.c: In function ‘irq_select_affinity’:
arch/alpha/kernel/irq.c:47: error: subscripted value is neither array nor pointer
make[1]: *** [arch/alpha/kernel/irq.o] Error 1

alpha/kernel/irq.c     2011-02-28 11:32:24.000000000 +0100 renamed from alpha/kernel/irq.c.orig        2011-02-28 11:34:05.000000000 +0100 +1 -1
@@ -44,7 +44,7 @@
 
  int irq_select_affinity(unsigned int irq)
  {
-       struct irq_desc *desc = irq_to_desc[irq];
+       struct irq_desc *desc = irq_to_desc(irq);
        static int last_cpu;
        int cpu = last_cpu + 1;
 
Quoted 6 lines

Seems to be a typo from here:

<http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=a891b393dd7f6ed84ecee98c0eac4a808ff2cbbc>

-of

Thanks!

mhl actually sent a patch for this recently, and it's been sitting in my tree [1] because I haven't had time to push it to Linus. Sorry about this and that you hit this bug.

I'll get everything sent to Linus this week. Thanks for the patch!

Matt

[1] http://git.kernel.org/?p=linux/kernel/git/mattst88/alpha-2.6.git;a=summary
--
To unsubscribe from this list: send the line "unsubscribe linux-alpha" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html