Skip to contentSkip to conversation

u-boot: don't install host mkimage on non-native builds

PATCH In review Bruce Ashfield 2 participants 3 messages Mar 1, 2011

lore
Share & tools
lore
#0 lore raw

cover u-boot: don't install host mkimage on non-native builds

Richar/Saul,

This fixes BUG 777.

The u-boot package clearly uses HOST_CC and HOST_STRIP to build mkimage, so installing it into ${D}${bindir} for anything but the native mkimage is a bad idea. The native recipe has its own install function, so we can safely delete the entire do_install from u-boot.inc

Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: zedd/uboot
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=zedd/uboot

Thanks,
Bruce Ashfield <[email protected]>
---

Bruce Ashfield (1):
u-boot: remove do_install from u-boot.inc

 meta/recipes-bsp/uboot/u-boot.inc |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)
#1 lore raw

PATCH 1/1 u-boot: remove do_install from u-boot.inc

Fixes [BUGID #777]

The do_install rule in u-boot.inc was installing a host tool into the target ${bindir}, which is subsequently stripped with target strip during packaging, and the obvious error ensues.

The native u-boot recipe has its own install rule, and the machine specific u-boot doesn't require mkimage or anything else in the do_install function. So we remove it completely until it is needed again.

---
 meta/recipes-bsp/uboot/u-boot.inc |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)
meta/recipes-bsp/uboot/u-boot.inc +0 -5
index 1457c04..d1cebee 100644
@@ -31,8 +31,3 @@ do_deploy () {
 	ln -sf ${UBOOT_IMAGE} ${UBOOT_SYMLINK}
 }
 addtask deploy before do_build after do_compile
-
-do_install() {
-	install -d ${D}${bindir}
-	install -m 755 tools/mkimage ${D}${bindir}/
-}
Signature · 1 line
1.7.0.4
#2 lore raw
In reply to Bruce Ashfield
Quoted 23 lines · Bruce Ashfield

Richar/Saul,

This fixes BUG 777.

The u-boot package clearly uses HOST_CC and HOST_STRIP to build mkimage, so installing it into ${D}${bindir} for anything but the native mkimage is a bad idea. The native recipe has its own install function, so we can safely delete the entire do_install from u-boot.inc

Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: zedd/uboot
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=zedd/uboot

Thanks,
Bruce Ashfield<[email protected]>
---

Bruce Ashfield (1):
u-boot: remove do_install from u-boot.inc

Quoted 8 lines
  meta/recipes-bsp/uboot/u-boot.inc |    5 -----
  1 files changed, 0 insertions(+), 5 deletions(-)

_______________________________________________
poky mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/poky

Pulled into Master and Bernard

Thanks
Sau!