mx25: Make the UART port number explicit in its setup function
PATCH 1/1 mx25: Make the UART port number explicit in its setup function
--- arch/arm/cpu/arm926ejs/mx25/generic.c | 2 +- board/karo/tx25/tx25.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
arch/arm/cpu/arm926ejs/mx25/generic.c +1 -1
@@ -145,7 +145,7 @@ int cpu_mmc_init (bd_t * bis) }#ifdef CONFIG_MXC_UART -void mx25_uart_init_pins (void ) +void mx25_uart1_init_pins (void ) {struct iomuxc_mux_ctl *muxctl;struct iomuxc_pad_ctl *padctl;
board/karo/tx25/tx25.c +2 -2
@@ -141,9 +141,9 @@ void tx25_fec_init(void)int board_init () {#ifdef CONFIG_MXC_UART -extern void mx25_uart_init_pins (void ); +extern void mx25_uart1_init_pins (void ); -mx25_uart_init_pins (); +mx25_uart1_init_pins ();#endif /* board id for linux */ gd->bd->bi_arch_number =MACH_TYPE_TX25 ;
Signature · 1 line
1.6.0.4
PATCH 1/1 mx25: Make the UART port number explicit in its setup function
Hi Stefano,
Ping?
Regards,
Fabio Estevam
-----Original Message-----
From: Estevam Fabio-R49496
Sent: Thursday, February 17, 2011 5:50 PM
To: u-boot at lists.denx.de
Cc: sbabic at denx.de; Estevam Fabio-R49496
Subject: [PATCH] mx25: Make the UART port number explicit in its setup function
--- arch/arm/cpu/arm926ejs/mx25/generic.c | 2 +- board/karo/tx25/tx25.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
arch/arm/cpu/arm926ejs/mx25/generic.c +1 -1
@@ -145,7 +145,7 @@ int cpu_mmc_init (bd_t * bis) }#ifdef CONFIG_MXC_UART -void mx25_uart_init_pins (void ) +void mx25_uart1_init_pins (void ) {struct iomuxc_mux_ctl *muxctl;struct iomuxc_pad_ctl *padctl;
board/karo/tx25/tx25.c +2 -3
@@ -141,9 +141,9 @@ void tx25_fec_init(void) int board_init() { #ifdef CONFIG_MXC_UART -extern void mx25_uart_init_pins (void ); +extern void mx25_uart1_init_pins (void ); -mx25_uart_init_pins (); +mx25_uart1_init_pins ();#endif /* board id for linux */ gd->bd->bi_arch_number =MACH_TYPE_TX25 ; --
1.6.0.4
PATCH 1/1 mx25: Make the UART port number explicit in its setup function
Quoted 2 lines · On 03/02/2011 02:31 AM, Estevam Fabio-R49496 wrote:
Hi Stefano,
Hi Fabio,
Quoted 1 line
Ping?
As I do not see any fix for the current release, I have not yet merged it into u-boot-imx and I will do it when the window is open again. I imagine your patch is an introduction for further patches, where more as one uart is used, right ? Should it belong maybe to the same patchset ?
checkpatch reports your patch is corrupted. Strange, I do not why, I have fixed myself.
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================
PATCH 1/1 mx25: Make the UART port number explicit in its setup function
On 3/2/2011 6:15 AM, Stefano Babic wrote:
...
Quoted 4 lines
As I do not see any fix for the current release, I have not yet merged it into u-boot-imx and I will do it when the window is open again. I imagine your patch is an introduction for further patches, where more as one uart is used, right ? Should it belong maybe to the same patchset ?
I was working on adding MX25PDK support and I think that that the UART reference should be explicit, as different boards can boot from different UART ports.
Quoted 2 lines
checkpatch reports your patch is corrupted. Strange, I do not why, I have fixed myself.
Thanks, I haven?t noticed this.
Regards,
Fabio Estevam
PATCH 1/1 mx25: Make the UART port number explicit in its setup function
Quoted 3 lines · Fabio Estevam
I was working on adding MX25PDK support and I think that that the UART reference should be explicit, as different boards can boot from different UART ports.
I have applied your patch to u-boot-imx, next branch. Maybe it is easier to you to use it as base for your port.
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================