RFC: x86: kill binutils 2.16.x?
H. Peter Anvin
reviewerbinutils 2.16 (and presumably its prereleases, binutils 2.15.9x) appears to have more bugs than any other version of binutils released in modern history, *before or after*.
We chronically run into problems because that particular binutils version breaks code that works fine elsewhere.
I would like to know who would suffer from formally discontinuing support for that version. I understand some version of SLES shipped it, but I don't know for sure.
-hpa
Signature · 2 lines
H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.
Quoted 11 lines · On Wed, 02 Mar 2011 10:15:14 -0800 "H. Peter Anvin" <[email protected]> wrote:
binutils 2.16 (and presumably its prereleases, binutils 2.15.9x) appears to have more bugs than any other version of binutils released in modern history, *before or after*.
We chronically run into problems because that particular binutils version breaks code that works fine elsewhere.
I would like to know who would suffer from formally discontinuing support for that version. I understand some version of SLES shipped it, but I don't know for sure.
I gave up and became a customer of
http://www.kernel.org/pub/tools/crosstool/index_old.shtml
H. Peter Anvin
reviewerQuoted 10 lines · Andrew Morton
Quoted 7 lines · On Wed, 02 Mar 2011 10:15:14 -0800 "H. Peter Anvin" <[email protected]> wrote:
binutils 2.16 (and presumably its prereleases, binutils 2.15.9x) appears to have more bugs than any other version of binutils released in modern history, *before or after*.
We chronically run into problems because that particular binutils version breaks code that works fine elsewhere.
Quoted 7 lines
Quoted 4 lines
I would like to know who would suffer from formally discontinuing support for that version. I understand some version of SLES shipped it, but I don't know for sure.
I gave up and became a customer of
http://www.kernel.org/pub/tools/crosstool/index_old.shtml
Vegard,
The source directory in the above doesn't seem to match the binary directories, and is stuck at binutils 2.16.1. At the very best this is iffy from a GPL perspective, and very confusing to users.
This is obviously a highly useful project, can we straighten out the source situation?
-hpa
Quoted 19 lines · H. Peter Anvin
Quoted 10 lines · Andrew Morton
Quoted 7 lines · On Wed, 02 Mar 2011 10:15:14 -0800 "H. Peter Anvin" <[email protected]> wrote:
binutils 2.16 (and presumably its prereleases, binutils 2.15.9x) appears to have more bugs than any other version of binutils released in modern history, *before or after*.
We chronically run into problems because that particular binutils version breaks code that works fine elsewhere.
Quoted 7 lines
Quoted 4 lines
I would like to know who would suffer from formally discontinuing support for that version. I understand some version of SLES shipped it, but I don't know for sure.
I gave up and became a customer of
http://www.kernel.org/pub/tools/crosstool/index_old.shtml
Quoted 8 lines
Vegard,
The source directory in the above doesn't seem to match the binary directories, and is stuck at binutils 2.16.1. At the very best this is iffy from a GPL perspective, and very confusing to users.
This is obviously a highly useful project, can we straighten out the source situation?
The binaries has never worked for me (on my Intel Atom 32 bit box). Today I use crosstool-ng - which works great.
[Need to polish my patch to add saprc support...]
URL: http://ymorin.is-a-geek.org/projects/crosstool
Sam
Quoted 26 lines · On Wed, 2 Mar 2011 21:25:51 +0100 Sam Ravnborg wrote:
Quoted 25 lines · H. Peter Anvin
Quoted 10 lines · Andrew Morton
Quoted 7 lines · On Wed, 02 Mar 2011 10:15:14 -0800 "H. Peter Anvin" <[email protected]> wrote:
binutils 2.16 (and presumably its prereleases, binutils 2.15.9x) appears to have more bugs than any other version of binutils released in modern history, *before or after*.
We chronically run into problems because that particular binutils version breaks code that works fine elsewhere.
Quoted 7 lines
Quoted 4 lines
I would like to know who would suffer from formally discontinuing support for that version. I understand some version of SLES shipped it, but I don't know for sure.
I gave up and became a customer of
http://www.kernel.org/pub/tools/crosstool/index_old.shtmlVegard,
The source directory in the above doesn't seem to match the binary directories, and is stuck at binutils 2.16.1. At the very best this is iffy from a GPL perspective, and very confusing to users.
Quoted 8 lines
Quoted 2 lines
This is obviously a highly useful project, can we straighten out the source situation?
The binaries has never worked for me (on my Intel Atom 32 bit box). Today I use crosstool-ng - which works great.
[Need to polish my patch to add saprc support...]
Hm, thanks, I'll try that. I was also having problems with the kernel.org crosstools...
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
Quoted 19 lines · H. Peter Anvin
Quoted 10 lines · Andrew Morton
Quoted 7 lines · On Wed, 02 Mar 2011 10:15:14 -0800 "H. Peter Anvin" <[email protected]> wrote:
binutils 2.16 (and presumably its prereleases, binutils 2.15.9x) appears to have more bugs than any other version of binutils released in modern history, *before or after*.
We chronically run into problems because that particular binutils version breaks code that works fine elsewhere.
Quoted 7 lines
Quoted 4 lines
I would like to know who would suffer from formally discontinuing support for that version. I understand some version of SLES shipped it, but I don't know for sure.
I gave up and became a customer of
http://www.kernel.org/pub/tools/crosstool/index_old.shtml
Quoted 8 lines
Vegard,
The source directory in the above doesn't seem to match the binary directories, and is stuck at binutils 2.16.1. At the very best this is iffy from a GPL perspective, and very confusing to users.
This is obviously a highly useful project, can we straighten out the source situation?
I only uploaded the binaries in
http://www.kernel.org/pub/tools/crosstool/files/bin/old/
which should match the sources in
http://www.kernel.org/pub/tools/crosstool/files/src/
The binaries outside old/ are not made by me, but Tony (added to Cc).
I assume you're talking about the binaries _outside_ bin/old/, but let me know if I'm mistaken :-)
Vegard
H. Peter Anvin
reviewerQuoted 33 lines · Vegard Nossum
Quoted 19 lines · H. Peter Anvin
Quoted 10 lines · Andrew Morton
Quoted 7 lines · On Wed, 02 Mar 2011 10:15:14 -0800 "H. Peter Anvin" <[email protected]> wrote:
binutils 2.16 (and presumably its prereleases, binutils 2.15.9x) appears to have more bugs than any other version of binutils released in modern history, *before or after*.
We chronically run into problems because that particular binutils version breaks code that works fine elsewhere.
Quoted 7 lines
Quoted 4 lines
I would like to know who would suffer from formally discontinuing support for that version. I understand some version of SLES shipped it, but I don't know for sure.
I gave up and became a customer of
http://www.kernel.org/pub/tools/crosstool/index_old.shtmlQuoted 8 lines
Vegard,
The source directory in the above doesn't seem to match the binary directories, and is stuck at binutils 2.16.1. At the very best this is iffy from a GPL perspective, and very confusing to users.
This is obviously a highly useful project, can we straighten out the source situation?
I only uploaded the binaries in
Quoted 9 lines
which should match the sources in
http://www.kernel.org/pub/tools/crosstool/files/src/
The binaries outside old/ are not made by me, but Tony (added to Cc).
I assume you're talking about the binaries _outside_ bin/old/, but let me know if I'm mistaken :-)
Sorry, you're right... I got confused because the index file is still the old one...
-hpa
Quoted 6 lines · H. Peter Anvin
binutils 2.16 (and presumably its prereleases, binutils 2.15.9x) appears to have more bugs than any other version of binutils released in modern history, *before or after*.
We chronically run into problems because that particular binutils version breaks code that works fine elsewhere.
Please lets get rid of known to be broken shite instead of trying to work around it for no good reasons. How old is that crap again ?
Quoted 3 lines
I would like to know who would suffer from formally discontinuing support for that version. I understand some version of SLES shipped it, but I don't know for sure.
You missed to mention that akpm insists on using them :)
Thanks,
tglx
H. Peter Anvin
reviewerQuoted 4 lines · Thomas Gleixner
Please lets get rid of known to be broken shite instead of trying to work around it for no good reasons. How old is that crap again ?
2005-2006.
-hpa
Quoted 7 lines · H. Peter Anvin
Quoted 4 lines · Thomas Gleixner
Please lets get rid of known to be broken shite instead of trying to work around it for no good reasons. How old is that crap again ?
2005-2006.
Time enough even for enterprise folks to sort that out. Please kill it ASAP.
Thanks,
tglx
H. Peter Anvin
reviewerQuoted 8 lines · Thomas Gleixner
Quoted 6 lines · H. Peter Anvin
Quoted 4 lines · Thomas Gleixner
Please lets get rid of known to be broken shite instead of trying to work around it for no good reasons. How old is that crap again ?
Quoted 7 lines
Quoted 1 line
2005-2006.
Time enough even for enterprise folks to sort that out. Please kill it ASAP.
Thanks,
kbuild people: is there a way to test for a specific assembler version in Kbuild (and error out the build for it?)
-hpa
Quoted 11 lines · H. Peter Anvin
Quoted 10 lines · Thomas Gleixner
Quoted 7 lines · H. Peter Anvin
Quoted 4 lines · Thomas Gleixner
Please lets get rid of known to be broken shite instead of trying to work around it for no good reasons. How old is that crap again ?
2005-2006.
Quoted 8 lines
Quoted 5 lines
Time enough even for enterprise folks to sort that out. Please kill it ASAP.
Thanks,
kbuild people: is there a way to test for a specific assembler version in
Kbuild(and error out the build for it?)
Could we add a testcase for one of the more egregious breakages and bail out then? That way we don't have to get the version information right - broken prereleases would be covered as well.
For example this sequence:
.irp idx,0,1,2
.if 0 > \idx
.endif
.endr
Will break on 2.16, right? It builds fine on 2.20.
This is how specific GAS functionality is tested in arch/powerpc:
@if ! /bin/echo dssall | $(AS) -many -o $(TOUT) >/dev/null 2>&1 ; then \
echo -n '*** ${VERSION}.${PATCHLEVEL} kernels no longer build ' ; \
echo 'correctly with old versions of binutils.' ; \
echo '*** Please upgrade your binutils to 2.12.1 or newer' ; \
false ; \
fiThis would also be a 'constructive' (and safest) way of blacklisting binutils: we'd really only exclude binutils that is truly buggy.
Thanks,
Ingo
Quoted 11 lines · Ingo Molnar
This is how specific GAS functionality is tested in
arch/powerpc:@if !
/bin/echodssall | $(AS) -many -o $(TOUT) >/dev/null 2>&1 ; then \
echo -n '*** ${VERSION}.${PATCHLEVEL} kernels no longer build ' ; \
echo 'correctly with old versions of binutils.' ; \
echo '*** Please upgrade your binutils to 2.12.1 or newer' ; \
false ; \
fiThis would also be a 'constructive' (and safest) way of blacklisting binutils: we'd really only exclude binutils that is truly buggy.
Hrm... well... actually...
It's funny that you brought up this particular case. While I agree that it's good in general, it's causing problems for me building a kernel using a recent e500 gcc/binutils (triplet "powerpc-linux-gnuspe").
Specifically the e500 doesn't have a normal PowerPC FPU, it has a custom FPU built using extended integer registers instead, and it happens to borrow the AltiVec opcode range to do it.
When trying to port Debian to the platform we were getting SIGILL's all over the place until binutils got updated to reject all of the unsupported opcodes on this particular platform. Now of course we get build errors, but that's a lot easier to debug and fix. :-D
Basically, binutils no longer supports "-many" (because too many opcodes conflict), and the test itself would fail anyways (because "dssall" is not valid on "any" PowerPC).
So while I think that it is entirely reasonable to add a similar test for buggy x86 binutils, I'm actually about to send a patch to remove that particular check from the powerpc Makefile. Since the "required" binutils 2.12.1 was released in May 2002 (almost 9 years ago) it's probably not even worth testing for anymore.
Cheers,
Kyle Moffett
Quoted 5 lines · Kyle Moffett
Specifically the e500 doesn't have a normal PowerPC FPU, it has a custom FPU built using extended integer registers instead, and it happens to borrow the AltiVec opcode range to do it.
Quoted 8 lines
When trying to port Debian to the platform we were getting SIGILL's all over the place until binutils got updated to reject all of the unsupported opcodes on this particular platform. Now of course we get build errors, but that's a lot easier to debug and fix. :-D
Basically, binutils no longer supports "-many" (because too many opcodes conflict), and the test itself would fail anyways (because "dssall" is not valid on "any" PowerPC).
Note that this freescale "SPE" fiasco is just that ... a fiasco :-) I don't think there's that many cases of opcode overlap outside of it.
Now regarding the kernel, the best is probably for nasty cases like that to use hand coded opcodes (see ppc-opcodes.h) and stick to a more "generic" setting for binutils, since it should be possible to build kernels that support multiple types of BookE CPUs with different floating point units.
Cheers,
Ben.
Quoted 15 lines · On Wed, 9 Mar 2011 08:28:36 +1100 Benjamin Herrenschmidt…
Quoted 5 lines · Kyle Moffett
Specifically the e500 doesn't have a normal PowerPC FPU, it has a custom FPU built using extended integer registers instead, and it happens to borrow the AltiVec opcode range to do it.
Quoted 8 lines
When trying to port Debian to the platform we were getting SIGILL's all over the place until binutils got updated to reject all of the unsupported opcodes on this particular platform. Now of course we get build errors, but that's a lot easier to debug and fix. :-D
Basically, binutils no longer supports "-many" (because too many opcodes conflict), and the test itself would fail anyways (because "dssall" is not valid on "any" PowerPC).
Quoted 8 lines
Note that this freescale "SPE" fiasco is just that ... a fiasco :-) I don't think there's that many cases of opcode overlap outside of it.
Now regarding the kernel, the best is probably for nasty cases like that to use hand coded opcodes (see
ppc-opcodes.h) and stick to a more "generic" setting for binutils, since it should be possible to build kernels that support multiple types of BookE CPUs with different floating point units.
Combined kernels between e500v1/2 and e500mc are currently not supported for other reasons (current kconfig doesn't prohibit it, but it doesn't work), such as a cache line size difference (a hardcoded L1_CACHE_BYTES is used in various places for loops), an inability to enable SPE when e500mc is enabled, etc.
Kumar recently internally said we're not going to bother making it work. I'm inclined to agree, given you can't even run the same userspace (unless you don't use hard floating point at all). It's one thing to not want to require a separate kernel for each board, but there's a point of diminishing returns.
-Scott
Quoted 10 lines · Benjamin Herrenschmidt
Quoted 9 lines · Kyle Moffett
Specifically the e500 doesn't have a normal PowerPC FPU, it has a custom FPU built using extended integer registers instead, and it happens to borrow the AltiVec opcode range to do it.
When trying to port Debian to the platform we were getting SIGILL's all over the place until binutils got updated to reject all of the unsupported opcodes on this particular platform. Now of course we get build errors, but that's a lot easier to debug and fix. :-D
Quoted 6 lines
Quoted 3 lines
Basically, binutils no longer supports "-many" (because too many opcodes conflict), and the test itself would fail anyways (because "dssall" is not valid on "any" PowerPC).
Note that this freescale "SPE" fiasco is just that ... a fiasco :-) I don't think there's that many cases of opcode overlap outside of it.
I absolutely agree on the "fiasco" part, although I'm pretty sure that there's a large number of incompatible ARM variants (even 16-bit vs. 32-bit opcodes). Unfortunately there's a lot of shipped hardware to be supported and maintained...
Quoted 5 lines
Now regarding the kernel, the best is probably for nasty cases like that to use hand coded opcodes (see
ppc-opcodes.h) and stick to a more "generic" setting for binutils, since it should be possible to build kernels that support multiple types of BookE CPUs with different floating point units.
The problem is not with the kernel compile itself, but with the 2.12 "dssall" binutils test. Basically, recent binutils treats e500 as effectively a separate architecture that happens to share *most* of the opcodes with regular PowerPC. Any opcode which is not understood by the e500 chip is either convert to an equivalent opcode which is understood (IE: lwsync => sync), or failed with an error. This means that the kernel compile aborts early telling me to upgrade to a newer version of binutils.
This was *critical* for getting an actual Debian distribution bootstrapped on the e500 cores, because so much software assumes PowerPC == altivec (ffmpeg), hardcodes 'asm("lwsync")' for memory barriers (80+ packages in Debian), or includes hand-coded floating-point ASM instructions (libffi). Noisy build errors are better than silent runtime failures any day of the week.
At the very least that test needs to be turned off if CONFIG_ALTIVEC=n, because the kernel builds and runs fine otherwise.
Cheers,
Kyle Moffett
Quoted 5 lines · Kyle Moffett
The problem is not with the kernel compile itself, but with the 2.12 "dssall" binutils test. Basically, recent binutils treats e500 as effectively a separate architecture that happens to share *most* of the opcodes with regular PowerPC.
This is bogus. Newer e500 don't have that SPE crap afaik and BookI and II of the architecture have been converged. In fact, Scott, don't newer FSL chips also support real lwsync ?
Quoted 5 lines
Any opcode which is not understood
by the e500 chip is either convert to an equivalent opcode which is understood (IE: lwsync => sync), or failed with an error. This means that the kernel compile aborts early telling me to upgrade to a newer version of binutils.
This is more bogosity in binutils. lwsync is designed to fallback as sync if not supported in -HW-, binutils shouldn't silently swallow it.
Or is it that FSL failed on the original e500 and make lwsync actually trap ?
Quoted 9 lines
This was *critical* for getting an actual Debian distribution bootstrapped on the e500 cores, because so much software assumes PowerPC == altivec (ffmpeg), hardcodes '
asm("lwsync")' for memory barriers (80+ packages in Debian), or includes hand-coded floating-point ASM instructions (libffi). Noisy build errors are better than silent runtime failures any day of the week.At the very least that test needs to be turned off if
CONFIG_ALTIVEC=n, because the kernel builds and runs fine otherwise.
I think the right thing is to keep that as e500-legacy or something, because afaik, newer e500's don't have most of these issues and could be treated as "normal" powerpc again.
Cheers,
Ben.
Quoted 10 lines · Benjamin Herrenschmidt
Quoted 5 lines · Kyle Moffett
The problem is not with the kernel compile itself, but with the 2.12 "dssall" binutils test. Basically, recent binutils treats e500 as effectively a separate architecture that happens to share *most* of the opcodes with regular PowerPC.
This is bogus. Newer e500 don't have that SPE crap afaik and BookI and II of the architecture have been converged. In fact, Scott, don't newer FSL chips also support real lwsync ?
When I'm talking about "e500" I'm specifically referring to the SPE stuff. The "e500mc" cores are a whole different beast with a regular FPU, but those have their own Kconfig option: "PPC_E500MC".
Actually, looking at it again, the "PPC_E500MC" depends on "E500", it should select "PPC_FSL_BOOK3E" instead. There are probably bugs lurking here.
There really is fundamentally no good way to build a single system image that supports both E500 (spe-based) and E500MC (classic FPU). You can sort-of run classic FPU emulation on the E500, but the performance is terrifyingly bad.
The naming confusion really is really bad too, IMO.
Quoted 11 lines
Quoted 5 lines
Any opcode which is not understood
by the e500 chip is either convert to an equivalent opcode which is understood (IE: lwsync => sync), or failed with an error. This means that the kernel compile aborts early telling me to upgrade to a newer version of binutils.This is more bogosity in binutils. lwsync is designed to fallback as sync if not supported in -HW-, binutils shouldn't silently swallow it.
Or is it that FSL failed on the original e500 and make lwsync actually trap ?
Yeah... for some reason FreeScale made the "lwsync" operation trap on e500 (again, only talking about "e500" with SPE, not "e500mc").
Unfortunately it's used frequently enough that there's a very noticeable performance gain (~5% for some programs) by substituting it in binutils, so that's what happens.
Quoted 7 lines
Quoted 7 lines
This was *critical* for getting an actual Debian distribution bootstrapped on the e500 cores, because so much software assumes PowerPC == altivec (ffmpeg), hardcodes '
asm("lwsync")' for memory barriers (80+ packages in Debian), or includes hand-coded floating-point ASM instructions (libffi). Noisy build errors are better than silent runtime failures any day of the week.
Quoted 6 lines
Quoted 2 lines
At the very least that test needs to be turned off if
CONFIG_ALTIVEC=n, because the kernel builds and runs fine otherwise.I think the right thing is to keep that as e500-legacy or something, because afaik, newer e500's don't have most of these issues and could be treated as "normal" powerpc again.
There is a separate "-me500mc" option for GAS that does the right thing, but the kernel currently does not seem to use it.
arch/powerpc/Makefile has this:
cpu-as-$(CONFIG_4xx) += -Wa,-m405
cpu-as-$(CONFIG_6xx) += -Wa,-maltivec
cpu-as-$(CONFIG_POWER4) += -Wa,-maltivec
cpu-as-$(CONFIG_E500) += -Wa,-me500
cpu-as-$(CONFIG_E200) += -Wa,-me200As it is, I strongly suspect that the kernel is broken for CONFIG_E500MC with current development releases of binutils.
The real "solution" is that "e500" needs to be treated as an almost entirely different architecture from "all other powerpc (including e500mc)". Userspace is only ABI-compatible if you use "-msoft-float" on both sides.
I've been dealing with it for a while now, it really is a fiasco all around...
After a month of wrestling with the official Debian "powerpc" port we gave up and created a new port "powerpcspe" specifically for the "e500" SPE-based chips. Then we tripped over 3 relatively major GCC bugs which had been lurking since e500 support was initially added.
See http://wiki.debian.org/PowerPCSPEPort for a very out-of-date status on that whole thing.
Cheers,
Kyle Moffett
Quoted 8 lines
The problem is not with the kernel compile itself, but with the 2.12 "dssall" binutils test. Basically, recent binutils treats e500 as effectively a separate architecture that happens to share *most* of the opcodes with regular PowerPC. Any opcode which is not understood by the e500 chip is either convert to an equivalent opcode which is understood (IE: lwsync => sync), or failed with an error. This means that the kernel compile aborts early telling me to upgrade to a newer version of binutils.
$ echo dssall | powerpc-linux-as -many -me500 $ powerpc-linux-objdump -d a.out | grep 0: 0: 7e 00 06 6c dssall $ powerpc-linux-as --version | head -1 GNU assembler (GNU Binutils) 2.21.51.20110309
What version of binutils does not work? (I also checked with -me500x2, -me500mc, -mspe, and various combinations. lwsync is indeed converted to a regular sync (well, "msync") for e500 and e500x2).
Segher
Quoted 8 lines · Ingo Molnar
Quoted 2 lines · H. Peter Anvin
kbuild people: is there a way to test for a specific assembler version in
Kbuild(and error out the build for it?)Could we add a testcase for one of the more egregious breakages and bail out then? That way we don't have to get the version information right - broken prereleases would be covered as well.
Quoted 8 lines
For example this sequence:
.irp idx,0,1,2
.if 0 > \idx
.endif
.endrWill break on 2.16, right? It builds fine on 2.20.
This seems to work for me with the binutils version from sles10 (even with a vanilla build of binutils):
$ as -v <<EOF; echo $?
Quoted 5 lines
.irp idx,0,1,2
.if 0 > \idx
.endif
.endr
EOF
GNU assembler version 2.16.91.0.5 (i586-suse-linux) using BFD version 2.16.91.0.5 20051219
0
$
So either the bug is fixed in that version already or you picked a wrong example (or I did not understand what should fail here). But don't get me wrong, I'm all for checking for actual bugs instead of innocent version strings.
Michal
Quoted 31 lines · Michal Marek
Quoted 8 lines · Ingo Molnar
Quoted 2 lines · H. Peter Anvin
kbuild people: is there a way to test for a specific assembler version in
Kbuild(and error out the build for it?)Could we add a testcase for one of the more egregious breakages and bail out then? That way we don't have to get the version information right - broken prereleases would be covered as well.
Quoted 8 lines
For example this sequence:
.irp idx,0,1,2
.if 0 > \idx
.endif
.endrWill break on 2.16, right? It builds fine on 2.20.
This seems to work for me with the binutils version from sles10 (even with a vanilla build of binutils):
$ as -v <<EOF; echo $?Quoted 5 lines
.irp idx,0,1,2
.if 0 > \idx
.endif
.endr
EOFGNU assembler version 2.16.91.0.5 (i586-suse-linux) using BFD version 2.16.91.0.5 20051219
0
$
Quoted 4 lines
So either the bug is fixed in that version already or you picked a wrong example (or I did not understand what should fail here). But don't get me wrong, I'm all for checking for actual bugs instead of innocent version strings.
I cited an incorrect testcase most likely. Note that Jan was able to work around the limitations in 2.16 after all - see the workaround commit that i have queued up in x86/mm, attached below.
Thanks,
Ingo
--------------->
From d04c579f971bf7d995db1ef7a7161c0143068859 Mon Sep 17 00:00:00 2001
From: Jan Beulich <[email protected]>
Date: Thu, 3 Mar 2011 10:55:29 +0000
Subject: [PATCH] x86: Work around old gas bug
Add extra parentheses around a couple of definitions introduced by "x86: Cleanup vector usage" and used in assembly macro arguments, and remove spaces. Without that old (2.16.1) gas would see more macro arguments than were actually specified.
LKML-Reference: <[email protected]>
--- arch/x86/include/asm/irq_vectors.h | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
arch/x86/include/asm/irq_vectors.h +4 -4
@@ -126,14 +126,14 @@/* up to 32 vectors used for spreading out TLB flushes: */ #if NR_CPUS <=32 -# define NUM_INVALIDATE_TLB_VECTORS NR_CPUS +# define NUM_INVALIDATE_TLB_VECTORS (NR_CPUS)#else -# define NUM_INVALIDATE_TLB_VECTORS 32 +# define NUM_INVALIDATE_TLB_VECTORS (32)#endif -#define INVALIDATE_TLB_VECTOR_END 0xee +#define INVALIDATE_TLB_VECTOR_END (0xee)#define INVALIDATE_TLB_VECTOR_START \ - (INVALIDATE_TLB_VECTOR_END - NUM_INVALIDATE_TLB_VECTORS + 1) + (INVALIDATE_TLB_VECTOR_END-NUM_INVALIDATE_TLB_VECTORS+1)#define NR_VECTORS 256