power: ftpmu010: move drivers/power/ftpmu010.h to include/

PATCH Superseded Po-Yu Chuang 3 participants 9 messages Feb 16, 2011 – Mar 18, 2011

lore

Share & tools

lore

Po-Yu Chuang

author

2011-02-16 09:10 UTC #0 lore raw

PATCH 1/2 power: ftpmu010: move drivers/power/ftpmu010.h to include/

From: Po-Yu Chuang <[email protected]>

Also add API declarations.

Signed-off-by Po-Yu Chuang <[email protected]>

---
 drivers/power/ftpmu010.c |    2 +-
 drivers/power/ftpmu010.h |  146 --------------------------------------------
 include/ftpmu010.h       |  150 ++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 151 insertions(+), 147 deletions(-)
 delete mode 100644 drivers/power/ftpmu010.h
 create mode 100644 include/ftpmu010.h

drivers/power/ftpmu010.c +1 -1

index 7924ac1..dc4ca5d 100644
@@ -23,7 +23,7 @@
 
 #include <common.h>
 #include <asm/io.h>
-#include "ftpmu010.h"
+#include <ftpmu010.h>
 
 static struct ftpmu010 *pmu = (struct ftpmu010 *)CONFIG_FTPMU010_BASE;

drivers/power/ftpmu010.h deleted +0 ~~-146~~

146 lines not on this page · raw message

include/ftpmu010.h new file +150 -0

150 lines not on this page · raw message

Signature · 1 line

1.6.3.3

Macpaul Lin

2011-02-16 09:23 UTC #1 lore raw

PATCH 1/2 power: ftpmu010: move drivers/power/ftpmu010.h to include/

Hi Po-Yu,

2011/2/16 Po-Yu Chuang <[email protected]>:

Quoted 4 lines

From: Po-Yu Chuang <[email protected]>
Also add API declarations.

Quoted 8 lines

Signed-off-by Po-Yu Chuang <[email protected]>
---
?drivers/power/ftpmu010.c | ? ?2 +-
?drivers/power/ftpmu010.h | ?146 --------------------------------------------
?include/ftpmu010.h ? ? ? | ?150 ++++++++++++++++++++++++++++++++++++++++++++++
?3 files changed, 151 insertions(+), 147 deletions(-) ?delete mode 100644 drivers/power/ftpmu010.h ?create mode 100644 include/ftpmu010.h

Just one comment which has been replied earlier in the previous discuss. Put ftpmu010.h into "include/faraday" instead of "include".

Signature · 2 lines

Best regards,
Macpaul Lin

Po-Yu Chuang

author

2011-02-16 09:36 UTC #2 lore raw

PATCH 1/2 power: ftpmu010: move drivers/power/ftpmu010.h to include/

Hi Macpaul,

Quoted 16 lines · Macpaul Lin

Hi Po-Yu,
2011/2/16 Po-Yu Chuang <[email protected]>:
Quoted 4 lines
From: Po-Yu Chuang <[email protected]>
Also add API declarations.
Quoted 8 lines
Signed-off-by Po-Yu Chuang <[email protected]>
---
?drivers/power/ftpmu010.c | ? ?2 +-
?drivers/power/ftpmu010.h | ?146 --------------------------------------------
?include/ftpmu010.h ? ? ? | ?150 ++++++++++++++++++++++++++++++++++++++++++++++
?3 files changed, 151 insertions(+), 147 deletions(-) ?delete mode 100644 drivers/power/ftpmu010.h ?create mode 100644 include/ftpmu010.h

Quoted 2 lines

Just one comment which has been replied earlier in the previous discuss. Put ftpmu010.h into "include/faraday" instead of "include".

Agree. It will be nicer.

Wolfgang, do you have any comment?

regards,
Po-Yu Chuang

Po-Yu Chuang

author

2011-02-18 05:34 UTC #3 lore raw

PATCH v2 1/2 power: ftpmu010: move drivers/power/ftpmu010.h to include/faraday

In reply to Po-Yu Chuang

From: Po-Yu Chuang <[email protected]>

Also add API declarations.

Signed-off-by Po-Yu Chuang <[email protected]>

---
v2:
move include/ftpmu010.h to include/faraday/ftpmu010.h

 drivers/power/ftpmu010.c   |    2 +-
 drivers/power/ftpmu010.h   |  146 ------------------------------------------
 include/faraday/ftpmu010.h |  150 ++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 151 insertions(+), 147 deletions(-)
 delete mode 100644 drivers/power/ftpmu010.h
 create mode 100644 include/faraday/ftpmu010.h

drivers/power/ftpmu010.c +1 -1

index 7924ac1..c6a8cda 100644
@@ -23,7 +23,7 @@
 
 #include <common.h>
 #include <asm/io.h>
-#include "ftpmu010.h"
+#include <faraday/ftpmu010.h>
 
 static struct ftpmu010 *pmu = (struct ftpmu010 *)CONFIG_FTPMU010_BASE;

drivers/power/ftpmu010.h deleted +0 ~~-146~~

146 lines not on this page · raw message

include/faraday/ftpmu010.h new file +150 -0

150 lines not on this page · raw message

Signature · 1 line

1.6.3.3

Macpaul Lin

2011-02-25 10:14 UTC #4 lore raw

PATCH v2 1/2 power: ftpmu010: move drivers/power/ftpmu010.h to include/faraday

Hi Wolfgang and Albert,

2011/2/18 Po-Yu Chuang <[email protected]>

Quoted 5 lines

From: Po-Yu Chuang <[email protected]>
Also add API declarations.
Signed-off-by Po-Yu Chuang <[email protected]>

Quoted 9 lines

---
v2:
move include/ftpmu010.h to include/faraday/ftpmu010.h

 drivers/power/ftpmu010.c   |    2 +-
 drivers/power/ftpmu010.h   |  146
------------------------------------------
 include/faraday/ftpmu010.h |  150 ++++++++++++++++++++++++++++++--

If the patch is reviewed and acceptable, would you please apply this patch in order to move ftpmu010.h from driver folder to include/faraday folder? Thus Po-Yu and I will commit the header definitions of those hardware peripherals made by Faraday into "include/faraday" folder to avoid this kind of "include ../../xxx.h" statement in other codes.

Thanks a lot.

Best regards,
Macpaul Lin

Macpaul Lin

2011-02-25 10:58 UTC #5 lore raw

PATCH v2 1/2 power: ftpmu010: move drivers/power/ftpmu010.h to include/faraday

HI all,

2011/2/25 Macpaul Lin <[email protected]>

Quoted 14 lines

Hi Wolfgang and Albert,
2011/2/18 Po-Yu Chuang <[email protected]>
Quoted 10 lines
From: Po-Yu Chuang <[email protected]>
Also add API declarations.
Signed-off-by Po-Yu Chuang <[email protected]>
---
v2:
move include/ftpmu010.h to include/faraday/ftpmu010.h

Quoted 6 lines

Quoted 3 lines
?drivers/power/ftpmu010.c ? | ? ?2 +-
?drivers/power/ftpmu010.h ? | ?146 ------------------------------------------
?include/faraday/ftpmu010.h | ?150 ++++++++++++++++++++++++++++++--
If the patch is reviewed and acceptable, would you please apply this patch in order to move ftpmu010.h from driver folder to include/faraday folder?
Thus Po-Yu and I will commit the header definitions of those hardware peripherals made by Faraday into "include/faraday" folder to avoid this kind of "include ../../xxx.h" statement in other codes.

Previous patch (/patch/83344/,
http://patchwork.ozlabs.org/patch/83344/) about ftpmu010.h include path fix in a320 was set to "superseded" in patchwork to avoid confusing when applying code.

Two better patches has been submit by Po-Yu as patch
http://patchwork.ozlabs.org/patch/83534/
and patch
http://patchwork.ozlabs.org/patch/83535/

--
Best regards,
Macpaul Lin

Albert ARIBAUD

2011-03-03 07:26 UTC #6 lore raw

PATCH v2 1/2 power: ftpmu010: move drivers/power/ftpmu010.h to include/faraday

In reply to Po-Yu Chuang

Le 18/02/2011 06:34, Po-Yu Chuang a ?crit :

Quoted 6 lines

From: Po-Yu Chuang<[email protected]>
Also add API declarations.
Signed-off-by Po-Yu Chuang<[email protected]>
---

Applied to u-boot-arm/next, thanks!

Wolfgang: I have put the patches in 'Awaiting upstream' state as none of the states described in
<http://www.denx.de/wiki/view/U-Boot/Patches#Patchwork_work_flow> seemed to fit "sitting in -next waiting to get into -master". If you'd prefer another state, just let me know.

Amicalement,

Signature · 1 line

Albert.

Macpaul Lin

2011-03-18 05:57 UTC #7 lore raw

PATCH v2 1/2 power: ftpmu010: move drivers/power/ftpmu010.h to include/faraday

In reply to Po-Yu Chuang

Hi Po-Yu,

2011/2/18 Po-Yu Chuang <[email protected]>

Quoted 8 lines

move include/ftpmu010.h to include/faraday/ftpmu010.h
?drivers/power/ftpmu010.c ? | ? ?2 +-
?drivers/power/ftpmu010.h ? | ?146 ------------------------------------------
?include/faraday/ftpmu010.h | ?150 ++++++++++++++++++++++++++++++++++++++++++++
?3 files changed, 151 insertions(+), 147 deletions(-) ?delete mode 100644 drivers/power/ftpmu010.h ?create mode 100644 include/faraday/ftpmu010.h

Sorry I didn't notice that there are API declaration before in ftpmu010.h.

include/faraday/ftpmu010.h line 148

Quoted 3 lines

include/faraday/ftpmu010.h new file +3 -0

+void ftpmu010_32768osc_enable(void);
+void ftpmu010_dlldis_disable(void);
+void ftpmu010_sdram_clk_disable(unsigned int cr0);

Po-Yu, does these three function declaration is a necessity in a320evb?

I'm using gcc 4.4 without these 3 function declaration seems okay. Because I'm going to refine another enhancement patch for using ftpmu010 in lowlevel_init.S.
Hence I need to use #ifndef __ASSEMBLY__ to protect these three APIs. However, to compile adp-ag101 board (NDS32) doesn't require these 3 functions to be declared here. I need your opinion to clarify this.

Thanks a lot.

Signature · 2 lines

Best regards,
Macpaul Lin

Po-Yu Chuang

author

2011-03-18 06:15 UTC #8 lore raw

PATCH v2 1/2 power: ftpmu010: move drivers/power/ftpmu010.h to include/faraday

Hi Macpaul,

Quoted 13 lines · Macpaul Lin

2011/2/18 Po-Yu Chuang <[email protected]>
Quoted 8 lines
move include/ftpmu010.h to include/faraday/ftpmu010.h
?drivers/power/ftpmu010.c ? | ? ?2 +-
?drivers/power/ftpmu010.h ? | ?146 ------------------------------------------
?include/faraday/ftpmu010.h | ?150 ++++++++++++++++++++++++++++++++++++++++++++
?3 files changed, 151 insertions(+), 147 deletions(-) ?delete mode 100644 drivers/power/ftpmu010.h ?create mode 100644 include/faraday/ftpmu010.h
Sorry I didn't notice that there are API declaration before in ftpmu010.h.
Quoted 1 line
+void ftpmu010_32768osc_enable(void);

This is used by a320evb.

Quoted 2 lines

include/faraday/ftpmu010.h line 148
Quoted 2 lines
include/faraday/ftpmu010.h new file +2 -0
+void ftpmu010_dlldis_disable(void);
+void ftpmu010_sdram_clk_disable(unsigned int cr0);

These are not.

Quoted 3 lines

Po-Yu, does these three function declaration is a necessity in a320evb?
I'm using gcc 4.4 without these 3 function declaration seems okay.

Either adp-ag101 does not use any of them or you put the declarations somewhere in board-specific code which is wrong.

Quoted 3 lines

Because I'm going to refine another enhancement patch for using ftpmu010 in lowlevel_init.S.
Hence I need to use #ifndef __ASSEMBLY__ to protect these three APIs.

No problem here. Please use __ASSEMBLY__.

Quoted 2 lines

However, to compile adp-ag101 board (NDS32) doesn't require these 3 functions to be declared here. I need your opinion to clarify this.

Does your board use ftpmu010_dlldis_disable() or
ftpmu010_sdram_clk_disable() ?

Best regards,
Po-Yu Chuang